[go: up one dir, main page]

Page MenuHomePhabricator

Minerva should not touch red links to special pages
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
A drawer shows at the bottom which talks about "creating page".

What should have happened instead?:
Special pages cannot be created by the user, so these red links should be ignored by the skin-specific scripts.

Event Timeline

Change 770080 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/skins/MinervaNeue@master] initMobile: Ignore red links to special pages

https://gerrit.wikimedia.org/r/770080

Bhsd removed Bhsd as the assignee of this task.Mar 12 2022, 8:53 AM

Change 770085 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Filter out red links which link to special pages

https://gerrit.wikimedia.org/r/770085

Change 770080 abandoned by Bhsd:

[mediawiki/skins/MinervaNeue@master] initMobile: Ignore red links to special pages

Reason:

Fix this bug in MobileFrontend instead.

https://gerrit.wikimedia.org/r/770080

It seems to me a little odd that the contributions link is marked up with the new class. The new class should only be used for pages that don't exist. I think this needs some design input before it can be considered for code review. https://en.m.wikipedia.org/wiki/Special:Contributions/!_! is not a red link. It has useful information about an account being blocked.

Tagging Growth team who maintain the contributions page and may have opinions on this.

Looks like this behaviour was added in T156879 but I don't see any involvement from WMF teams in this design decision which seems a little odd to me.

Looks like this behaviour was added in T156879 but I don't see any involvement from WMF teams in this design decision which seems a little odd to me.

It was not added in that patch. It predates that patch for a decade actually, since 2007: 5bf4f2867748adba3a7d1678822a0ff78fba9ee8

Thanks for the correction! Seems like a good time to check in on whether the treatment makes sense here (or perhaps a different one)

kostajh added subscribers: RHo, Trizek-WMF, kostajh.

It seems to me a little odd that the contributions link is marked up with the new class. The new class should only be used for pages that don't exist. I think this needs some design input before it can be considered for code review. https://en.m.wikipedia.org/wiki/Special:Contributions/!_! is not a red link. It has useful information about an account being blocked.

Tagging Growth team who maintain the contributions page and may have opinions on this.

Looks like this behaviour was added in T156879 but I don't see any involvement from WMF teams in this design decision which seems a little odd to me.

@RHo @Trizek-WMF do you have an opinion on this?

It seems to me a little odd that the contributions link is marked up with the new class. The new class should only be used for pages that don't exist. I think this needs some design input before it can be considered for code review. https://en.m.wikipedia.org/wiki/Special:Contributions/!_! is not a red link. It has useful information about an account being blocked.

Tagging Growth team who maintain the contributions page and may have opinions on this.

Looks like this behaviour was added in T156879 but I don't see any involvement from WMF teams in this design decision which seems a little odd to me.

@RHo @Trizek-WMF do you have an opinion on this?

Only that I agree with @Jdlrobson that the contributions links should not be a red link because these pages exist, with information that people would find useful to know about when the account was blocked. Same goes for the Talk pages (eg., https://en.m.wikipedia.org/wiki/User_talk:!_!)

Only that I agree with @Jdlrobson that the contributions links should not be a red link because these pages exist, with information that people would find useful to know about when the account was blocked. Same goes for the Talk pages (eg., https://en.m.wikipedia.org/wiki/User_talk:!_!)

+1.
And if a special page exists, it has to be accessible to the user on both mobile and desktop.

Change 806237 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Contributions link should be marked up differently from non-existent pages

https://gerrit.wikimedia.org/r/806237

Change 806237 merged by jenkins-bot:

[mediawiki/core@master] Contributions link should be marked up differently from non-existent pages

https://gerrit.wikimedia.org/r/806237

Jdlrobson claimed this task.

Change #770085 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Filter out red links which link to special pages

Reason:

Hello this is an automated message.
I am abandoning this patch as it over a year old, and is not currently in a mergeable state. This has nothing to do with the quality of the patch.

If you still care about this patch, please feel free to restore it and rebase it, and we can happily continue the conversation to help you get it merged.

https://gerrit.wikimedia.org/r/770085