| Tchanders | |
| Jan 6 2022, 5:00 PM |
| F34916139: Screen Shot 2022-01-12 at 6.37.54 PM.png | |
| Jan 12 2022, 11:39 PM |
| F34909453: Screenshot.png | |
| Jan 6 2022, 5:00 PM |
The popup widget currently has no padding:
The PopupButtonWidget is created in popup/init.js:
button = new OO.ui.PopupButtonWidget( { icon: 'info', framed: false, classes: [ 'ext-ipinfo-button' ] } );
We can add padding by adding:
button = new OO.ui.PopupButtonWidget( { ..., popup: { padded: true } } );
...as described in the PopupButtonWidget documentation.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add padding to the popup | mediawiki/extensions/IPInfo | master | +4 -1 |
Change 751969 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/extensions/IPInfo@master] Add padding to the popup
Change 751969 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Add padding to the popup
Padding now shows via testing on my local environment: See screen shot below:
I edited the skin on local box and padding was still in place. Tested on desktop Safari, Firefox, and Chrome.