"Dwelling on a valid reference link" selenium tests failing
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The last three builds from selenium-daily-beta-Popups have failed waiting for the page.ready()call to complete in the beforeEach of specs/reference_previews.js

See https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Popups/1036/console

Reference previews still appear to be working in production.

17:02:13 [Chrome 73.0.3683.75 linux #0-1] Spec: /src/tests/selenium/specs/reference_previews.js
17:02:13 [Chrome 73.0.3683.75 linux #0-1] Running: Chrome (v73.0.3683.75) on linux
17:02:13 [Chrome 73.0.3683.75 linux #0-1] Session ID: b4cf93cf-5b7e-4da0-b519-8670de6017b7
17:02:13 [Chrome 73.0.3683.75 linux #0-1]
17:02:13 [Chrome 73.0.3683.75 linux #0-1] Dwelling on a valid reference link
17:02:13 [Chrome 73.0.3683.75 linux #0-1]    ? I should see a reference preview
17:02:13 [Chrome 73.0.3683.75 linux #0-1]    ✖ "before each" hook
17:02:13 [Chrome 73.0.3683.75 linux #0-1]
17:02:13 [Chrome 73.0.3683.75 linux #0-1] 1 failing (20.8s)
17:02:13 [Chrome 73.0.3683.75 linux #0-1]
17:02:13 [Chrome 73.0.3683.75 linux #0-1] 1) Dwelling on a valid reference link "before each" hook
17:02:13 [Chrome 73.0.3683.75 linux #0-1] waitUntil condition timed out after 10000ms
17:02:13 [Chrome 73.0.3683.75 linux #0-1] Error: waitUntil condition timed out after 10000ms
17:02:13 [Chrome 73.0.3683.75 linux #0-1]     at Object.waitForModuleState (/src/node_modules/wdio-mediawiki/Util.js:13:11)
17:02:13 [Chrome 73.0.3683.75 linux #0-1]     at PopupsPage.ready (/src/tests/selenium/pageobjects/popups.page.js:44:8)
17:02:13 [Chrome 73.0.3683.75 linux #0-1]     at Context.<anonymous> (/src/tests/selenium/specs/reference_previews.js:17:8)

Acceptance Criteria

All tests in 'Dwelling on a valid reference link' test group pass

Details

	Subject	Repo	Branch	Lines +/-
	Set both Beta/non-Beta user option in Selenium tests	mediawiki/extensions/Popups	master	+5 -4

Customize query in gerrit

Related Objects

Mentioned In: T213415: Show the footnote contents when hovering over footnote indicators
Mentioned Here: T281235: Separate beta and non-beta user setting for reference previews
T213415: Show the footnote contents when hovering over footnote indicators

Event Timeline

• nray created this task.Apr 27 2021, 11:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2021, 11:32 PM

Jdlrobson assigned this task to ovasileva.Apr 28 2021, 9:35 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.May 3 2021, 12:06 PM

These were introduced in T213415

@WMDE-Fisch are your team able to take a look? If not can we disable or remove these ? They are currently spamming our mailing list.

Jdlrobson mentioned this in T213415: Show the footnote contents when hovering over footnote indicators.May 3 2021, 10:42 PM

Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

thanks for the ping @Jdlrobson we will look into this.

Note: Broken since ~26./27. of April

Change 684803 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Set both Beta/non-Beta user option in Selenium tests

https://gerrit.wikimedia.org/r/684803

gerritbot added a project: Patch-For-Review.May 4 2021, 8:46 AM

Some quick investigation results:

I'm able to run these tests locally with no problem.
When I put Reference Previews back in Beta mode, the tests are skipped. No failure.
When I enable a conflicting gadget, the tests fail, but with a very different error (element (".mwe-popups") still not existing after 10000ms).
The failure described in this ticket happens because the ResourceLoader module ext.popups.main never loads.
This can actually happen when a registered user disabled both Page Previews as well as Reference Previews. However, the test forces the popupsreferencepreviews option to be enabled.
… since T281235 there are 2 options. popupsreferencepreviews while in Beta, and popups-reference-previews after Beta. That might be it.

Change 684803 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Set both Beta/non-Beta user option in Selenium tests

https://gerrit.wikimedia.org/r/684803

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 4 2021, 9:00 AM

Seems to be fixed with the patch above, although I don't completely understand why.

https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Popups/1046/

Let's wait for the next regular run of the job before closing the ticket.

Maintenance_bot removed a project: Patch-For-Review.May 4 2021, 9:11 AM

Lena_WMDE moved this task from Backlog to Doing on the Reference Previews board.May 4 2021, 1:57 PM

ovasileva removed ovasileva as the assignee of this task.May 4 2021, 5:14 PM

ovasileva subscribed.

Thank you!

You're welcome. :-)

Regular job run also passing. Done.

https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Popups/1047/

thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-28 board.May 11 2021, 12:36 PM

Lena_WMDE closed this task as Resolved.May 17 2021, 9:13 AM

Lena_WMDE claimed this task.