Maniphest T281924

Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tgr
	May 4 2021, 9:13 PM

Description

I get this error when trying to open the diff ("review changes") panel in the save dialog:

Uncaught TypeError: Cannot read property 'getData' of null
    at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode

The references line is

diffMode = this.reviewModeButtonSelect.findSelectedItem().getData(),

so this caused by neither the visual diff mode nor the source diff mode button being selected. Probably some side effect of AddLinkSaveDialog, even though we don't intentionally affect the diff buttons there.

Details

	Subject	Repo	Branch	Lines +/-
	Fix diff mode override	mediawiki/extensions/GrowthExperiments	master	+5 -4
	Add Link: Select visual diff mode on save dialog setup	mediawiki/extensions/GrowthExperiments	master	+3 -0

Customize query in gerrit

Event Timeline

Tgr created this task.May 4 2021, 9:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2021, 9:13 PM

It's probably caused by this part of ve.ui.MWSaveDialog.getSetupProcess:

this.reviewModeButtonSelect.selectItemByData(
    ve.userConfig( 'visualeditor-diffmode-' + surfaceMode ) || surfaceMode
);

getting confused by our custom surface mode.

Change 685107 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: Select visual diff mode on save dialog setup

https://gerrit.wikimedia.org/r/685107

gerritbot added a project: Patch-For-Review.May 4 2021, 9:27 PM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 4 2021, 9:27 PM

kostajh triaged this task as Medium priority.May 5 2021, 10:35 AM

kostajh moved this task from Backlog to May 3 - May 7 on the Add-Link board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 5 2021, 10:38 AM

kostajh changed the subtype of this task from "Task" to "Bug Report".

kostajh moved this task from May 3 - May 7 to Done / QA on the Add-Link board.

Change 685107 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: Select visual diff mode on save dialog setup

https://gerrit.wikimedia.org/r/685107

Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 11:10 AM

Not fully fixed. It doesn't happen anymore when switching to the diff dialog, but it happens when opening -> closing -> reopening the save dialog.

Change 687661 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix diff mode override

https://gerrit.wikimedia.org/r/687661

gerritbot added a project: Patch-For-Review.May 9 2021, 2:45 PM

I don't get why this is happening, updateReviewMode should only be called when displaying the diff panel but apparently that is not the case. Anyway, the new way of overriding the diff preference works around it.

Tgr moved this task from Done / QA to May 3 - May 7 on the Add-Link board.May 9 2021, 2:46 PM

kostajh moved this task from May 3 - May 7 to May 10 - May 14 on the Add-Link board.May 10 2021, 3:45 PM

Change 687661 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix diff mode override

https://gerrit.wikimedia.org/r/687661

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 10 2021, 6:05 PM

Tgr moved this task from May 10 - May 14 to Done / QA on the Add-Link board.

Maintenance_bot removed a project: Patch-For-Review.May 10 2021, 6:11 PM

Etonkovidova closed this task as Resolved.Jun 15 2021, 12:24 AM

Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewModeClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode
Closed, ResolvedPublicBUG REPORT
Actions