[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T274695

Drop wgAjaxEditStash configuration option
Closed, ResolvedPublic
Actions

Description

Shipped in 1.25; use case for disabling this is very marginal.

Details

SubjectRepoBranchLines +/-
Drop wgAjaxEditStash, deprecated in 1.36mediawiki/coremaster+4 -37
Deprecate wgAjaxEditStashmediawiki/coremaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Feb 13 2021, 2:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2021, 2:42 AM
Krinkle added projects: Technical-Debt (Deprecation process), Performance-Team (Radar).Feb 13 2021, 2:45 AM
Krinkle moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
Krinkle subscribed.

Sounds good to me. Maybe even backport deprecation to 1.35 as heads up and remove sooner. Or deprecate now for removal in 1.37.

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Feb 13 2021, 2:46 AM
Jdforrester-WMF added a comment.Feb 13 2021, 2:48 AM
In T274695#6827860, @Krinkle wrote:

Sounds good to me. Maybe even backport deprecation to 1.35 as heads up and remove sooner. Or deprecate now for removal in 1.37.

Ack.

gerritbot added a comment.Feb 13 2021, 2:57 AM

Change 663920 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Deprecate wgAjaxEditStash

https://gerrit.wikimedia.org/r/663920

gerritbot added a project: Patch-For-Review.Feb 13 2021, 2:57 AM
gerritbot added a comment.Feb 13 2021, 3:35 AM

Change 663920 merged by jenkins-bot:
[mediawiki/core@master] Deprecate wgAjaxEditStash

https://gerrit.wikimedia.org/r/663920

gerritbot added a comment.Feb 13 2021, 3:43 AM

Change 663928 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Drop wgAjaxEditStash, deprecated in 1.36

https://gerrit.wikimedia.org/r/663928

Jdforrester-WMF moved this task from Backlog to Stash on the MediaWiki-Page-editing board.Feb 13 2021, 3:56 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 13 2021, 4:00 AM
gerritbot added a comment.Sep 7 2021, 4:45 PM

Change 663928 merged by jenkins-bot:

[mediawiki/core@master] Drop wgAjaxEditStash, deprecated in 1.36

https://gerrit.wikimedia.org/r/663928

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 5:11 PM
Krinkle closed this task as Resolved.Sep 7 2021, 5:43 PM
Krinkle assigned this task to Jdforrester-WMF.
• Naleksuh subscribed.Feb 7 2022, 8:45 PM

https://phabricator.wikimedia.org/T301178

Aklapper mentioned this in T301178: Readd edit stash config variable.Feb 7 2022, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits