[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T269403

ParameterTypeException when `diff`ing invalid MassMessageListContent
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to reproduce:
Visit https://en.wikipedia.org/wiki/Wikipedia:Scripts%2B%2B/Subscribe?action=edit (or probably any other mass message list)
Make the json invalid (eg remove the first {)
Click "Show changes"

Actual result:

[8b788f40-eff9-4c15-a1f1-9d7ab39070fd] 2020-12-03 23:47:58: Fatal exception of type "Wikimedia\Assert\ParameterTypeException"
trace
#0 /srv/mediawiki/php-1.36.0-wmf.18/includes/diff/TextSlotDiffRenderer.php(138): Wikimedia\Assert\Assert::parameterType(array, NULL, string)
#1 /srv/mediawiki/php-1.36.0-wmf.18/includes/diff/DifferenceEngine.php(1466): TextSlotDiffRenderer->getTextDiff(string, NULL)
#2 /srv/mediawiki/php-1.36.0-wmf.18/extensions/MassMessage/includes/Content/MassMessageListDiffEngine.php(36): DifferenceEngine->generateTextDiffBody(string, NULL)
#3 /srv/mediawiki/php-1.36.0-wmf.18/includes/diff/DifferenceEngineSlotDiffRenderer.php(54): MediaWiki\MassMessage\Content\MassMessageListDiffEngine->generateContentDiffBody(MediaWiki\MassMessage\Content\MassMessageListContent, MediaWiki\MassMessage\Content\MassMessageListContent)
#4 /srv/mediawiki/php-1.36.0-wmf.18/includes/diff/DifferenceEngine.php(1251): DifferenceEngineSlotDiffRenderer->getDiff(MediaWiki\MassMessage\Content\MassMessageListContent, MediaWiki\MassMessage\Content\MassMessageListContent)
#5 /srv/mediawiki/php-1.36.0-wmf.18/includes/diff/DifferenceEngine.php(1156): DifferenceEngine->getDiffBody()
#6 /srv/mediawiki/php-1.36.0-wmf.18/includes/EditPage.php(3765): DifferenceEngine->getDiff(string, string)
#7 /srv/mediawiki/php-1.36.0-wmf.18/includes/EditPage.php(3675): EditPage->showDiff()
#8 /srv/mediawiki/php-1.36.0-wmf.18/includes/EditPage.php(3219): EditPage->displayPreviewArea(string, boolean)
#9 /srv/mediawiki/php-1.36.0-wmf.18/includes/EditPage.php(717): EditPage->showEditForm()
#10 /srv/mediawiki/php-1.36.0-wmf.18/includes/actions/EditAction.php(71): EditPage->edit()
#11 /srv/mediawiki/php-1.36.0-wmf.18/includes/actions/SubmitAction.php(38): EditAction->show()
#12 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(532): SubmitAction->show()
#13 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(316): MediaWiki->performAction(Article, Title)
#14 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(945): MediaWiki->performRequest()
#15 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(548): MediaWiki->main()
#16 /srv/mediawiki/php-1.36.0-wmf.18/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/php-1.36.0-wmf.18/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Details

Request ID
8b788f40-eff9-4c15-a1f1-9d7ab39070fd
Request URL
https://en.wikipedia.org/w/index.php?title=Wikipedia:Scripts%2B%2B/Subscribe&action=submit
SubjectRepoBranchLines +/-
Handle invalid MassMessageListContent on "show changes"mediawiki/extensions/MassMessagemaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 3 2020, 11:50 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 3 2020, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Dec 3 2020, 11:54 PM
Krinkle added a project: Release-Engineering-Team (Logspam).Dec 9 2020, 7:51 PM
Krinkle updated the task description. (Show Details)
Krinkle edited Stack Trace. (Show Details)
Krinkle moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.
Legoktm subscribed.Dec 10 2020, 11:00 AM
15:52:35 <legoktm> that bug looks like EditPage is not checking whether the content is valid before trying to diff it
Legoktm unsubscribed.Dec 10 2020, 11:00 AM
Umherirrender subscribed.Feb 4 2021, 10:09 PM

Maybe fixing it more general with T231084 because DiffEngine is also in the stacktrace

Umherirrender unsubscribed.Feb 27 2021, 9:39 PM
gerritbot added a comment.Apr 27 2021, 9:51 PM

Change 683093 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] Handle invalid MassMessageListContent on "show changes"

https://gerrit.wikimedia.org/r/683093

gerritbot added a project: Patch-For-Review.Apr 27 2021, 9:51 PM
gerritbot added a comment.May 4 2021, 8:34 PM

Change 683093 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Handle invalid MassMessageListContent on "show changes"

https://gerrit.wikimedia.org/r/683093

Umherirrender closed this task as Resolved.May 4 2021, 8:48 PM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 4 2021, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits