[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T264133

[Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open VE
  2. Insert a table
  3. Go to Table>Properties

Observed Result:
A button "Change Reference Type" is showing up, which doesn't do anything if you click on it.

Screenshot/Screen capture:

Screen Shot 2020-09-29 at 2.12.37 PM.png (622×1 px, 69 KB)

Browser: Chrome

Wiki: English

Editor: VE

Page: https://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)/sandbox
Environment: Beta cluster

Details

SubjectRepoBranchLines +/-
Fix "Change reference type" button appearing in unrelated dialogsmediawiki/extensions/Citoidmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Sep 29 2020, 9:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2020, 9:22 PM
Ryasmeen renamed this task from [Regression pre-1.36wmf.12] "Change Reference Type" button showing up on Table Properties dialog to [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog.Sep 29 2020, 9:22 PM
Ryasmeen triaged this task as Unbreak Now! priority.
matmarex claimed this task.Sep 29 2020, 9:27 PM
matmarex subscribed.

That button was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/483337, but it shouldn't appear in this dialog, obviously.

matmarex added a comment.Sep 29 2020, 9:35 PM

The wmf.11 branch was already cut without the faulty patch, so we don't need to backport the fix, just merge it before next week's branch cut.

gerritbot added a comment.Sep 29 2020, 9:35 PM

Change 630952 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Citoid@master] Fix "Change reference type" button appearing in unrelated dialogs

https://gerrit.wikimedia.org/r/630952

gerritbot added a project: Patch-For-Review.Sep 29 2020, 9:35 PM
matmarex added a project: Editing-team (Kanban Board).Sep 29 2020, 9:35 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
barakat1 renamed this task from [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog to [الانحدار قبل 1.36wmf.12] يظهر الزر "تغيير نوع المرجع" في مربع الحوار خصائص الجدول.Sep 29 2020, 9:35 PM
matmarex renamed this task from [الانحدار قبل 1.36wmf.12] يظهر الزر "تغيير نوع المرجع" في مربع الحوار خصائص الجدول to [Regression pre-1.36wmf.12] "Change Reference Type" button is showing up on Table Properties dialog.Sep 29 2020, 9:48 PM
matmarex mentioned this in T208981: Reference context doesn't show that the reference is reused, which is confusing if you try to delete and recreate it (converting a re-used basic reference to template citation).Sep 30 2020, 1:10 AM
Esanders subscribed.Sep 30 2020, 1:52 PM
In T264133#6503329, @matmarex wrote:

That button was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/483337, but it shouldn't appear in this dialog, obviously.

That's why I waited until Tuesday :)

Esanders moved this task from To Triage to Triaged on the VisualEditor board.Sep 30 2020, 5:53 PM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
Esanders added a project: Editing QA.
Esanders moved this task from Inbox to High Priority on the Editing QA board.

Should be easy to test :)

gerritbot added a comment.Sep 30 2020, 5:57 PM

Change 630952 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Fix "Change reference type" button appearing in unrelated dialogs

https://gerrit.wikimedia.org/r/630952

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Sep 30 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 30 2020, 6:10 PM
Ryasmeen added a comment.Sep 30 2020, 7:11 PM
In T264133#6506199, @Esanders wrote:

Should be easy to test :)

yes, fixed now :)

Ryasmeen edited projects, added Verified; removed Editing QA.Sep 30 2020, 7:12 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Oct 1 2020, 12:55 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 1 2020, 12:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits