[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T264979

Remove wfConfiguredReadOnlyReason
Closed, ResolvedPublic
Actions

Description

The global function wfConfiguredReadOnlyReason is only used in JobQueueGroup::singleton. I suggest moving the one line of code to where it is needed and deprecating and removing the global function

Codesearch: https://codesearch.wmcloud.org/search/?q=wfConfiguredReadOnlyReason&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Drop global function wfConfiguredReadOnlyReason, deprecated in 1.36mediawiki/coremaster+1 -13
Deprecate a bunch of global functionsmediawiki/coremaster+54 -8
Customize query in gerrit

Event Timeline

DannyS712 created this task.Oct 8 2020, 5:14 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptOct 8 2020, 5:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Others on the User-DannyS712 board.Oct 8 2020, 5:15 AM
gerritbot added a comment.Dec 18 2020, 7:57 PM

Change 650569 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate a bunch of global functions

https://gerrit.wikimedia.org/r/650569

gerritbot added a project: Patch-For-Review.Dec 18 2020, 7:57 PM
gerritbot added a comment.Dec 18 2020, 11:36 PM

Change 650569 merged by jenkins-bot:
[mediawiki/core@master] Deprecate a bunch of global functions

https://gerrit.wikimedia.org/r/650569

Maintenance_bot removed a project: Patch-For-Review.Dec 19 2020, 12:12 AM
gerritbot added a comment.May 5 2021, 12:17 PM

Change 685426 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop a bunch of global functions

https://gerrit.wikimedia.org/r/685426

gerritbot added a project: Patch-For-Review.May 5 2021, 12:17 PM
Zabe claimed this task.May 5 2021, 12:33 PM
Zabe added a project: User-Zabe.
Zabe moved this task from Backlog to Deprecation on the User-Zabe board.May 6 2021, 10:52 AM
gerritbot added a comment.May 10 2021, 10:10 PM

Change 688458 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Drop global function wfConfiguredReadOnlyReason, deprecated in 1.36

https://gerrit.wikimedia.org/r/688458

gerritbot added a comment.May 11 2021, 12:22 AM

Change 688458 merged by jenkins-bot:

[mediawiki/core@master] Drop global function wfConfiguredReadOnlyReason, deprecated in 1.36

https://gerrit.wikimedia.org/r/688458

Zabe closed this task as Resolved.May 11 2021, 4:39 AM
Zabe removed a project: Patch-For-Review.Jul 15 2021, 3:43 PM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits