Description

Expected:

screenshot from Apr 27th CS Betalabs
Header text is vertically centered in the help panel headers across all help and guidance screens (root screen, guidance, ask a question, general help)

Actual:

// screenshot from Thu Jun 18th CS Betalabs
Header text is no longer vertically centered on any help panel screens

Details

	Subject	Repo	Branch	Lines +/-
	Help Panel: Vertically center header contents for mobile	mediawiki/extensions/GrowthExperiments	master	+7 -0

Customize query in gerrit

Related Objects

Mentioned In: T244541: Newcomer tasks: suggested edit screen in guidance

Event Timeline

RHo created this task.Jun 18 2020, 1:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2020, 1:21 PM

RHo mentioned this in T244541: Newcomer tasks: suggested edit screen in guidance.Jun 18 2020, 1:41 PM

Aklapper removed a subscriber: Growth-Team.Jun 19 2020, 12:54 PM

MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 25 2020, 12:54 AM

MMiller_WMF moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 29 2020, 5:08 AM

MMiller_WMF added a project: Growth-Team-Leftovers.Sep 2 2020, 11:57 PM

kostajh triaged this task as Medium priority.Apr 15 2021, 8:04 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM

@Etonkovidova could you please check if this is still an issue?

• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:44 PM

In T255770#7019087, @kostajh wrote:

@Etonkovidova could you please check if this is still an issue?

Here are the latest screenshots and I'm moving the task to @RHo for evaluation whether there are still some issues with alignment (btw, the header "Get help with editing" is horizontally centered on Desktop):

Screen Shot 2021-04-20 at 4.10.57 PM.png (263×507 px, 32 KB)

Screen Shot 2021-04-20 at 4.11.47 PM.png (142×512 px, 18 KB)

Screen Shot 2021-04-20 at 4.01.22 PM.png (396×407 px, 52 KB)

Moving back as this is confirmed as still an issue, thanks!

• mewoph claimed this task.Jun 11 2021, 9:17 PM

• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 699469 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Help Panel: Vertically center header contents

https://gerrit.wikimedia.org/r/699469

gerritbot added a project: Patch-For-Review.Jun 11 2021, 9:19 PM

With latest changes:

helppanel_tips_after.png (428×1 px, 50 KB)

helppanel_home_after.png (358×1 px, 43 KB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 11 2021, 9:20 PM

In T255770#7152609, @mewoph wrote:

With latest changes:

@RHo looks OK to you?

LGTM!

In T255770#7154404, @kostajh wrote:

In T255770#7152609, @mewoph wrote:

With latest changes:

@RHo looks OK to you?

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 21 2021, 10:51 AM

Change 699469 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help Panel: Vertically center header contents for mobile

https://gerrit.wikimedia.org/r/699469

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2021, 12:11 PM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 22 2021, 10:49 PM

Etonkovidova closed this task as Resolved.Jun 22 2021, 11:08 PM

	F34409029: Screen Shot 2021-04-20 at 4.11.47 PM.png
	Apr 21 2021, 12:27 AM

	F34409027: Screen Shot 2021-04-20 at 4.10.57 PM.png
	Apr 21 2021, 12:27 AM

	F34409034: Screen Shot 2021-04-20 at 4.01.22 PM.png
	Apr 21 2021, 12:27 AM

	F34499491: image.png
	Jun 14 2021, 11:37 AM