GlobalBlock API can block with past expiration date
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tks4Fish
	Mar 31 2020, 3:00 PM

Description

GlobalBlock API is able to block with expiration dates which are in the past, see this and this block. This was achieved via Python (P10835), running the command .\proxy.py -"3 years"

Details

	Subject	Repo	Branch	Lines +/-
	API: set 'expiry' PARAM_TYPE to 'expiry' instead of 'string'	mediawiki/extensions/GlobalBlocking	master	+3 -8

Customize query in gerrit

Related Objects

Mentioned Here: T248508: Watchlist Expiry: Add expiry type to ParamValidator [medium]
P10835 (An Untitled Masterwork)

Event Timeline

Tks4Fish created this task.Mar 31 2020, 3:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 3:00 PM

kolbert subscribed.Mar 31 2020, 3:16 PM

Once T248508 is complete, we can make use of the new param type in the Global Block API and that will make it impossible to use expiries in the past.

Tks4Fish claimed this task.Dec 1 2021, 9:58 PM

Change 743211 had a related patch set uploaded (by Tks4Fish; author: Tks4Fish):

[mediawiki/extensions/GlobalBlocking@master] API: set 'expiry' PARAM_TYPE to 'expiry' instead of 'string'

https://gerrit.wikimedia.org/r/743211

gerritbot added a project: Patch-For-Review.Dec 2 2021, 4:24 PM

Change 743211 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] API: set 'expiry' PARAM_TYPE to 'expiry' instead of 'string'

https://gerrit.wikimedia.org/r/743211

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 3 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2021, 12:10 AM

I've tested this in production and the API no longer accepts expiries in the past.

GlobalBlock API can block with past expiration dateClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

GlobalBlock API can block with past expiration date
Closed, ResolvedPublic
Actions