[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T228992

Ask users to add a (non hidden) category, if there are only hidden ones
Open, Needs TriagePublic
Actions

Description

Motivation
The FileImporter asks users to add a category to a file, if there is none yet (implemented via T189573). However, often times files have hidden categories (e.g. due to their licence template), so the warning is not triggered.

Acceptance Criteria

  • Show the advice to add at least one category to the file, if there is no visible one yet. Hidden categories have no effect on the "category count".

Related Objects

Event Timeline

• Lea_WMDE created this task.Jul 25 2019, 12:26 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJul 25 2019, 12:26 PM
• Lea_WMDE mentioned this in T225693: After adding categories manually the warning to add categories is still shown.Jul 25 2019, 12:27 PM
• Lea_WMDE moved this task from Backlog to prio 2 tickets on the Move-Files-To-Commons board.Jul 29 2019, 1:25 PM
• Tonina_Zhelyazkova_WMDE added a project: Wikimania-Hackathon-2019.Aug 9 2019, 9:44 AM
• Tonina_Zhelyazkova_WMDE moved this task from Backlog to Orphaned tasks that need help! on the Wikimania-Hackathon-2019 board.
awight subscribed.Sep 9 2019, 9:34 AM

May be a duplicate and already fixed. Needs verification.

thiemowmde renamed this task from Ask users to add a category, if there are no visible ones yet to Ask users to add a (non hidden) category, if there are only hidden ones.Sep 9 2019, 10:05 AM
thiemowmde added a project: WMDE-TechWish.
thiemowmde subscribed.
awight added a comment.Sep 9 2019, 10:50 AM

The logic in FileImporter\Html\CategorySnippet almost does what we want, but it only fires when both the visible categories and hidden categories are both empty. When we change this to only test the visible categories, we'll also need to change the way the output is concatenated, and the message body itself, since there are cases when we want to show hidden categories and also this warning.

thiemowmde updated the task description. (Show Details)Sep 10 2019, 9:41 AM
awight mentioned this in T222873: Design behavior when importing an uncategorized file.Sep 10 2019, 10:18 PM
awight added a comment.Sep 24 2019, 8:52 AM

I was surprised to not find any metrics for this under "recoverable errors". Maybe tracking is the next step?

WMDE-Fisch moved this task from prio 2 tickets to Product backlog on the Move-Files-To-Commons board.Feb 12 2020, 1:15 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Nov 2 2020, 7:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits