As a modest contribution to T225730, let's only run maintenance/deduplicateArchiveRevId.php if there is data to deduplicate. On my machine, that script calls checkMysqlAutoIncrementBug which calls populateArchiveRevId::makeDummyRevisionRow, which takes ~16 seconds when installing MediaWiki.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 517349 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Only attempt to deduplicate if there is data in archive and revision
Comment Actions
From a random other commit:
mw-install
… 00:00:58.177 Modifying el_index_60 field of table externallinks ...done. 00:00:58.178 Running maintenance/deduplicateArchiveRevId.php... 00:00:58.178 Deduplicating ar_rev_id... 00:01:13.614 ... - 00:01:13.614 Finished deduplicating ar_rev_id. 0 rows deleted, 0 assigned new IDs. 00:01:13.615 done. …
From this commit:
mw-install
… 00:01:06.384 Modifying el_index_60 field of table externallinks ...done. 00:01:06.385 Running maintenance/deduplicateArchiveRevId.php... 00:01:06.385 Deduplicating ar_rev_id... 00:01:06.386 New install, nothing to do here. 00:01:06.386 done. …
Comment Actions
Change 517351 had a related patch set uploaded (by Krinkle; owner: Kosta Harlan):
[mediawiki/core@REL1_33] Only attempt to deduplicate if there is data in archive and revision
Comment Actions
Change 517349 merged by jenkins-bot:
[mediawiki/core@master] Only attempt to deduplicate if there is data in archive and revision
Comment Actions
Change 517351 merged by jenkins-bot:
[mediawiki/core@REL1_33] Only attempt to deduplicate if there is data in archive and revision
Comment Actions
Very nice catch to speed up update.php. Not sure why that script takes so long even when the archive table is empty, but that is a side concern.
Thank you!