[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T210811

OOUI being loaded unconditionally on mobile site resulting in 50kb more bytes shipped
Closed, DuplicatePublic
Actions

Description

I'm seeing a 50kb spike in JavaScript loaded on the mobile site on the beta cluster since 28th November:
https://grafana.wikimedia.org/dashboard/db/mobile-2g?orgId=1&panelId=69&fullscreen

Screen Shot 2018-11-29 at 4.09.07 PM.png (281×707 px, 43 KB)

This is HUGE (190kb to 260kb) and seems to be due to this new JS being loaded:
https://en.m.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=oojs-ui-core%2Coojs-ui-widgets%7Coojs-ui.styles.icons-editing-advanced&skin=minerva&version=1c9erng

This does not appear to be the case in production.
What changes recently might have caused this?

Related Objects

Event Timeline

Jdlrobson created this task.Nov 30 2018, 12:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2018, 12:07 AM
Jdlrobson added a project: OOUI.Nov 30 2018, 12:10 AM
Jdlrobson updated the task description. (Show Details)
matmarex edited projects, added QuickSurveys; removed OOUI.Nov 30 2018, 12:19 AM
matmarex subscribed.

The module is not loaded on all pages – it is not loaded on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page, for example. (Check in browser console with mw.loader.getState('oojs-ui-core'), it return "registered" rather than "ready".)

I guessed from your screenshot that this is testing https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama, and it is indeed loaded on that page. You can find out what loads it with mw.inspect.getDependencyGraph() (after loading it with mw.loader.load('mediawiki.inspect')): the module oojs-ui-widgets is loaded by being a dependency of ext.quicksurveys.views.

matmarex closed this task as Invalid.Nov 30 2018, 12:20 AM

And this issue is already known: T159738.

Jdlrobson triaged this task as Unbreak Now! priority.Nov 30 2018, 12:21 AM
Jdlrobson edited projects, added Performance-Team; removed QuickSurveys.

Yep looks like this was due to https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/476027/ (The Trust QuickSurvey in T209882)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 30 2018, 12:21 AM
Jdlrobson closed this task as a duplicate of T159738: Limit default styles loaded by OOUI (65kb after gzipping penalty to run a QuickSurveys) by droping use of oojs-ui-widgets .Nov 30 2018, 12:22 AM
Jdlrobson added a comment.Nov 30 2018, 12:33 AM

You can find out what loads it with mw.inspect.getDependencyGraph() (after loading it with mw.loader.load('mediawiki.inspect')): the module oojs-ui-widgets is loaded by being a dependency of ext.quicksurveys.views.

Neato! I didn't know we could do that. That's awesome.

Volker_E added a comment.Nov 30 2018, 2:16 AM

@Jdlrobson In a slightly positive note, it's down to 50kb now to run a QuickSurvey with OOUI?

Volker_E renamed this task from OOjs UI being loaded unconditionally on mobile site resulting in 50kb more bytes shipped to OOUI being loaded unconditionally on mobile site resulting in 50kb more bytes shipped.Nov 30 2018, 2:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits