Maniphest T202991

Auto-correct first word in heading breaks view-model sync on iOS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Aug 28 2018, 1:57 PM

Description

Select heading	Use the keyboard toolbar to change the word	Press undo

Observe that the model and view are now out of sync (the view should have reverted to the original state)

Details

	Subject	Repo	Branch	Lines +/-
	Fix width of headings in mobile editor	mediawiki/skins/MinervaNeue	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T305971: Change styling for Minerva/MobileFrontend section headings to use flexbox instead of table-cells
T218167: The page jitters slightly when opening a section with section editing enabled on mobile VE
T218437: Differences between read mode and edit mode on mobile: some headings shifted by 1px up or down

Event Timeline

Esanders created this task.Aug 28 2018, 1:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2018, 1:57 PM

Change 454934 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Fix width of headings in mobile editor

https://gerrit.wikimedia.org/r/454934

gerritbot added a project: Patch-For-Review.Aug 28 2018, 2:05 PM

It appears that getting rid of display:table fixes this, which we needed to do anyway to fix heading widths.

• Deskana assigned this task to Esanders.Aug 28 2018, 4:03 PM

• Deskana triaged this task as Medium priority.

• Deskana added a project: Editing Q1 2018-19 mobile improvements.

Change 454934 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix width of headings in mobile editor

https://gerrit.wikimedia.org/r/454934

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 29 2018, 1:01 AM

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 29 2018, 1:28 PM

Ryasmeen added a project: Verified.Aug 29 2018, 9:13 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Sep 2 2018, 1:41 PM

matmarex mentioned this in T218437: Differences between read mode and edit mode on mobile: some headings shifted by 1px up or down.Mar 15 2019, 8:42 PM

matmarex mentioned this in T218167: The page jitters slightly when opening a section with section editing enabled on mobile VE.Mar 15 2019, 8:44 PM

matmarex mentioned this in T305971: Change styling for Minerva/MobileFrontend section headings to use flexbox instead of table-cells.Apr 12 2022, 5:51 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2022, 6:30 PM

Auto-correct first word in heading breaks view-model sync on iOSClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Auto-correct first word in heading breaks view-model sync on iOS
Closed, ResolvedPublic
Actions