[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T197833

Results "jump" after load in RCFilters in Watchlist
Closed, ResolvedPublic
Actions

Description

The watchlist area "jumps" after load. This happens because the welcome string doesn't take into account that there will be a button there, and when the button appears it squishes the text and make it jump to more lines than before, hence moving the results down and causing a "jump".

The commit fixes that by constraining the width of the text to accommodate the button in most languages. The button translations should at least attempt to now make the button text too long.

Details

SubjectRepoBranchLines +/-
RCFilters: Readjust welcome text so results don't jump after loadmediawiki/coremaster+11 -2
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Jun 20 2018, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2018, 9:45 PM
gerritbot subscribed.Jun 20 2018, 9:46 PM

Change 441310 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Readjust welcome text so results don't jump after load

https://gerrit.wikimedia.org/r/441310

gerritbot added a project: Patch-For-Review.Jun 20 2018, 9:46 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 20 2018, 9:46 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 21 2018, 4:41 PM
gerritbot added a comment.Jun 21 2018, 4:54 PM

Change 441310 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Readjust welcome text so results don't jump after load

https://gerrit.wikimedia.org/r/441310

Etonkovidova subscribed.Jun 21 2018, 7:40 PM

Checked in betalabs - the "jumpiness" is gone.

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 21 2018, 7:40 PM
• jmatazzoni closed this task as Resolved.Jun 25 2018, 5:24 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 3:01 PM
• Vvjjkkii renamed this task from Results "jump" after load in RCFilters in Watchlist to yjaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Mooeypoo as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from yjaaaaaaaa to Results "jump" after load in RCFilters in Watchlist.Jul 2 2018, 8:29 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Mooeypoo.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Etonkovidova mentioned this in T177117: Page elements still jumping around and blinking on RC page and Watchlist.Jul 4 2018, 12:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits