[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T190408

Update patrolled RCFilter to distinguish between unpatrolled, autopatrolled, manually patrolled
Closed, ResolvedPublic
Actions

Assigned To
• Catrope
Authored By
SBisson
Mar 22 2018, 2:09 PM
Tags
Referenced Files
F17354564: Screen Shot 2018-04-27 at 5.41.14 PM.png
Apr 28 2018, 12:45 AM
F16941372: Screen Shot 2018-04-12 at 3.37.46 PM.png
Apr 12 2018, 10:41 PM
F16683564: Screenshot from 2018-04-04 16-57-50.png
Apr 5 2018, 12:01 AM
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot
• jmatazzoni
Ladsgroup
Pginer-WMF
View All 9 Subscribers
Tokens
"Piece of Eight" token, awarded by Liuxinyu970226."Piece of Eight" token, awarded by RandomDSdevel.

Description

Patrol field in recent changes will go from 2 states to 3 states in T184791: Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits

We should update RCFilters to allow reviewers to filter by any of the 3 states

Language and layout for updated Review status filters section

Please a) change order of filters, to lead with Unpatrolled, b) insert the new filter option, and c) update language for ALL filters as shown (numerous small changes have been made)

Unpatrolled

Edits not manually or automatically marked as patrolled.

Manually patrolled

Edits manually marked as patrolled.

Autopatrolled

Edits by advanced users whose work is automatically marked as patrolled.

Details

SubjectRepoBranchLines +/-
Use PRC_AUTOPATROLLED for rollbacks and revdelmediawiki/coremaster+3 -3
Use PRC_AUTOPATROLLED for log entries and category entriesmediawiki/coremaster+2 -2
RCFilters: Convert patrolled filter to three statesmediawiki/coremaster+137 -33
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.Mar 22 2018, 2:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2018, 2:09 PM
Trizek-WMF added projects: User-notice, User-notice-collaboration.Mar 22 2018, 2:11 PM
Trizek-WMF moved this task from To Triage to Not ready to announce on the User-notice-collaboration board.
Trizek-WMF moved this task from To Triage to Not ready to announce on the User-notice board.
Trizek-WMF subscribed.
• jmatazzoni claimed this task.Mar 28 2018, 3:33 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
• jmatazzoni moved this task from Untriaged to Product/Design Work on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
• jmatazzoni added a subscriber: Pginer-WMF.Mar 28 2018, 10:25 PM
• jmatazzoni added a comment.Mar 28 2018, 10:44 PM

Language for this new filter

I took a stab at proposing language for this new feature, as well as showing how these should be arranged within the Review Status filters. Regarding the latter, James suggests leading with Unpatrolled because it will be the most commonly used. If it's not possible to put it first for some reason, then put it last after manual and then auto.

It's rather hard to write a description of this slightly arcane function. I've provided four options. #s 1 and 2 probably won't wrap, but IMHO they are not very clear. E.g., saying something "doesn't need patrolling" leaves slightly ambiguous the question of whether, from the POV of the Unpatrolled filter, it is or is not patrolled. I don't recommend either of these and really only put them here to show how tricky this is.

#s 3 and 4 will probably wrap in English. #3 might fit and is reasonably clear. #4 is more clear, so if we're going to two lines anyway, why not be more clear? Opinions? Alternate ideas?

Review status

Unpatrolled

Edits not manually or automatically marked as patrolled

Manually patrolled

Edits manually marked as patrolled.

Autopatrolled
  1. Edits by advanced users who have the "autopatrol" right.
  2. Edits by advanced users whose edits don't need patrolling.
  3. Edits by advanced users and so automatically marked as patrolled.
  4. Edits by advanced users whose work is automatically marked as patrolled.
Trizek-WMF added a comment.Mar 29 2018, 1:18 PM

I'll go the #4.

• jmatazzoni updated the task description. (Show Details)Apr 3 2018, 12:40 AM
• jmatazzoni moved this task from Product/Design Work to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

In T190408#4091184, @Trizek-WMF wrote:

I'll go the #4.

yes, I think that's right. I'll put that into the product description and move this out of the Product/Design column to RFP.

gerritbot subscribed.Apr 4 2018, 1:46 AM

Change 423824 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Convert patrolled filter to three states

https://gerrit.wikimedia.org/r/423824

gerritbot added a project: Patch-For-Review.Apr 4 2018, 1:46 AM
• Catrope subscribed.Apr 4 2018, 1:46 AM
In T190408#4102972, @gerritbot wrote:

Change 423824 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Convert patrolled filter to three states

https://gerrit.wikimedia.org/r/423824

I wrote this on the plane without having seen the discussion about language here, so I made up my own. I'll amend to put in the right language tomorrow.

Trizek-WMF added a comment.Apr 4 2018, 9:08 AM

@Catrope, please say when it will be deployed, so we can announce it in Tech News before it happens. As a reminder, publication limit os on Thursday (or early PDT Friday) for a distribution on Monday/Tuesday (depending on timezones).

SBisson reassigned this task from • jmatazzoni to • Catrope.Apr 4 2018, 12:57 PM
SBisson moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
• Catrope added a comment.Apr 4 2018, 11:51 PM
In T190408#4103543, @Trizek-WMF wrote:

@Catrope, please say when it will be deployed, so we can announce it in Tech News before it happens. As a reminder, publication limit os on Thursday (or early PDT Friday) for a distribution on Monday/Tuesday (depending on timezones).

Most likely it'll be on next week's train (April 10-12).

• Catrope added a comment.Apr 5 2018, 12:01 AM

I've amended my change to add the right language. It now looks like this:

Screenshot from 2018-04-04 16-57-50.png (240×656 px, 20 KB)

For the record, the language that I wrote (without access to your language) was:

  • Unpatrolled: Edits not marked as patrolled
  • Manually patrolled: Edits marked as patrolled by a patroller
  • Automatically patrolled: Edits marked as patrolled automatically
• jmatazzoni added a comment.Apr 5 2018, 2:06 AM

Thanks for making the change. I'm sad though not surprised that the Autopatrolled line wraps, but I think clarity trumps brevity in such a circumstance.

Trizek-WMF moved this task from Not ready to announce to Announce in next Tech/News on the User-notice board.EditedApr 5 2018, 8:50 AM
In T190408#4107361, @jmatazzoni wrote:

Thanks for making the change. I'm sad though not surprised that the Autopatrolled line wraps, but I think clarity trumps brevity in such a circumstance.

It may wrap in other languages. That's not overall a big deal.

In T190408#4107214, @Catrope wrote:

Most likely it'll be on next week's train (April 10-12).

Noted, thanks! I've added it to Tech News.

Trizek-WMF moved this task from Not ready to announce to Announce in next Collaboration Newsletter on the User-notice-collaboration board.Apr 5 2018, 8:50 AM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Apr 5 2018, 6:24 PM
Liuxinyu970226 subscribed.Apr 8 2018, 4:17 AM
Trizek-WMF moved this task from Announce in next Collaboration Newsletter to In current Collaboration Newsletter draft on the User-notice-collaboration board.Apr 11 2018, 2:12 PM
RandomDSdevel awarded a token.Apr 11 2018, 10:12 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 12 2018, 3:55 PM
gerritbot added a comment.Apr 12 2018, 4:07 PM

Change 423824 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Convert patrolled filter to three states

https://gerrit.wikimedia.org/r/423824

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Apr 12 2018, 4:40 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 12 2018, 5:00 PM
Etonkovidova subscribed.Apr 12 2018, 10:41 PM

@Catrope, @jmatazzoni recentchanges table has only three options for patrol status: 0, 1, and 2 which you mapped to 'Unpatrolled', 'Manually patrolled', and 'Autopatrolled' respectively. Unfortunately, actions like log entries are marked with 1 which make them displayed as 'Manually patrolled'.

Screen Shot 2018-04-12 at 3.37.46 PM.png (437×737 px, 123 KB)

Ideally, it'd be good to have a fourth category - "unpatrollable", but at very least they should be 'Autopatrolled'?

• Catrope added a subscriber: Ladsgroup.Apr 18 2018, 8:03 PM

Hmm, we could change such actions to get rc_patrolled=2 instead of rc_patrolled=1 by default, or we could use 3 for unpatrollable. @Ladsgroup: thoughts?

• Catrope mentioned this in T184791: Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits.Apr 18 2018, 8:03 PM
Ladsgroup added a comment.Apr 20 2018, 2:33 PM

I'd say let's go with 2 instead, introducing the forth option causes complexity in the API. See what happened with T184791

Etonkovidova moved this task from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 23 2018, 9:30 PM
gerritbot added a comment.Apr 24 2018, 7:51 PM

Change 428728 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Use PRC_AUTOPATROLLED for all automatic things

https://gerrit.wikimedia.org/r/428728

gerritbot added a comment.Apr 26 2018, 6:24 PM

Change 429249 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Use PRC_AUTOPATROLLED for rollbacks and revdel

https://gerrit.wikimedia.org/r/429249

gerritbot added a comment.Apr 27 2018, 10:36 AM

Change 428728 merged by jenkins-bot:
[mediawiki/core@master] Use PRC_AUTOPATROLLED for log entries and category entries

https://gerrit.wikimedia.org/r/428728

• Catrope moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 27 2018, 2:42 PM
Etonkovidova closed this task as Resolved.Apr 28 2018, 12:45 AM

Checked in cawiki betalabs - rollbacks, undo, log entries and Category changes are marked as Autopatrolled now.

Screen Shot 2018-04-27 at 5.41.14 PM.png (450×938 px, 124 KB)

Liuxinyu970226 awarded a token.Apr 30 2018, 4:29 AM
Liuxinyu970226 unsubscribed.Apr 30 2018, 4:39 AM
gerritbot added a comment.Feb 6 2019, 5:42 PM

Change 429249 merged by jenkins-bot:
[mediawiki/core@master] Use PRC_AUTOPATROLLED for rollbacks and revdel

https://gerrit.wikimedia.org/r/429249

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2022, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits