[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T181717

Uncaught TypeError: Cannot read property 'replace' of undefined in mediawiki.Title.js
Closed, ResolvedPublic
Actions

Description

I suspect the AdvancedSearch extension to cause this. I get it constantly when submitting advanced searches on dewiki. I don't get it when AdvancedSearch is disabled.

Uncaught TypeError: Cannot read property 'replace' of undefined
    at getNamespacePrefix (<anonymous>:179:1720)
    at Title.getNamespacePrefix (<anonymous>:186:88)
    at Title.getPrefixedDb (<anonymous>:186:648)
    at Title.getUrl (<anonymous>:187:108)
    at i (<anonymous>:265:926)
    at <anonymous>:263:927
getNamespacePrefix @ VM784:179
getNamespacePrefix @ VM784:186
getPrefixedDb @ VM784:186
getUrl @ VM784:187
i @ VM784:265
(anonymous) @ VM784:263
requestIdleCallback (async)
./src/index.js @ VM784:263
t @ VM784:244
(anonymous) @ VM784:244
mw.loader.implement.css @ VM784:244
runScript @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
checkCssHandles @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fire @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fireWith @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fire @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fireCallbacks @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
addEmbeddedCSS @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
requestAnimationFrame (async)
addEmbeddedCSS @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
execute @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
handlePending @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
markModuleReady @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
runScript @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
checkCssHandles @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fire @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fireWith @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fire @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
fireCallbacks @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
addEmbeddedCSS @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
requestAnimationFrame (async)
addEmbeddedCSS @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
execute @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
implement @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM784:29
DOMEval @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
globalEval @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
requestIdleCallback (async)
asyncEval @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
work @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
enqueue @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
load @ VM742 load.php?debug=false&lang=de-formal&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&
(anonymous) @ index.php?advancedSearchOption-original=Michael+Schönitzer+WMDE&search=Michael+Schönitzer+WMDE&title=Spezial:Suche&profile=default&fulltext=1&advancedSearchOption-filetype=&advancedSearch-current={"options"%3A{}%2C"namespaces"%3A["2"%2C"3"%2C"4"]}&ns2=1&ns3=1&ns4=1&searchToken=ccykra0n90yl9xx6u4tssv6y0:11
startUp @ VM741 load.php?debug=false&lang=de-formal&modules=startup&
script.onload @ VM741 load.php?debug=false&lang=de-formal&modules=startup&>

Details

SubjectRepoBranchLines +/-
Don't manipulate global namespacesmediawiki/extensions/AdvancedSearchmaster+6 -5
Customize query in gerrit

Related Objects

Event Timeline

Tobi_WMDE_SW created this task.Nov 30 2017, 1:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2017, 1:54 PM
Tobi_WMDE_SW triaged this task as High priority.Nov 30 2017, 1:54 PM
Tobi_WMDE_SW added a comment.Nov 30 2017, 1:57 PM

Also mentioned in T181633#3796620 but IMO unrelated to the main issue described there, so I created a separate task.

Addshore subscribed.Nov 30 2017, 3:07 PM

I can reproduce this on dewiki but not on testwiki or arwiki.
https://de.wikipedia.org/w/index.php?search=sajkfkhsf&title=Spezial:Suche&go=Go&searchToken=9b23jzqlqvo7c25db38eo60li

dewiki is currently running the .8 branch and arwiki and testwiki are running .10

It could be that this evenings train which pushes .10 to dewiki might fix this issue.

Addshore added a subscriber: WMDE-Fisch.Nov 30 2017, 3:09 PM

I take that back!

Reproduction on arwiki @ https://ar.wikipedia.org/w/index.php?search=dasfadsfasd&title=%D8%AE%D8%A7%D8%B5:%D8%A8%D8%AD%D8%AB&go=Go&searchToken=3o6p5kggsei42roqo1el44kvb

Thanks @WMDE-Fisch

WMDE-Fisch added a comment.Nov 30 2017, 3:18 PM

Does not occur with debug=true might be a dependency / load problem.

Addshore moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-11-28 board.Nov 30 2017, 3:53 PM
Tobi_WMDE_SW moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Dec 5 2017, 1:38 PM
• Lea_WMDE moved this task from Currently in sprint to Sprint ready on the WMDE-TechWish board.Dec 14 2017, 2:39 PM
• Lea_WMDE added a project: WMDE-QWERTY-XMAS-Sprint-2017-12-20.Dec 18 2017, 11:13 AM
• Lea_WMDE moved this task from Sprint Backlog to AdvancedSearch on the WMDE-QWERTY-XMAS-Sprint-2017-12-20 board.Dec 18 2017, 11:24 AM
WMDE-Fisch claimed this task.Dec 21 2017, 1:06 PM
WMDE-Fisch moved this task from AdvancedSearch to Doing on the WMDE-QWERTY-XMAS-Sprint-2017-12-20 board.
WMDE-Fisch added a comment.Dec 21 2017, 3:43 PM

So I looked into the issue and could also reproduce it. The code that triggers the error is called in the Popups[1] extension [2]. So I only get it when the Popups extension is installed.

The thing wrong at that point seems to be a unset namespace that we try to access here [3]. Since the title constructed in [2] is a title in the Special namespace he seems to fail due to that. The error is gone for example when I remove the Special: prefix at that place.

[1] https://www.mediawiki.org/wiki/Extension:Popups
[2] https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/src/previewBehavior.js;c175cffe9b0ef6c0224ad03b6ca92cea9619cb6f$53
[3] https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki/mediawiki.Title.js;0dd7cdb304484f826511db39fcf8552101ed19c5$145

That's how far I got for now. I am not sure if this is something the Popups guys need to fix or if it's on our side. - Since it does not occur with debug=true it still seems load-related.

Addshore added a project: Page-Previews.Dec 21 2017, 6:01 PM
• bmansurov added a project: Web-Team-Backlog.Dec 22 2017, 2:16 PM
• bmansurov moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Dec 22 2017, 2:20 PM
Jdlrobson subscribed.Jan 2 2018, 11:11 PM

I can't seem to replicate this... is there a test wiki I can see this on?

WMDE-Fisch added a comment.Jan 3 2018, 9:19 AM

Steps to reproduce:

There you should get the error on the JS console.
( in FF starts slightly different TypeError: mw.config.get(...)[namespace] is undefined )

Jdlrobson removed projects: Web-Team-Backlog, Page-Previews.EditedJan 3 2018, 10:35 PM

mw.config.get('wgFormattedNamespaces') doesn't contain the special field.

Visit https://de.wikipedia.org/wiki/Wikipedia:Hauptseite or https://de.wikipedia.org/wiki/Spezial:Beobachtungsliste

mw.config.get('wgFormattedNamespaces')[-1]
"Spezial"

When I visit https://de.wikipedia.org/w/index.php?search=&title=Spezial%3AWatchlist

mw.config.get('wgFormattedNamespaces')[-1]
undefined

It looks like AdvancedSearch removes this for some reason:
https://github.com/wikimedia/mediawiki-extensions-AdvancedSearch/blob/d1e9f8ae2b3409aa3ee7f63f0cd16d5d19901561/modules/ext.advancedSearch.init.js#L35

Changing config doesn't seem like a good idea IMO. It should be considered immutable. Why is anything less than 0 being removed?

gerritbot subscribed.Jan 4 2018, 12:02 PM

Change 402027 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Dont manipulate global namespaces

https://gerrit.wikimedia.org/r/402027

gerritbot added a project: Patch-For-Review.Jan 4 2018, 12:02 PM
WMDE-Fisch mentioned this in rEASR39de2ccef9e6: Dont manipulate global namespaces.Jan 4 2018, 12:04 PM
WMDE-Fisch added a comment.Jan 4 2018, 12:06 PM

It looks like AdvancedSearch removes this for some reason:
https://github.com/wikimedia/mediawiki-extensions-AdvancedSearch/blob/d1e9f8ae2b3409aa3ee7f63f0cd16d5d19901561/modules/ext.advancedSearch.init.js#L35

Changing config doesn't seem like a good idea IMO. It should be considered immutable. Why is anything less than 0 being removed?

Ok, thanks for looking into this. I was not aware of the fact, that we manipulate the global variable with these lines of code.... still seems strange to me. I fixed it in the patch above.

WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-XMAS-Sprint-2017-12-20 board.Jan 4 2018, 12:06 PM
Addshore mentioned this in rEASRc3c205dc2f84: Don't manipulate global namespaces.Jan 5 2018, 4:10 PM
Addshore mentioned this in rEASRc5384d8ff298: Don't manipulate global namespaces.
WMDE-Fisch mentioned this in rEASR551848e585ed: Don't manipulate global namespaces.Jan 8 2018, 4:02 PM
Tobi_WMDE_SW moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.Jan 9 2018, 12:52 PM
gerritbot added a comment.Jan 9 2018, 1:32 PM

Change 402027 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Don't manipulate global namespaces

https://gerrit.wikimedia.org/r/402027

WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-XMAS-Sprint-2017-12-20 board.Jan 9 2018, 1:37 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 9 2018, 2:00 PM
• Lea_WMDE moved this task from Backlog to Doing (others) on the Advanced-Search board.Jan 10 2018, 8:45 AM
WMDE-Fisch closed this task as Resolved.Jan 23 2018, 2:43 PM
WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.
• Lea_WMDE moved this task from Done to Demoed on the WMDE-TechWish board.Feb 20 2018, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits