[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T178975

[wmf.5] testwiki - Tag names are not correctly displayed
Closed, ResolvedPublic
Actions

Assigned To
• Catrope
Authored By
Etonkovidova
Oct 25 2017, 8:03 AM
Tags
Referenced Files
F10579995: Screen Shot 2017-11-02 at 6.11.45 PM.png
Nov 3 2017, 1:13 AM
F10425405: rcfilters-xss-tags.png
Oct 25 2017, 8:58 AM
F10424785: Screen Shot 2017-10-25 at 1.28.02 PM.png
Oct 25 2017, 8:03 AM
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot

Description

Should we accommodate unusual syntax in tag names?

testwiki:

Screen Shot 2017-10-25 at 1.28.02 PM.png (446×755 px, 61 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: HTML-escape tag names in filter capsulesmediawiki/coremaster+5 -4
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Oct 25 2017, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2017, 8:03 AM
Etonkovidova updated the task description. (Show Details)Oct 25 2017, 8:41 AM
• Catrope subscribed.Oct 25 2017, 8:55 AM

It looks like that tag doesn't have a description message defined? That's not something that usually happens, but we should still handle that gracefully.

• Catrope added a comment.Oct 25 2017, 8:58 AM

Nope, the tag name is actually defined that way (!) https://test.wikipedia.org/wiki/MediaWiki:Tag-foo-description

The bug here is that we are treating tag descriptions as HTML (!!) when we shouldn't.

rcfilters-xss-tags.png (66×466 px, 8 KB)

gerritbot subscribed.Oct 25 2017, 9:09 AM

Change 386344 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: HTML-escape tag names in filter capsules

https://gerrit.wikimedia.org/r/386344

gerritbot added a project: Patch-For-Review.Oct 25 2017, 9:09 AM
Jdforrester-WMF assigned this task to • Catrope.Nov 1 2017, 3:46 PM
Jdforrester-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Patch-For-Review, Collaboration-Team-Triage.
Jdforrester-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.
gerritbot added a comment.Nov 1 2017, 3:53 PM

Change 386344 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: HTML-escape tag names in filter capsules

https://gerrit.wikimedia.org/r/386344

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 4:00 PM
Etonkovidova added a comment.Nov 3 2017, 1:13 AM

Checked in betalabs:

Screen Shot 2017-11-02 at 6.11.45 PM.png (350×809 px, 55 KB)

Etonkovidova closed this task as Resolved.Nov 3 2017, 1:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits