[go: up one dir, main page]

Page MenuHomePhabricator

User:Babel AutoCreate can't support language conversion of category
Closed, ResolvedPublicBUG REPORT

Description

When Babel extension autoareate an category page, if the zh-hant/zh-hans category page exists, it will still create an zh-hans/zh-hant category page. see https://zh.wikipedia.org/wiki/User_talk:Babel_AutoCreate

For this reason, User:Babel AutoCreate blocked in zhwiki.

Event Timeline

@Shizhao Hello! Can you please elaborate on the problem? Now it is not clear what it is.

Change 884334 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/Babel@master] Babel: Fix the "findVariantLink behavior" for language variant categories

https://gerrit.wikimedia.org/r/884334

Hello! Can you please elaborate on the problem? Now it is not clear what it is.

The problem is:

In https://gerrit.wikimedia.org/r/884334 , the description wrote:

We need to check whether non-existing link in one language variant actually exists in another language variant when a language supports multiple language variants.

Thanks! @Pppery, can you please check if this overlaps with your patches? :)

Thanks! @Pppery, can you please check if this overlaps with your patches? :)

The change I created should be mergable (at the same position) as long as the parameter string $category Name of category to create. of the function create stay unchanged in the change of @Pppery (which is the current status).

Winston_Sung changed the task status from Open to In Progress.Jan 28 2023, 5:10 PM
Winston_Sung claimed this task.

I don't understand LanguageConvrter very well, but the patch looks like it doesn't overlap with anything I'm doing. It merge conflicts with the patch for T184941: Babel AutoCreate creating empty categories (already on page preview), but the idea would still be valid even if that were merged, and the conflict would be easy to resolve.

Change 884334 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/extensions/Babel@master] Babel: Fix the "findVariantLink behavior" for language variant categories

https://gerrit.wikimedia.org/r/884334

@Iniquity : I've tested the change and everything looks good to me. Could you help with the code review process? Thanks.

Tested on localhost wiki instance and the issue got fixed:
Didn't create new duplicated category pages on another language variant name.

Shizhao changed the subtype of this task from "Task" to "Bug Report".Feb 21 2023, 2:54 AM

Change 884334 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Babel: Fix the "findVariantLink behavior" for language variant categories

https://gerrit.wikimedia.org/r/884334