[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T159906

Non-anchored popups don't align correctly
Closed, ResolvedPublic
Actions

Description

A popup button widget with a non-anchored popup has the wrong alignment (seems to have extra top margin and act as if it is anchored even though the anchor is hidden)

popup-widget-non-anchored-bug.png (147×347 px, 6 KB)

It would also be great if we could physically align/place the popup so that its right edge aligns with its trigger/anchor right edge.
Floatable element supports this with "horizontalPosition: end" - and mw.rcfilters.ui.FilterItemHighlightButton (where this popup is from) passes that in, but it seems to be overridden in the popup.

Details

SubjectRepoBranchLines +/-
RCFilters UI: Use backwards-aligned anchorless popups now that they workmediawiki/coremaster+2 -6
PopupWidget: Sensibly position anchor-less popupsoojs/uimaster+63 -23
RCFilters UI: Anchor the highlight popupmediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Mar 8 2017, 2:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2017, 2:20 AM
gerritbot subscribed.Mar 8 2017, 2:24 AM

Change 341731 had a related patch set uploaded (by Mooeypoo):
[mediawiki/core] RCFilters UI: Anchor the highlight popup

https://gerrit.wikimedia.org/r/341731

gerritbot added a project: Patch-For-Review.Mar 8 2017, 2:24 AM
Aklapper added projects: MediaWiki-General, MediaWiki-Recent-changes.Mar 8 2017, 1:26 PM
gerritbot added a comment.Mar 8 2017, 5:26 PM

Change 341731 merged by jenkins-bot:
[mediawiki/core] RCFilters UI: Anchor the highlight popup

https://gerrit.wikimedia.org/r/341731

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).Mar 8 2017, 6:00 PM
matmarex added subscribers: matmarex, • Catrope.Mar 8 2017, 6:14 PM
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).May 25 2017, 1:33 PM
gerritbot added a comment.May 26 2017, 8:14 PM

Change 355823 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] PopupWidget: Sensibly position anchor-less popups

https://gerrit.wikimedia.org/r/355823

gerritbot added a comment.May 26 2017, 8:15 PM

Change 355824 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters UI: Use backwards-aligned anchorless popups now that they work

https://gerrit.wikimedia.org/r/355824

gerritbot added a comment.May 29 2017, 3:26 PM

Change 355823 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Sensibly position anchor-less popups

https://gerrit.wikimedia.org/r/355823

Jdforrester-WMF assigned this task to • Catrope.Jun 2 2017, 12:37 AM
Jdforrester-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed MW-1.29-release-notes, MediaWiki-General, Patch-For-Review.
Jdforrester-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot added a comment.Jun 2 2017, 12:47 AM

Change 355824 merged by jenkins-bot:
[mediawiki/core@master] RCFilters UI: Use backwards-aligned anchorless popups now that they work

https://gerrit.wikimedia.org/r/355824

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jun 2 2017, 1:00 AM
Etonkovidova subscribed.Jun 2 2017, 11:28 AM

Checked in betalabs - the popup is anchored and aligned (the issue with the misplaced checkmark is filed as T166874: [betalabs-Regression] The check mark for highlighted colors is not centered in color circles )

Screen Shot 2017-06-02 at 3.15.06 PM.png (338×674 px, 64 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Jun 2 2017, 11:31 AM
• jmatazzoni closed this task as Resolved.Jun 15 2017, 11:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits