[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T156039

Allow RelatedPages to be enabled for subset of users
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

We want to deploy and enable Related Pages for 90% users (T154681) but there is no such possibility atm. Implement necessary wiring/configuration setting to allow that.

Details

SubjectRepoBranchLines +/-
Use mw.experiment to enable related pages only to subset of usersmediawiki/extensions/RelatedArticlesmaster+47 -13
Customize query in gerrit

Related Objects

Event Timeline

pmiazga created this task.Jan 23 2017, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2017, 5:48 PM
pmiazga added a project: MobileFrontend.Jan 23 2017, 5:49 PM
MBinder_WMF set the point value for this task to 3.Jan 23 2017, 6:14 PM
MBinder_WMF added subscribers: ovasileva, MBinder_WMF.

@ovasileva Now that this has an estimate, can it be prioritized or declined? Word has it you wanted an estimate first... :)

ovasileva added a comment.Jan 23 2017, 6:16 PM

@MBinder_WMF - prioritized

MBinder_WMF added a comment.Jan 23 2017, 6:18 PM

Sorry, @ovasileva I still see this task as purple "Needs Triage." Perhaps you prioritized it in a column somewhere? What I meant was "High" or "Normal" etc. :)

MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-90-🍌 board.Jan 23 2017, 6:19 PM
Jdlrobson added a project: Web-Team-Backlog.Jan 23 2017, 6:19 PM
Jdlrobson subscribed.Jan 23 2017, 6:57 PM

Moving back to needs analysis. @ovasileva was still deciding whether this was worth pursuing on Thursday.

Jdlrobson moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-90-🍌 board.Jan 23 2017, 6:57 PM
ovasileva triaged this task as High priority.Jan 24 2017, 11:35 AM
• bmansurov subscribed.Jan 24 2017, 3:04 PM

@pmiazga here is a sample code (per our talk during stand-up):
https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/resources/ext.popups.schemaPopups.utils/ext.popups.schemaPopups.utils.js#L54

Here is another one: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/skins.minerva.scripts/init.js#L162

pmiazga claimed this task.Jan 24 2017, 4:04 PM
pmiazga moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-90-🍌 board.
ovasileva moved this task from Incoming to 2016-17 Q3 on the Web-Team-Backlog board.Jan 24 2017, 7:55 PM
gerritbot subscribed.Jan 27 2017, 9:19 PM

Change 334716 had a related patch set uploaded (by Pmiazga):
Use mw.experiment to enable related pages only to subset of users

https://gerrit.wikimedia.org/r/334716

gerritbot added a project: Patch-For-Review.Jan 27 2017, 9:19 PM
pmiazga moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 27 2017, 10:10 PM
Jdlrobson moved this task from Needs Code Review to Blocked Externally on the Reading-Web-Sprint-90-🍌 board.Jan 27 2017, 11:35 PM
Jdlrobson added a parent task: T156535: BetaFeatures unit tests failing after change to User::addGroup.
phuedx subscribed.Jan 30 2017, 10:22 AM

^ @Jdlrobson: Why was this moved to Blocked Externally? I couldn't see anything in Gerrit…

Jdlrobson removed a parent task: T156535: BetaFeatures unit tests failing after change to User::addGroup.Jan 30 2017, 5:35 PM

It was blocked on the above (stopped any kind of merging) but now that's fixed.

Jdlrobson moved this task from Blocked Externally to Needs Code Review on the Reading-Web-Sprint-90-🍌 board.Jan 30 2017, 5:35 PM
pmiazga moved this task from Needs Code Review to Needs More Work on the Reading-Web-Sprint-90-🍌 board.Jan 30 2017, 5:49 PM
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-90-🍌 board.Jan 30 2017, 10:46 PM
Jdlrobson removed a project: Patch-For-Review.
phuedx added a comment.Jan 31 2017, 9:54 AM
In T156039#2982500, @Jdlrobson wrote:

It was blocked on the above (stopped any kind of merging) but now that's fixed.

Thanks for the update 🙂

phuedx reassigned this task from pmiazga to • bmansurov.Jan 31 2017, 9:54 AM

This is quite hard to sign off from a product perspective. Over to you @bmansurov!

phuedx added a comment.Jan 31 2017, 1:46 PM

^ Whoops! It looks like rERAR0806dbdb4221: Use mw.experiment to enable related pages only to subset of users hasn't been merged yet…

gerritbot added a comment.Jan 31 2017, 1:47 PM

Change 334716 merged by jenkins-bot:
Use mw.experiment to enable related pages only to subset of users

https://gerrit.wikimedia.org/r/334716

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 31 2017, 2:00 PM
• bmansurov closed this task as Resolved.Jan 31 2017, 4:02 PM
• bmansurov removed • bmansurov as the assignee of this task.

Tested at http://reading-web-staging.wmflabs.org/wiki/1 by setting $wgRelatedArticlesEnabledSamplingRate to 0 and 1.

Jdlrobson mentioned this in T154681: Deploy related pages to mobile web stable for 90% English.Feb 2 2017, 6:56 PM
pmiazga mentioned this in T157372: [SUBTASK] RelatedArticlesEnabledSamplingRate breaks RelatedArticles browser tests.Feb 6 2017, 7:26 PM
• bmansurov added a comment.Feb 7 2017, 8:53 PM

Upon further testing, I found that the config variable RelatedArticlesEnabledSamplingRate only works on skins that are not supported by BetaFeatures.

• bmansurov mentioned this in T157375: Update related pages schema to allow for current A/B test.Mar 1 2017, 9:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits