Multiple special page transclusions all display the same as the first transclusion present
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sunpriat
	Apr 13 2016, 6:45 AM

Description

https://ru.wikipedia.org/wiki/%D0%9F%D1%80%D0%BE%D0%B5%D0%BA%D1%82:%D0%98%D0%BD%D1%84%D0%BE%D1%80%D0%BC%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%BD%D1%8B%D0%B5_%D1%82%D0%B5%D1%85%D0%BD%D0%BE%D0%BB%D0%BE%D0%B3%D0%B8%D0%B8?uselang=en

ru.wikipedia.org screen capture 2016-04-13_09-33-30.png (594×1 px, 159 KB)

The page included 3 recent change call for three different lists
before was all right - there were three different displaying
but already a few days it shows the same list of the first call - all become equally displayed

Details

Subject	Repo	Branch	Lines +/-
Revert "Don't construct SpecialPages twice"	mediawiki/core	REL1_28	+10 -15
Revert "Don't construct SpecialPages twice"	mediawiki/core	master	+10 -15
Don't cache SpecialPage object for transcluded pages	mediawiki/core	master	+94 -9

Customize query in gerrit

Related Objects

Mentioned In: T123995: Special pages are constructed twice
E257: Code Review Office Hours
Mentioned Here: T123995: Special pages are constructed twice
rMWba40a63c0ee2: Don't construct SpecialPages twice

Event Timeline

Sunpriat created this task.Apr 13 2016, 6:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2016, 6:45 AM

I copied the code that shows these transclusions of Special:RecentChangesLinked to https://ru.wikipedia.org/wiki/%D0%A3%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA:Krenair/sandbox - I notice that if you go to edit the page and change the first one's namespace to 3, they *all* start showing "No changes during the given period matching these criteria."

Krenair renamed this task from Inclusion related changes become equally displayed to Multiple transclusions of Special:RecentChangesLinked all display the same as the first transclusion present.Apr 13 2016, 3:30 PM

@matmarex wonders if this might be caused by rMWba40a63c0ee2: Don't construct SpecialPages twice ?

For a simple test case:

{{Special:RecentChanges|limit=1}}
----
{{Special:RecentChanges|limit=2}}
----
{{Special:RecentChanges|limit=3}}

This gives me three identical results (with a single item) on en.wp.

Krenair renamed this task from Multiple transclusions of Special:RecentChangesLinked all display the same as the first transclusion present to Multiple special page transclusions all display the same as the first transclusion present.Apr 13 2016, 8:42 PM

In T132545#2204750, @Krenair wrote:

@matmarex wonders if this might be caused by rMWba40a63c0ee2: Don't construct SpecialPages twice ?

Hmm, damn, @Catrope, @daniel and I thought about possible side effects of this change, but we haven't thought about multiple inclusion.

Change 283326 had a related patch set uploaded (by Florianschmidtwelzow):
Don't cache SpecialPage object for transcluded pages

https://gerrit.wikimedia.org/r/283326

gerritbot added a project: Patch-For-Review.Apr 13 2016, 8:57 PM

• Arbnos subscribed.May 28 2016, 1:32 PM

It happened after April 7 https://www.mediawiki.org/wiki/MediaWiki_1.27/wmf.20 T123995: Special pages are constructed twice

Glaisher merged a task: T139295: {{Special:NewPages|hidepatrolled=1}} transclusion does not work properly any more (incorrectly shows all new pages).Jul 30 2016, 1:10 PM

Glaisher added subscribers: IKhitron, Matanya, eranroz, Zppix.

Hello, @Glaisher, could you explain why do you think these two tasks have something common at all? Thank you.

In T132545#2507943, @IKhitron wrote:

Hello, @Glaisher, could you explain why do you think these two tasks have something common at all? Thank you.

Sorry, on further look, these are two different bugs.

Thibaut120094 awarded a token.Jul 31 2016, 9:20 AM

Thibaut120094 subscribed.

Dereckson mentioned this in E257: Code Review Office Hours.Jul 31 2016, 10:41 AM

Dereckson added a project: Regression.

Ltrlg subscribed.Jul 31 2016, 4:19 PM

Orlodrim merged a task: T132385: Using Special:Recentchangeslinked more than once on a single page duplicates the first list for any further instances.Sep 11 2016, 4:26 PM

Orlodrim added a subscriber: Archimea.

Orlodrim subscribed.Sep 11 2016, 4:30 PM

Ptolusque subscribed.Sep 18 2016, 9:04 AM

Ptolusque awarded a token.Sep 18 2016, 9:06 AM

I'm adding this as a 1.28 release blocker, and left a comment on T123995#2778619 which caused this bug.

Change 320723 had a related patch set uploaded (by Legoktm):
Revert "Don't construct SpecialPages twice"

https://gerrit.wikimedia.org/r/320723

Change 320723 merged by jenkins-bot:
Revert "Don't construct SpecialPages twice"

https://gerrit.wikimedia.org/r/320723

Change 320726 had a related patch set uploaded (by Legoktm):
Revert "Don't construct SpecialPages twice"

https://gerrit.wikimedia.org/r/320726

The fix for this will be deployed to Wikimedia sites next week, and included in 1.28.

Change 320726 merged by jenkins-bot:
Revert "Don't construct SpecialPages twice"

https://gerrit.wikimedia.org/r/320726

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.28-release-notes, MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)).Nov 10 2016, 7:00 AM

For information: The bug were happen, because the Special:RecentChanges cached some options and filters as member variable, which gets not cleared when the object was reused and thus using the old options and filter showing the same data twice. See https://gerrit.wikimedia.org/r/#/c/308144/

	F3867858: ru.wikipedia.org screen capture 2016-04-13_09-33-30.png
	Apr 13 2016, 6:45 AM

Multiple special page transclusions all display the same as the first transclusion presentClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Multiple special page transclusions all display the same as the first transclusion present
Closed, ResolvedPublic
Actions