Reproduce by browsing to http://en.m.wikipedia.beta.wmflabs.org/wiki/Alcatraz_Island?quicksurvey=true and clicking yes in the quick survey box.
Throws [QuickSurveysResponses] Missing or empty schema.
Reproduce by browsing to http://en.m.wikipedia.beta.wmflabs.org/wiki/Alcatraz_Island?quicksurvey=true and clicking yes in the quick survey box.
Throws [QuickSurveysResponses] Missing or empty schema.
Change 237145 had a related patch set uploaded (by Robmoen):
Fix typo with example survey schema config
https://meta.wikimedia.org/wiki/Schema:QuickSurveysResponses is the correct schema...
The error suggests that the schema isn't loaded properly. Looking at the code I don't see a ResourceLoader schema.QuickSurveysResponses module added anywhere...
@Jdlrobson: I'm not sold on having EventLogging as an optional dependency for QuickSurveys. Why are we worried at this point about it not being installed?
Change 237173 had a related patch set uploaded (by Jdlrobson):
Fix schema dependency and resolve other logging errors
For completeness and transparency to other team members in IRC @rmoen and I chatted.
I was concerned that the patch made EventLogging a required dependency without explicitly saying so.
I proposed one of two solutions:
OR
Conditionally adding the schemas so that people do not have to setup EventLogging to test out QuickSurveys.
That registers a schema but doesn't make it accessible in ResourceLoader... (Backend usage only)
That registers a schema but doesn't make it accessible in ResourceLoader... (Backend usage only)
All schemas added to the $schemas map are registered as RL modules once the hook has completed firing: EventLoggingHooks#L65-L80.
Yeh but you still need to pass the schema to the page... Looking at the code I don't see a ResourceLoader schema.QuickSurveysResponses module added anywhere...
Change 237173 merged by jenkins-bot:
Fix schema dependency and resolve other logging errors
I'm seeing events go through on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?quicksurvey=true so calling this closed