|
|
@19270
|
2 days |
stoecker |
|
|
prevent CI test failures on Windows java 11, where 500ms are only 497ms sometimes
|
|
|
@19269
|
2 days |
stoecker |
|
|
silence PMD - some of these rules are bullshit - explicit initialization is always better than default ones even if it costs a little space
|
|
|
@19268
|
2 days |
stoecker |
|
|
split mismatching translations, fix #24024
|
|
|
@19267
|
3 days |
taylor.smock |
|
|
Fix #22035: Add preset amenity=driver_training (patch by SteveLz, modified)
Modifications are as follows:
- Add similar but different tag links
- Add rendering for amenity=driver_training when it is a node
amenity=driver_training is different from amenity=driving_school in that
amenity=driver_training is where the student driver can physically drive a
vehicle for practice. amenity=driving_school may also teach theoretical driving
practices and may have physical training aids.
|
|
|
@19266
|
3 days |
taylor.smock |
|
|
Fix #23945: ImageViewerDialog.displayImages() - do not re-center if the image has not changed (patch by IreuN)
|
|
|
@19265
|
11 days |
taylor.smock |
|
|
i18n updates
|
|
|
@19264
|
11 days |
taylor.smock |
|
|
Fix #24030: JEP 486 (in Java 24) always throws an UnsupportedOperationException when attempting to set security policy
This merely fixes startup issues. There are a few other locations which may
cause issues, but did not during relatively minimal testing.
|
|
|
@19263
|
13 days |
stoecker |
|
|
indicate possible shortcuts for parser
|
|
|
@19262
|
3 weeks |
taylor.smock |
|
|
pmd
|
|
|
@19261
|
3 weeks |
taylor.smock |
|
|
See #24014: Add multiline and normalize attributes to preset xsd
normalize="false" will prevent all whitespace normalization while
normalize="true" + multiline="true" will strip start and end whitespace and
inner whitespace that is not newlines.
The primary reason for this change is osmwiki:Key:inscription which can have
newlines in order to match the inscription.
This does not modify UI elements to support multiline editing.
|
|
|
@19260
|
3 weeks |
taylor.smock |
|
|
Fix #24023: Add pashto (ps ) as an RTL language
|
|
|
@19259
|
4 weeks |
stoecker |
|
|
fix #23943 - patch by Famlam - allow negative values for substring to count from the end of the string
|
|
|
@19258
|
4 weeks |
stoecker |
|
|
fix #24009 - don't call setting storage in settings setup stage or checkbox state gets lost
|
|
|
@19257
|
4 weeks |
stoecker |
|
|
fix #23932 - patch by huntertur - Add cycleway:*:buffer to Highways/Ways/Cycle Lane/Track preset
|
|
|
@19256
|
4 weeks |
taylor.smock |
|
|
Add/ignore popular tags
Add:
|
|
|
@19255
|
4 weeks |
stoecker |
|
|
fix URL joining for WMTS when URL comes from capabilities and doesn't end in a separation, fix #23980
|
|
|
@19254
|
5 weeks |
stoecker |
|
|
some small cleanups
|
|
|
@19253
|
6 weeks |
taylor.smock |
|
|
Fix #23988: Add api.openhistoricalmap.org as a possible endpoint for OHM when getting the default client id (patch by Rub21)
|
|
|
@19252
|
7 weeks |
taylor.smock |
|
|
i18n updates
|
|
|
@19251
|
7 weeks |
taylor.smock |
|
|
Dependency updates
Most plugins have been moved to require a minimum version of r19044 (mostly for
Java 11+ build reasons).
|
|
|
@19250
|
7 weeks |
taylor.smock |
|
|
Dependency updates
ivy.xml:
- junit5-system-exit: 1.1.2 -> 2.0.0 on Java 17+. This is needed since there are
patches currently being applied to the JDK to remove the security manager (see
JEP 486), and the 1.x series will no longer work. The 2.x series is Java 17+
only and runs as a javaagent.
- tag2link: 2024.8.21 -> 2024.10.21
- wiremock: 3.9.1 -> 3.9.2
- junit5: 5.11.0 -> 5.11.3
tools/ivy.xml:
- checkstyle: 10.18.1 -> 10.18.2
- proguard-ant: 7.5.0 -> 7.6.0
- pmd: 7.5.0 -> 7.6.0
- errorprone: Not upgraded from 2.31.0 -> 2.34.0 (since it is Java 17+ only)
|
|
|
@19249
|
7 weeks |
taylor.smock |
|
|
Fix #23978: Windows does not like paths with multiple :
This fixes an issue where a gpx track with attached images could cause an
exception.
|
|
|
@19248
|
7 weeks |
stoecker |
|
|
see #23964 - One typo in each added word - was probably not my best day ;-)
|
|
|
@19247
|
8 weeks |
taylor.smock |
|
|
Fix #23950: Fix a StackOverflowError that occurs when a self-referencing relation exists
Also disable StyledTiledMapRendererTest in CI for now.
|
|
|
@19246
|
2 months |
taylor.smock |
|
|
Fix #23920: Wrapped ReportedException don't keep data on bug report
|
|
|
@19245
|
2 months |
taylor.smock |
|
|
Fix #23253: Remove landuse=paddy from the ignore list
It looks like most of the landuse=paddy uses were removed (probably from a
revert).
|
|
|
@19244
|
2 months |
stoecker |
|
|
cut long line
|
|
|
@19243
|
2 months |
taylor.smock |
|
|
See r19242: Ensure that seasonal is removed when it is seasonal=no
|
|
|
@19242
|
2 months |
taylor.smock |
|
|
Add/ignore popular tags
Add:
fountain -- the type of water fountain for drinking water. Some miscellaneous
tags for water fountains were also added.
|
|
|
@19241
|
2 months |
stoecker |
|
|
forgot Bopo, see #23964
|
|
|
@19240
|
2 months |
stoecker |
|
|
add some more script variants, fix #23964
|
|
|
@19239
|
2 months |
Klumbumbus |
|
|
see #23184 - Change color of bus in busway icon from black to blue to be more consistent with similar icons, e.g. steps, bicycle_road, living_street or pedestrian
|
|
|
@19238
|
2 months |
taylor.smock |
|
|
See #23926: Fix new coverity issues
Coverity doesn't like null checks when a previous statement would have thrown
a NullPointerException on the object being checked for null . This fixes the
"defect" by removing the null checks and adding a null check in
ColorScale#addTitle .
|
|
|
@19237
|
2 months |
taylor.smock |
|
|
See #23948: Fix url type (faq to help for /wiki/Help) and add a link for contribute
This additionally adds system requirements (both required and recommended).
The memory requirements comes from downloading
39.0642941;-108.5662508;39.0654645;-108.5642928
and displaying the Mesa County GIS Valleywide 2024 imagery. This was after a GC
was triggered manually; as such, JOSM is technically usable.
|
|
|
@19236
|
2 months |
taylor.smock |
|
|
Fix #23926: Extend GPS legend for time information, improve design (patch by Pauline, modified)
Modifications are as follows:
- Reduction of code duplication
- Addition of functions in ColorHelper to calculate contrast ratios
|
|
|
@19235
|
2 months |
taylor.smock |
|
|
Fix #23956: JsonParsingException when the destination server returns 200 and a malformed document
In this case, the destination server performed a redirect via javascript in the
response.
|
|
|
@19234
|
2 months |
taylor.smock |
|
|
Fix #23951: Fix free in startup linux scripts when it is in a localized environment
|
|
|
@19233
|
2 months |
stoecker |
|
|
drop list url, see #23948
|
|
|
@19232
|
2 months |
taylor.smock |
|
|
Fix #23948: Update AppStream metadata (patch by sebastic, modified)
Modifications are as follows:
- Addition of caption to screenshot
- Addition of various supplementary URLs
|
|
|
@19231
|
2 months |
taylor.smock |
|
|
ShortcutTest: Determine if HTML is supported before asserting against an HTML string
This does a few things:
- Ensures that the test will work properly if the default LaF is *not* Aqua (the
default macOS LaF)
- If Aqua ever supports HTML in menu tooltips, we will only have to change one
location
- Fewer locations to worry about in unit tests if we change the default LaF for
mac to something else
|
|
|
@19230
|
2 months |
taylor.smock |
|
|
i18n updates
|
|
|
@19229
|
3 months |
taylor.smock |
|
|
remove TLD from IANA
|
|
|
@19228
|
3 months |
taylor.smock |
|
|
Fix #23930: Merging duplicated layers with little differences stalls JOSM
This is fixed by keeping the "last" conflict in the problem if statement body.
|
|
|
@19227
|
3 months |
taylor.smock |
|
|
Fix #20908: IllegalStateException: JOSM expected to find primitive in dataset after undoing a Parallel mode action
The test acts (roughly) like a user would, and performs click and drags via a new
utility class (MapModeUtils ) which has various methods for performing mouse
actions on the map view.
|
|
|
@19226
|
3 months |
taylor.smock |
|
|
Update tests for r19225
|
|
|
@19225
|
3 months |
taylor.smock |
|
|
Fix #23925: Indicate/link to alternative download methods when the user attempts to download too much data
|
|
|
@19224
|
3 months |
taylor.smock |
|
|
Add/ignore popular tags
Add:
flood_prone=yes : This is mostly used to indicate that a highway may be
flooded after a heavy rain.
|
|
|
@19223
|
3 months |
taylor.smock |
|
|
Add JUnit5 tags to integration tests, functional tests, and performance tests
This should allow contributors to filter out integration tests inside the standard
test directory. Of specific note, this should reduce test runtime for contributors
by a non-trivial amount if contributors filter out the tagged tests.
For consistencies’ sake, tests in functional and performance were also
annotated. As such, if we ever merge the test directories, this will let us
filter which tests are run in CI.
Note that many functional tests don't have the annotation. This is because they
are manual tests.
|
|
|
@19222
|
3 months |
taylor.smock |
|
|
Add/ignore popular tags
Ignore:
admin_type:PH : Highly localized to the Philippines
residential:condominium : Deprecated -- wiki suggests residential=apartments
+ condo=*
sidewalk : This is replaced by sidewalk:both , but is still valid tagging.
Add:
managed (to wetland, wood, fell, and heath)
sidewalk:{both|left|right} : We already had validator rules for these, this
just adds them to presets. Note that sidewalk and sidewalk:both are similar,
but sidewalk=separate is unspecific as to the side of the sidewalk.
|
|
|
@19221
|
3 months |
taylor.smock |
|
|
Fix failing build due to putting unit test for renderer in unit instead of functional
This was done by fixing a TODO comment ("move to separate class ImageTestUtils")
in the MapCSSRendererTest.
|
|
|
@19220
|
3 months |
taylor.smock |
|
|
See #11487: Have josm render data to tiles
Start adding basic rendering tests for tiled rendering.
Right now, the test only looks at a point in the center of the tile; there seems
to be some positioning/stretching issues at the edges that I need to debug and
fix.
|
|
|
@19219
|
3 months |
taylor.smock |
|
|
See #23837: Set -XX:MaxRAMPercentage to >25% of system memory
Drop RAM arguments since it causes issues with OWS.
|
|
|
@19218
|
3 months |
stoecker |
|
|
fix a PMD warning
|
|
|
@19217
|
3 months |
taylor.smock |
|
|
Fix #23911: wireframe was not properly highlighting relations
This was a regression from r19166.
|
|
|
@19216
|
3 months |
taylor.smock |
|
|
Fix #23866: java.io.UncheckedIOException: java.nio.file.FileSystemException: The device is not ready
This does two things:
- Unwrap an unchecked exception in ImagesLoader so that we are throwing a
checked exception
- Explain some IO exceptions (specifically "the device is not ready")
This is not the "best" solution, but it should mean that we are not ignoring
issues related to JOSM.
|
|
|
@19215
|
3 months |
taylor.smock |
|
|
Fix #23837: Set -XX:MaxRAMPercentage to >25% of system memory
This does not currently work for WebStart, see
https://github.com/AdoptOpenJDK/IcedTea-Web/pull/954 .
As noted in the ticket, all supported MS Windows and Apple macOS machines have
4G+ of RAM. Linux machines don't have a baseline, and some have 1G or less. Where
we detect that a machine has <8G of memory in the linux start scripts, we don't
add the JVM parameters.
As a reminder to everyone reading the changelog: just because we ask for the
ability to use 75% of the system memory doesn't mean we will use all of that
memory. The JVM will free up unused memory for the rest of the system.
We additionally set the minimum memory allocation to 256m; while this can be
lower, that is for minimal amounts of data loaded. A clean JOSM install will use
99mb, for example. But once we add a minimal amount of data and a background
layer, static memory usage goes up to 161mb.
|
|
|
@19214
|
3 months |
taylor.smock |
|
|
Fix #23908: Significantly improve the performance of copy/paste when dealing with large amounts of data
From #23908, at least one valid workflow involves copy/pasting large amounts of
data (specifically updating boundaries). The relation for Terwolde in the
sample data had 2206 objects. This took >5 minutes to copy between layers. With
this change, it takes <1 second.
This is a performance regression from r19176. The primary culprit from r19176 is
when we check the size of the dataset. The problem is that we check to see if the
size of the primitives being changed is greater than or equal to the non-deleted
complete primitives in the dataset. We get a new filtered collection each time
we get those primitives, and therefore the size of that is not cached. The size
calculation for the filtered collection is where almost all the expense is. We
fix that by wrapping the work from AddPrimitivesCommand in DataSet#update to
have a single large update at the end of the copy operation. This ensures that
we do not have many spurious fired event calls when a mass operation is going on.
|
|
|
@19213
|
3 months |
stoecker |
|
|
fix SyncEditorLayerIndex script
|
|
|
@19212
|
3 months |
taylor.smock |
|
|
Fix #23770: Deprecate cycleway=opposite* family (patch by Famlam)
The cycleway=opposite* family was deprecated in
osmwiki:Proposal:Deprecate_cycleway=opposite_family on 2024-06-22.
This removes the opposite* values from the cycleway tags in defaultpresets.xml
and adds a deprecation warning for them.
|
|
|
@19211
|
3 months |
stoecker |
|
|
make cache file length configurable, ensure it's below 140 - encrypted ext4 seems to have a 143 byte limit, see #23850
|
|
|
@19210
|
3 months |
taylor.smock |
|
|
Add/ignore popular tags
Ignore:
motor_vehicle=agricultural;forestry : This is covered by standard access
tagging. I am uncertain why someone decided to create a page for a tag
consisting of a list of values.
|
|
|
@19209
|
3 months |
taylor.smock |
|
|
Add @Plugins annotation to clean up after plugins have been loaded in tests
This should help reduce the issues related to plugins not being unloaded after
PluginHandlerTestIT when tests are run locally with a UI -- the primary cause
of problems is the SDS plugin though.
|
|
|
@19208
|
3 months |
taylor.smock |
|
|
Dependency updates:
ivy.xml:
- jmapviewer: 2.21 -> 2.22: Fix a NumberFormatException (fix #23888)
- commons-compress: 1.27.0 -> 1.27.1
- tag2link: 2024.8.12 -> 2024.8.21
- commons-lang3: 3.16.0 -> 3.17.0
- classgraph: 4.8.174 -> 4.8.175
- junit: 5.10.3 -> 5.11.0: Repeatable
@..Source annotations for parameterized tests
- equalsverifier: 3.16.1 -> 3.16.2
tools/ivy.xml:
- checkstyle: 10.17 -> 10.18: Better support for Java 21
- pmd: 7.4.0 -> 7.5.0
- errorprone: 2.30.0 -> 2.31.0: Note: this is the last planned release that supports running on Java 11.
|
|
|
@19207
|
4 months |
taylor.smock |
|
|
i18n updates
|
|
|
@19206
|
4 months |
taylor.smock |
|
|
See #23875: Use SNAPSHOT instead of 1.0-SNAPSHOT since that is what our scripts currently publish
This should fix the Jenkins build for plugins.
Note: Maven warns that this may break in the future, in which case we'll have to
change our processes.
|
|
|
@19205
|
4 months |
taylor.smock |
|
|
Fix keyboard navigation in the mapview on MacOS
This also adds default shortcuts for mission control and showing all windows of
the currently focused application.
See https://web.archive.org/web/20240828134626/https://support.apple.com/en-us/102650 .
|
|
|
@19204
|
4 months |
taylor.smock |
|
|
Fix #23874: Syntax issue from r19169
It looks like tr issues don't get caught by automated tests.
|
|
|
@19203
|
4 months |
taylor.smock |
|
|
Add properties to pom.xml to make it easier to synchronize versions with plugins
Also use /public for the repository instead of having one for /central , one
for /releases , and one for /snapshots .
|
|
|
@19202
|
4 months |
taylor.smock |
|
|
Fix #23251: Crossing preset: Change label for crossing_ref
This is a followup of r19164 to change another crossing_ref reference.
|
|
|
@19201
|
4 months |
taylor.smock |
|
|
Fix #23290: Exclude incomplete relations from region checks
Also rework TagCheckerTest to use parameterized tests.
|
|
|
@19200
|
4 months |
taylor.smock |
|
|
Fix #23821: Ensure that remote control commands are processed in order
This reverts or partially reverts r19153 and r19196 in favour of forcing ordering
in the RequestProcessor#run method. This does not block the server thread, but
it can mean that we have a bunch of processor threads that are waiting on the
previous processor thread.
|
|
|
@19199
|
4 months |
stoecker |
|
|
see #21856, fix typo
|
|
|
@19198
|
4 months |
stoecker |
|
|
fix checkstyle
|
|
|
@19197
|
4 months |
taylor.smock |
|
|
Fix #21856: Split way: Wrong position of new member in PTv2 relation splitting a loop
|
|
|
@19196
|
4 months |
taylor.smock |
|
|
See #23821: Show confirmation dialogs in the order in which the remote control commands were sent to JOSM
|
|
|
@19195
|
4 months |
taylor.smock |
|
|
Fix #23860: Duplicate key+value in preset causes an ISE in TagChecker
This fixes the actual issue in TagChecker, but also adds a sanity check to
TaggingPresetPreferenceTestIT since it is usually unintended to have
duplicate key/values (and it is always a problem if they are different and are
Key items).
The fix for TagChecker is just keeping whatever value is last. Not ideal, but
it should work 99% of the time since an object won't match the preset if we have
highway=footway and highway=footway2 as Key objects.
|
|
|
@19194
|
4 months |
stoecker |
|
|
fix #23850 - reduce long cache file names
|
|
|
@19193
|
4 months |
taylor.smock |
|
|
Add/ignore documented popular tags
Add
|
|
|
@19192
|
4 months |
taylor.smock |
|
|
Fix #23841: Bing: Automatically reload all tiles with Error: Attribution is not loaded yet after successfully loading the attribution
|
|
|
@19191
|
4 months |
taylor.smock |
|
|
Dependency updates
ivy.xml
- org.openstreetmap.jmapviewer:jmapviewer: 2.20 -> 2.21 (see #23841)
- org.eclipse.parsson:parsson: 1.1.6 -> 1.1.7
- org.apache.commons:commons-compress: 1.26.2 -> 1.27.0
- org.tukaani:xz: 1.9 -> 1.10 (PD -> 0BSD)
- org.webjars.npm:tag2link: 2024.7.8 -> 2024.8.12
tools/ivy.xml
- net.sourceforge.pmd:pmd: 7.3.0 -> 7.4.0
- com.google.errorprone:error_prone: 2.29.2 -> 2.30.0
|
|
|
@19190
|
4 months |
stoecker |
|
|
Java 11 Windows is a bit slow
|
|
|
@19189
|
4 months |
stoecker |
|
|
nitpicking software...
|
|
|
@19188
|
4 months |
stoecker |
|
|
Uih, MacOs precision is worse
|
|
|
@19187
|
4 months |
taylor.smock |
|
|
Remove/fix unused icons
rocket.svg was only used for getting people to update from WebStart to
OpenWebStart. Since we no longer support Oracle WebStart, we can remove
rocket.svg.
|
|
|
@19186
|
4 months |
stoecker |
|
|
fix debug
|
|
|
@19185
|
4 months |
stoecker |
|
|
output the ULP factor in case of an error
|
|
|
@19184
|
4 months |
taylor.smock |
|
|
Fix EnumSet instantiation error
|
|
|
@19183
|
4 months |
taylor.smock |
|
|
Fix #22852: Add missing area rendering for emergency=lifeguard
|
|
|
@19182
|
4 months |
stoecker |
|
|
reduce test threshold to get MacOS working
|
|
|
@19181
|
4 months |
stoecker |
|
|
PMD fixes
|
|
|
@19180
|
4 months |
taylor.smock |
|
|
Fix some coverity issues
|
|
|
@19179
|
4 months |
taylor.smock |
|
|
Fix #23802: Backup preferences files get overwritten by bad preference files
This validates a preferences file before copying/moving it to another file.
This should avoid cases where a file is partially written and then copied or
moved over a "good" preferences file.
|
|
|
@19178
|
4 months |
taylor.smock |
|
|
Add/ignore documented popular tags
Add
|
|
|
@19177
|
4 months |
stoecker |
|
|
fix #23849 - provide option to reduce loglevel to warnings
|
|
|
@19176
|
4 months |
taylor.smock |
|
|
Fix #11487: Have josm render data to tiles
This adds a new rendering method that renders async. This avoids blocking the UI.
Where this is useful:
- Large datasets (think county or country level)
Where this is not useful:
- Micromapping -- the tiles aren't being rendered exactly where they should
be and there are some minor rendering artifacts.
Known issues:
- Some tiles aren't exactly where they should be (off by a pixel or two -- by
default, we use the old render method at z16+)
- Rendering of tiles is slow -- there is some prework done to render tiles
in batches. The primary reason rendering is slow is we are effectively
rendering 25 total tiles (to avoid movement of text, we render 2 tiles in each
directory and only keep the middle one)
- Due to the above speed issue, hovering over an object will cause the highlight
to render in slowly.
New advanced preferences:
mappaint.fast_render.tile_size -- controls the number of pixels in a tile
mappaint.fast_render.zlevel -- controls the maximum z level at which tiles
are generated
|
|
|
@19175
|
4 months |
taylor.smock |
|
|
Fix #23846: Setting all referrers downloaded doesn't happen if the target object has been modified
This may also fix (or partially fix) #23808 and #23810.
|
|
|
@19174
|
4 months |
taylor.smock |
|
|
Add javafx to ignore list for API check (ant check-plugins )
javafx is expected to be provided by the installed Java distribution, be it our
installers, one provided by OpenWebStart, or installed by the user.
|
|
|
@19173
|
4 months |
taylor.smock |
|
|
Add/ignore documented popular tags
Add
|
|
|
@19172
|
4 months |
taylor.smock |
|
|
Fix #23290: Use checks in checkgroups when looking for out-of-region tags
Also fix an i18n issue and update a test to use a key that is currently invalid
in a region.
|
|
|
@19171
|
4 months |
taylor.smock |
|
|
Remove some values from ignoretags.cfg
|
|
|