[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The vae tc loss #11

Open
cuicanyu opened this issue Jun 28, 2019 · 1 comment
Open

The vae tc loss #11

cuicanyu opened this issue Jun 28, 2019 · 1 comment

Comments

@cuicanyu
Copy link

HI, Thanks your code, its very useful.
I notice that the tc_vae_loss in solver.py. It could be a negative number, and this is unusual for loss functions.
@erobic
Copy link
erobic commented Mar 21, 2020

You might have already found the answer to this, but for future reference, vae_tc_loss as defined in this repo: vae_tc_loss = (D_z[:, :1] - D_z[:, 1:]).mean() is equivalent to FactorVAE's formulation in paper (see: https://github.com/paruby/FactorVAE/blob/b0ba3466e39ebd56d84db7a039ed39421aa1b21f/factor_vae.py#L151 (lines 151-156). That is, it can be negative by paper's definition as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erobic @cuicanyu