[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker websocket API doesn't like JSON strings with unicode escaping #3989

Open
simeonmiteff opened this issue Oct 24, 2024 · 2 comments
Open

Broker websocket API doesn't like JSON strings with unicode escaping #3989

simeonmiteff opened this issue Oct 24, 2024 · 2 comments
Assignees
@Neverlord

Comments

@simeonmiteff
Copy link

I encountered this while trying to send a string with HTML entities in it (e.g., <ohai>), and discovering that my JSON library (un?) helpfully escapes them as follows:

{"@data-type":"string","data":"\u003cohai\u003e"}

I will patch https://github.com/corelight/go-zeek-broker-ws to turn off the HTML entity escaping feature and avoid this problem (I don't think we care about crappy browser security issues, and broker/CAF is happy to deserialise the string with HTML entities), but not handling escaped characters is probably a bug worth fixing.
@simeonmiteff simeonmiteff mentioned this issue Oct 24, 2024
Merged
@Neverlord Neverlord self-assigned this Oct 24, 2024
@Neverlord
Copy link
Member

not handling escaped characters is probably a bug worth fixing

Absolutely. We actually already have someone working on this (actor-framework/actor-framework#1949), so I'll take care that the fix finds its way to Broker/Zeek.

@simeonmiteff
Copy link
Author

Much appreciated @Neverlord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neverlord Neverlord

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Neverlord @simeonmiteff