vp9.2 vcodec format sort bug fix #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with real vp9.2 vcodec format in sorting and parsing
bashonly
approved these changes
Sep 27, 2024
Grub4K
approved these changes
Sep 27, 2024
|
Thanks, esp for adding comprehensive tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
The actual
vcodecvalues for vp9 are likevp09.00.10.08vp09.02.11.10.01.09.18.09.00The existing situation:
FormatSorterhandlesvcodecas anordered, with separate entries for vp9.2 and general vp9.In practice vp9.2 is probably used because it has hdr support but sometimes vp9 with hdr is not supported for hardware decode when basic sdr vp9 is, for instance in nvdec with some nvidia cards (https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new) so they are distinguished as different categories of vcodec value for sorting. Great.
However the regex
FormatSorteruses for vp9.2 does not match the actualvcodecvalues seen for it -- it does not match the leading0of the02-- so it is treated as just another regular vp9.This is separate from the
utilsparse_codecs()code which assignsvp9.2a higherdynamic_range, and already parses the actualvcodecvalue for vp9.2 correctly.This PR includes:
FormatSorterparse_codecs()works okTemplate
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?