[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ie/huya:video] Add extractor #10686

Merged
merged 7 commits into from
Sep 13, 2024
Merged

[ie/huya:video] Add extractor #10686

merged 7 commits into from
Sep 13, 2024

Conversation

hugepower
Copy link
Contributor
@hugepower hugepower commented Aug 7, 2024 •
edited
Loading

Description of your pull request and other information

This PR adds a new extractor HuyaVideoIE in huya.py to handle "moment" videos.

Fixes #10679

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-request Request to support a new website label Aug 8, 2024
seproDev
seproDev requested changes Sep 8, 2024
View reviewed changes
Copy link
Member
@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to review this PR

yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Sep 8, 2024
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Sep 8, 2024
@seproDev seproDev changed the title [ie/huya] Add extractor (fixes #10679) [ie/HuyaVideo] Add extractor Sep 8, 2024
bashonly
bashonly approved these changes Sep 10, 2024
View reviewed changes
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label Sep 10, 2024
@hugepower @bashonly
Update yt_dlp/extractor/huya.py
6baaea0 
Update regex to support both HTTP and HTTPS.

Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly self-assigned this Sep 13, 2024
bashonly
bashonly reviewed Sep 13, 2024
View reviewed changes
yt_dlp/extractor/huya.py Outdated Show resolved Hide resolved
@bashonly bashonly changed the title [ie/HuyaVideo] Add extractor [ie/huya:video] Add extractor Sep 13, 2024
@bashonly bashonly merged commit 25c1cda into yt-dlp:master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashonly bashonly bashonly approved these changes

@seproDev seproDev seproDev approved these changes

Assignees

@bashonly bashonly

Labels
site-request Request to support a new website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[huya] Add support for "moment" videos
3 participants
@hugepower @seproDev @bashonly