-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialRatio issue #88
Comments
why does this and this return as 100 percent matched? |
The correct result would be 74, so a result of 100 would be a bug. |
so it's wrong right? |
In rapidfuzz I implement this metric using a sliding window approach, which skips comparisons only if it is really sure they can not occur. When searching for long needles (> 64 characters) this is slower than the approach using get matching blocks. However it is the only way I am aware of, that is guaranteed to return the correct alignment. The current implementation has the following issues:
Especially the second issue is a fundamental flaw in the way this algorithm currently works. |
This is essentially reopening issue #39, since the introduced fix does not solve the problem, but just makes it work for this explicit example.
E.g.
should return the score 100.
This worked until #80, but returns the score 50 after reordering the cases
The text was updated successfully, but these errors were encountered: