[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFSU] Quit and Enter button assignments do not work on Gamepad #23

Open
AbbieDoobie opened this issue Feb 8, 2023 · 3 comments
Open

[NFSU] Quit and Enter button assignments do not work on Gamepad #23

AbbieDoobie opened this issue Feb 8, 2023 · 3 comments

Comments

@AbbieDoobie
Copy link

The following inputs don't seem to work on Gamepad.

  1. Quit ("Q" on KB): This should be the Back/Select/View button when at the Main Menu, but nothing happens when pressed.
    JOY_EVENT_FENG_QUIT = Q
    JOY_EVENT_FENG_QUIT = XINPUT_GAMEPAD_BACK

  2. Enter ("Enter" on KB): In specific circumstances, such as when entering text, pressing the Start/Menu or A button should act as Enter but it doesn't. EX: When trying to Save, if I select a slot it waits for me to enter text. If I enter something with the KB and then press the Start/Menu or A button, nothing happens. I still have to press Enter on KB.
    JOY_EVENT_MENU_SELECT = VK_RETURN
    JOY_EVENT_FENG_SELECT = VK_RETURN
    JOY_EVENT_MENU_SELECT = XINPUT_GAMEPAD_A
    JOY_EVENT_FENG_SELECT = XINPUT_GAMEPAD_A

Issue (2) isn't as important as (1), but if we could Save without having to enter text that would mean we never need a KB at all in game, which is great for a controller only setup. Profile creation would be the one exception, but that's a one time thing.
@AbbieDoobie
Copy link
Author

Apologies, I do see Quit is hardcoded per EventReference doc, and I imagine Enter might be as well. Feel free to close this out if both are expected.

Note from the doc: "NOTE: some events (such as quitting with Q key or launching the tutorial video with LT) are hardcoded due to the way they're coded in the game"

@xan1242
Copy link
Owner
xan1242 commented Feb 8, 2023

OK so...

Yes, 'Q' for quitting is hardcoded, however, I probably should make that remappable...

As for text inputs - these aren't something I had focused on either. That will be done at a later point when I start re-implementing the FE keyboard that's in the game already, but disabled.

"Enter" as in "accept" aren't hardcoded anywhere. What you set on JOY_EVENT_MENU_SELECT and JOY_EVENT_FENG_SELECT are what they you set them to.

@AbbieDoobie
Copy link
Author

The Accept key does work throughout the rest of the menus, I just noticed on text entry it doesn't accept, that's the only exception. I imagine that's a whole different can of worms though since that is part of text input like you mentioned.

I am using this in my living room setup, which is gamepad only, and it's 99% there. I just have to force kill the game when I want to exit with Big Picture or Launchbox, and rely on Autosave for saving which hasn't failed me yet. Thank you for getting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xan1242 @AbbieDoobie