[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java unit testing can fail when upgrading project #589

Open
OccultSlolem opened this issue Feb 3, 2022 · 3 comments
Open

Java unit testing can fail when upgrading project #589

OccultSlolem opened this issue Feb 3, 2022 · 3 comments

Comments

@OccultSlolem
Copy link

Describe the bug
Unit tests that passed with no problems in 2022.2.1 run into runtime errors in 2022.3.1. The exit code is 137 - a cursory glance of Stack Overflow appears to signify a memory problem. My 2020 Intel i5 MacBook Pro had at least 4 GB of RAM free when running these tests.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade to WPIlib 2022.3.1
  2. Attempt to run tests

Expected behavior
The tests should run successfully.

Screenshots
This video shows the tests passing on 2022.2.1, but failing on 2022.3.1 with no changes to the tests themselves:
https://sfsu.app.box.com/file/914364236999?s=93syty80quyeqtd58nc1t3qluy36phlt

Desktop (please complete the following information):

  • WPILib Version: 2022.3.1
  • OS: macOS Monterey 12.1
  • Java version 15.0.1
@OccultSlolem
Copy link
Author

Ok, I was working with thadhouse and Peter on Discord and in this process it all of the sudden started working for all of us without any clear reason why 👀 👀

@OccultSlolem
Copy link
Author

Ok, found a more consistent way to cause this error:

1.) Switch version between 2022.2.1 and 2022.3.1
2.) Observe with terror as your unit tests fail with a 137 exit code
3.) Run a ./gradlew clean
4.) Run the tests again and smile with glee as they pass

Thanks to thadhouse on Discord for your help with this! :)

@ThadHouse ThadHouse transferred this issue from wpilibsuite/allwpilib Feb 4, 2022
@ThadHouse ThadHouse changed the title WPIlib 2022.3.1 breaks unit testing Java unit testing can fail when upgrading project Feb 4, 2022
@ThadHouse
Copy link
Member

I renamed the issue, and transferred it to the correct repo. I wasn't able to reproduce this on Windows, was only able to reproduce it on macOS. I'm not entirely convinced its not a gatekeeper issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThadHouse @OccultSlolem