Remove hardcoded references to branch in provision playbooks #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
Rebits
requested changes
Jun 27, 2024
There was a problem hiding this comment.
There are still hardcoded references in the QA provisioning methods:
Please review all hardcoded references and implement one of the following approaches:
- Remove unnecessary repository installation tasks that rely on variables with default hardcoded versions (since the E2E pipeline exclusively uses custom packages).
- Replace hardcoded versions with a new parameter.
juliamagan
requested changes
Jun 28, 2024
Co-authored-by: Julia Magán <80041853+juliamagan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing/Related Issue
Closes #5509
Description
Removal of the hardcoded references to branch in provision playbooks for E2E tests.
Tasks