-
-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icon Request] NGRX Icons #1069
Comments
I'm afraid, but somewhat like |
@robertohuertasm needs to have a look at this. I suspect it's something similar to the |
.state.ts would handle the majority, as well as .reducer.ts but some people use rootReducer.ts and rootState.ts etc. and some even use the index.ts in a reducer folder as the root state. Obviously nothing to be done there. |
This has been something that have crossed my mind several times but, honestly, I didn't find it so valuable as to bring it into the table. Although these But, as I said, I have many doubts about the benefit of implementing these icons:
As a final reminder to @Kaffiend, I guess you already know that we provide the option to customize the file associations. |
I forgot to comment that when #933 is delivered you will be able to add your custom icons into the same repo or even a shared location making it easy to share your custom icons with your team. |
Technically |
I think we can do that... But it's a huge job to get this done and this would introduce a lot of testing, while most of the users don't actually want this... We have around 2.5 million downloads and only one request. Okay, when we get this done, and I'm really looking forward to see this working, I'm absolutely fine. I think this would be a big surprise and would add another value to this project. :) |
Here is an image edit: @robertohuertasm regarding the folder structure with the |
@Kaffiend Technically we can support |
@Kaffiend, obviously I use Anyway, I agree with @JimiC in postponing this discussion after summer. We're all really busy aside from the project and this is not a priority issue. |
Anything I can help on this issue? Update: I made some NGRX icons based on this request on material-icons and using this color palette as guideline. You can check them at my branch here. Hopefully, we will make this work with PAD but I should better wait for V9 to be released in order to do these changes. @JimiC @robertohuertasm Thoughts? |
Any news on this, since Material-Icons provided an example/solution for this (as per @KingDarBoja comment)? |
Sorry @georgeat8 the project is in low maintenance mode and this would still required to code the PAD functionality. Not sure when we'll have bandwidth for this. |
- Type:
extension
- Icon Name:
ngrx
- Sample original Icon: url
- Extensions:
.state .*state, .actions, .reducer, .*reducer, .effects
could conflict with redux icons, if any. only applies to angular icons.
The text was updated successfully, but these errors were encountered: