implement middleware chains #828
Labels
enhancement
New feature or request
Comments
|
@sansyrox Is someone working on this? If not, I'd like to take this up. Middleware chains are essential for making Robyn more suitable for mainstream production scenarios |
|
As I understand, rn the limitation stems from table.write().unwrap().insert(route.to_string(), function)?;where the matchit router map for "before/after" request type allows for only one key and panics on duplicate registration. That's the case of route middlewares, but is handled in case of global middlewares which has a for before_middleware in before_middlewares {
request = match execute_middleware_function(&request, &before_middleware).await {
Ok(MiddlewareReturn::Request(r)) => r,
Ok(MiddlewareReturn::Response(r)) => {
// If a before middleware returns a response, we abort the request and return the response
return r;
}
Err(e) => {
error!(
"Error while executing before middleware function for endpoint `{}`: {}",
req.uri().path(),
get_traceback(e.downcast_ref::<PyErr>().unwrap())
);
return Response::internal_server_error(None);
}
};
}Speaking of which, I couldn't find documentation on how to add global middlewares from python... the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: