Multierror: join errors at the end #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 12 12
Lines 441 441
=======================================
Hits 438 438
Misses 3 3 ☔ View full report in Codecov by Sentry. |
eseliger
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
MapErrso that it does not create recursivejoinErrors. By repeatedly callingerrors.Join(, we create a nested set ofjoinErrors rather than a single, flatjoinError. Then, whenError()is called, it allocates a new string for each nested error becausejoinErrorcallsError()recursively on each of its children.Instead, this PR updates
MapErrto just collect a slice of errors and return the flat joined error.