[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo plugin #934

Open
brownbl1 opened this issue Sep 22, 2021 · 4 comments
Open

undo plugin #934

brownbl1 opened this issue Sep 22, 2021 · 4 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement triage: accepted version-2 Version 2.X.X wontfix

Comments

@brownbl1
Copy link
Contributor
brownbl1 commented Sep 22, 2021 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

I'm creating this issue to track progress on the undo plugin more publicly.

All of it is subject to change at this point, but I think the main things we need to hash out first is the following:

  • something similar to ExtraModelsFromLoading to automatically add StateWithHistory<State> to models that are selected by the plugin
  • if possible, automatically add actions for models that are selected by the plugin such as dispatch.count.undo

The first is the biggest priority. @tianzhich if you have any input on the typescript stuff for the first bullet, I would appreciate it.

@semoal Thanks for your help so far!

IssueHunt Summary

Backers (Total: $20.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips
@brownbl1
Copy link
Contributor Author

I've made some progress on this but definitely need some help at this point. As I mentioned in the discord chat:

  • can't seem to find a way to restrict input based on extracting model names from RootModel.
  • not sure if I'm getting all of the type inference stuff working optimally, but what I have so far is a start

https://codesandbox.io/s/undo-plugin-proto-itlpn?file=/src/store/undoPlugin.ts
https://codesandbox.io/s/undo-plugin-proto-itlpn?file=/src/store/index.ts:362-430 <-- would be good to focus on this

@tianzhich
Copy link
Collaborator
tianzhich commented Sep 28, 2021 •
edited
Loading

Hi, @brownbl1 thanks for contributing. I'll have a look if I'm free.

@issuehunt-oss
Copy link
issuehunt-oss bot commented Oct 24, 2021

@semoal has funded $20.00 to this issue.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 24, 2021
@stale
Copy link
stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement triage: accepted version-2 Version 2.X.X wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brownbl1 @semoal @tianzhich