Provide provider_job_id to qu adapter. #20064
Conversation
|
Don't forget the CHANGELOG |
|
@rafaelfranca - thanks! Just updated it. |
Further work to provide provider_job_id for queue adapters.
|
Tests seems to be broken. |
|
It's not displaying the travis errors for me, do you have a link? It was broken until about 20 minutes ago - is it still now? I had to add the "unless qu_job.nil?" because of the different backends. |
|
@rafaelfranca any idea how to proceed? Both the regular and integration tests are passing for me, so I don't exactly know what to do. Thanks. |
|
Thanks @matthewd - looks like it's good now. |
|
|
||
| test 'should supply a provider_job_id when available for delayed jobs' do | ||
| skip unless adapter_is?(:delayed_job, :sidekiq, :que) |
There was a problem hiding this comment.
I think you forgot to add the provider_job_id for qu in the enqueed_at method.
There was a problem hiding this comment.
Yeah qu doesn't support scheduled jobs, so I didn't include that in the test.
There was a problem hiding this comment.
Ah sorry, I only saw the first line of def enqueue_at(job, timestamp, *args) #:nodoc: did not read the full method body.
Provide provider_job_id to qu adapter.
Further work to provide provider_job_id for queue adapters.