Add an option end to find_in_batches
#12257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! At least, we should update the "Active Record Query Interface" guide, what do you think ? |
|
@robin850 I am waiting for this to be approved, before changing the Guides. |
| @@ -96,6 +96,15 @@ def test_find_in_batches_should_start_from_the_start_option | |||
| end | |||
| end | |||
|
|
|||
| def test_find_in_batches_should_end_at_the_end_option | |||
| assert_queries(6) do | |||
| Post.find_in_batches(:batch_size => 1, :end => 5) do |batch| | |||
There was a problem hiding this comment.
@vipulnsward what about 1.9 hash style?
|
Seems good. Could you update the guides now? |
|
Also needs to update |
449e12b
to
8809bbd
Compare
|
@rafaelfranca updated and added documentation for new parameter. |
|
You could also consider calling it stop. Usually end goes with begin and stop goes with start. |
|
stop doesn't sound good to me. Consider this sentence - |
| enum_for(:find_each, start: start, batch_size: batch_size, end_at: end_at) do | ||
| relation = self | ||
| if start || end_at | ||
| relation = relation.where(table[primary_key].gteq(start)) if start |
There was a problem hiding this comment.
I think we can extract this code to a private method. It is duplicated in three places
|
Renaming |
|
Okay, |
|
👍 |
8809bbd
to
e1c20b5
Compare
|
@rafaelfranca done. Its much cleaner now |
| @@ -28,10 +28,11 @@ module Batches | |||
| # ==== Options | |||
| # * <tt>:batch_size</tt> - Specifies the size of the batch. Default to 1000. | |||
| # * <tt>:start</tt> - Specifies the primary key value to start from. | |||
| # * <tt>:end_at</tt> - Specifies the ending point for the batch processing. | |||
There was a problem hiding this comment.
Rhetorically: What does an ending point mean? Let's clarify by mimicking the line above.
"Specifies the primary key value to end at."
There was a problem hiding this comment.
Less rhetorically: I just read all the API doc changes, and @kaspth's proposed alternate spelling, and was still unclear on whether it was inclusive or exclusive. I suggest we make that very explicit.
For that matter... have we considered and dismissed the idea of a :range option instead?
There was a problem hiding this comment.
👍 on removing the ambiguity.
No, we haven't discussed a range option. Off the top of my head that sounds less clear re. inclusive/exclusive.
There was a problem hiding this comment.
Actually, I'd be 👎 on having a range option. We can't really change the start option. So the end option is a nice compliment, whereas the range plus start-end seems excessive.
154d2a5
to
06397eb
Compare
|
Updated. How does this look? |
| records.each { |record| yield record } | ||
| end | ||
| else | ||
| enum_for(:find_each, start: start, batch_size: batch_size) do | ||
| start ? where(table[primary_key].gteq(start)).size : size | ||
| enum_for(:find_each, start: start, batch_size: batch_size, end_at: end_at) do |
There was a problem hiding this comment.
Let's insert end_at before batch_size as above for consistency (it's nice that start and end is together) 😄
|
Some very minor things and then it LGTM. Thanks, Vipul ❤️ |
that complements the `start`parameter to specify where to stop batch processing
06397eb
to
3dc4320
Compare
|
Thanks @kaspth . Updated again. |
rafaelfranca
added a commit
that referenced
this pull request
Feb 10, 2015
Add an option `end` to `find_in_batches`
|
I'd like to bring parity to the options. Either it's start/stop or begin_at/end_at. But mixing the language like now isn't great. I think it's fine to do a deprecation on start to go with begin_at/end_at. We don't want a mixed language wart sitting in the code base forever. |
|
@dhh got it. Will send a PR to take care of this. |
|
In my head |
|
@bogdan My first thought was "what are the dates doing in find_in_batches" as well |
|
I agree that the Maybe |
|
We can also use start/finish. Neither of those are keywords. And agree with the _at implication of date.
|
|
If it looks good to everyone, I l change it back to |
|
@vipulnsward Rock our worlds from start to finish 🤘 |
vipulnsward
added a commit
to vipulnsward/rails
that referenced
this pull request
Jan 18, 2016
…sh instead of start_at/end_at based on comments at rails#12257 (comment)
siman-man
added a commit
to yasslab/railsguides.jp
that referenced
this pull request
May 10, 2017
526fa1e63d Should escape meta characters in regexp
d1106d8307 Merge pull request #28337 from riseshia/patch-1
2ceb8643d0 Use target language's document.yaml [ci skip]
f999328309 Rails secrets is not built on but inspired by Sekrets
a21ebc6161 Update the Gem Bug Report Templates to 5.1.0
8324fe0ecf Fix note about `secrets.yml` [ci skip]
7007ff1d34 Remove entries included in 5.0 [ci skip]
c362be8a47 5.1 Release Notes are complete [ci skip]
8f0d62f3c5 Small grammar fix
7c2ebbc352 Small grammar fix
55c2e4b6fd Small grammar fixes
222e49b317 Fix indentation [ci skip]
f931d5b3d8 Added some more release notes for Active Record [ci skip]
959c51e5fe Merge pull request #28904 from robin850/update-working-with-javascript
4ad6eede7d Add documentation of data attributes for UJS [ci skip]
348475b475 Nest Action View remote helpers one level deeper [ci skip]
f2a01da5ef Add a section with the different Ajax events [ci skip]
f961ae5357 Update the JavaScript guide to use `form_with`
2987e0f224 Pluralize methods
caec4d320d More release notes for Rails 5.1 [ci skip]
e6cec91e57 Add some items to the release notes [ci skip]
da547043bc Some improvements in the 5.1 release notes [ci skip]
71822f593f s/broadcasing/broadcasting/
2241c26462 Describe the changes in transactional tests
3c5c5310ef Add missing `action_view` section of config flag
9c4525285e Merge pull request #28861 from koic/unify_names_of_github
6ceda62ab0 Unify the name of GitHub [ci skip]
ad7dfbb3d0 Merge pull request #28860 from y-yagi/add_form_with_generates_remote_forms_to_configuring_guide
99311e0377 Add `form_with_generates_remote_forms` to configuring guide [ci skip]
d598df79da secrets.yml --> config/secrets.yml
3464409aa7 Add Action View info to 5.1 release notes
5c9d285399 Use parameters, not params
3b1d0e403d Small grammar fixes
bfa9661b2d Remove unused heading
3a85acc090 Add more Railties notable changes
19ee2bb4e4 Add Railties info to 5.1 release notes
3fb2d2c118 Add Active Model info to 5.1 release notes
26368b1951 Remove unused headings
8a91aef302 Finish Action Cable section in release notes
1b1259aa3f Finish Action Mailer section in release notes
b95e67ff75 Add Active Job info to 5.1 release notes
07f52d3225 [ci_skip] Fix typo in Rails 5.1 upgrade notes
2c0f3e0dbb Add note about #26929 in the upgrade guide
19d9350af2 Merge pull request #28432 from marksiemers/master
13d016023b Fix all style guides violations
b0989efe6d Reword sentence
ee9c7b585a Merge branch 'master' of github.com:rails/docrails
59c39412cf [ci skip] Changed plain text to NOTE.
135a20754c Remove datetime fields from helper list [ci skip]
c85c41f17f Small docs fix
56e0d94479 Add missing word 'to' [ci skip]
9dac80cd9d Small grammar fix
f8147bee6d Small grammar fixes
77ce79e4d8 Revert parts of cad58fb
407d3ac227 Merge pull request #28709 from prathamesh-sonpatki/release-notes-1
8bb291091b :scissors:
ed30db5df9 Merge pull request #28402 from jules2689/action-controller-api-base-hooks
40baa9361d Update routing doc on the `get` `to:` option [ci skip]
2be19e031c Add Documentation for Active Support On Load Hooks
42c52cb8a0 Remove link to rack.github.io
0d53b3c1d9 Small grammar fixes
f7d84b4a09 Pluralize callback
5eea36918b Merge pull request #28680 from vishalzambre/callback_doc_update
1e090522b1 [ci skip] documented issue related before_destroy
6da10a1f37 Started adding release notes for Rails 5.1 [ci skip]
a8294ed590 Add text to "Upgrading to Rails 5.1"
cc2267eb5e Add scaffolding for different sections in 5.1 release notes
4fdc18cb77 Drop the "Sanity Check" contributing step
23f36a4317 Remove mentions and instructions for docrails
02d9dd640c [ci skip] Change ++ by markdown quotes
e0f2e7c56a Fix Guides to include #23138 [ci skip]
bed0aab7a6 Fix edge guides for Active Record callbacks
472785880c Don't highlight code in anchorlink [ci skip]
725a9d3d03 Downplay links in Guides headers
cc12f7955d Merge pull request #28641 from diazruy/anchors
9fa76afa57 Add anchor links to all headers
a9781f5b2c Add default_scope note to AR guide [ci skip]
e1f8a91536 Small grammar fix
de4f73d648 Small grammar fix
3b57045939 Merge pull request #28595 from 3wille/fw-after-action-hint
99c6e7d1a2 Fix link to rails-ujs
b98fa16753 add hint on after_action filters
14e19e8124 Small grammar fix
57a097d3d2 Small grammar fix
80027c521d Update middleware list
30b0ccb99e Upgrade various Rails 5.0 references to 5.1
197224788b Add WIP Rails 5.1 release notes to documents.yaml
37a1aa8fd6 Rename local variable name `current_user` to `verified_user` [ci skip]
83b6aae2c8 Merge branch 'master' of github.com:rails/docrails
334c36902c Doc cleanup for caching guide [ci skip] (#28556)
cb1726c4d4 Merge pull request #28550 from rachel-carvalho/update_browser_compatibility_for_http_verbs
b809a533c7 update guide to reflect browser compatibility for HTTP verbs [ci skip]
230d0afc1b Additional explanation about cache implementations
be783efdf8 Update bug report templates
2a0dfae0ae Start Rails 5.2 development
0716a9e87a Update Configuring Rails Component guide example
fed48e15bf Fix typo in Caching with Rails Guide [skip ci]
158be02121 Update the maintenance policy [ci skip]
234c185f0b Merge pull request #28477 from spdawson/patch-3
029a22cdd3 Remove stray back-end from ActiveJob Basics guide
71ef9e78be Minor grammar fixes for Rails 5.1 release notes
c78f2dcd27 Update some jquery-ujs references to rails-ujs
577607b46a Add link to rails-ujs/dropping jQuery PR
71d4a52d05 Add link to Webpack/Webpacker PR
38608458d8 Second pass on 5.1 release notes
3b1df5881d First pass on 5.1 release notes
05d7c21bc8 Improve Caching with Rails Guides [ci skip]
4217054d2a Fix resolve usage in the release notes
24b6c36a30 Merge pull request #28096 from prathamesh-sonpatki/5-1-release-notes-first-draft
ceb3316644 Merge pull request #28318 from bogdanvlviv/remove-ability-update-locking_column-value
03027d4824 Merge pull request #28421 from tangposmarvin/docs-assest-pipeline
fe1b9d31c2 Fix asset_pipeline docs incorrect image dir info
d9b9f8df91 Remove ability update locking_column value
bed7abd997 Update 'Building Complex Forms' with `inverse_of`
996feb2138 Remove unused `@txn` variable
18e45ba172 Remove obsolete warning about regular expression
36b1b1a5a5 Add blurbs about each new feature [ci skip]
4343ce533e Fix weird documentation line
94847e6c89 Second editing pass on "Active Model Basics" guide
c809da3fac First editing pass on "Active Model Basics" guide
eb6e4cbb20 Add link to mentioned API [ci skip] (#28392)
2aecaffee8 Merge pull request #27152 from tjai89/patch-5
78c18d22db Fix typo in the security guide
4db846cb95 Improve readability of testing guide [ci skip]
3b468772dc Edits to Systems testing section [ci skip]
524331a48c force UTF-8 as external encoding in guides generation [ci skip]
95f69e4022 Fix to use correct path with language on guide
42328a667e Merge pull request #28289 from maicher/master
0975431538 Remove `:on` option that does ot exist [ci skip]
dbd3f0d8a6 Improve foreign key description in guides [ci skip]
476f60c567 Merge pull request #28286 from robin850/skip-system-tests-by-default
495bd2de50 Avoid running system tests by default
6d37361a37 Merge branch 'master' of github.com:rails/docrails
e501d77434 Merge pull request #28284 from y-yagi/fix_system_test_example
2b25a3de2f Fx system test example [ci skip]
c65a855dfb Escapes and edits to configuring guide [ci skip] (#28280)
3ebd6ed5c3 Fix generated query in Retrieving specific data from multiple tables section [ci skip]
a6e7273520 Merge pull request #28265 from 0oneo/association_guide
8ff4127261 Fix spelling
c8a11c6e69 passing unique parameter to belongs_to wrongly
895df77712 Fix typo in Upgrading Ruby on Rails Guide [skip ci]
e6e859fbfe Add PR links for major features [ci skip]
46821f42b0 Add first draft of release notes for Rails 5.1 :tada:
436036deba fixed suspected typo in sample sql query
0929a3719f Improve documentation for Testing Your Mailers [ci skip]
c32b151e6a Update i18n guide to cover :zero key support in pluralization [ci skip]
549b3842d3 Use released arel
f0b772d941 Soft-deprecate the top-level HashWithIndifferentAccess class
6e1026c53b Fix w3c_validator.rb validation script
bf1ceeedbd Preparing for 5.1.0.beta1 release
c9d024cd54 remove needless extension from system test example [ci skip]
afa8cd2a8b [doc] Fix wrong class name in testing.md
b2f8146bba Use released arel
ca5e2a999b Tiny documentation edits [ci skip]
06b4626b14 Fix some grammar in docs [ci skip]
865fd1723e Clean up documentation
426ae56adf Rename system_test_helper -> application_system_test_case
0f5d276185 Move and rename system tests
97864d49e8 Update documentation and guides
3b2bdffc26 Add guides for system testing
edf81dc78c [ci skip] Update Guides to use macOS instead of Mac OS X
c25d6a280f Merge pull request #28058 from y-yagi/follow_up_to_27608
0f8249e2a0 Remove deprecate passing string to `:if` and `:unless` conditional options [ci skip]
a3ea2a18e5 Change engines guide to demonstrate maintained forum
f26e13574f Fix typo in I18n Guide [ci skip]
ce531e1216 document link processing in guides generation [ci skip]
a3281a3287 refactors and fixes in guides generation [ci skip]
9401f58e44 [ci skip] Fully qualify missing template error.
7b1b1c0362 Merge pull request #27870 from kenta-s/get-todo-done-in-render_test
b296419170 Fix rubocop violations
cc4fb170eb Update configuration guide about ActiveRecord's config option.
58dffd3c11 Merge pull request #27954 from maclover7/jm-fix-26404
47ac2b6dae Add note about breakage in file uploads in controller tests to upgrading guide
d5496c1f06 Fix wording
c509953e2e remove `ActiveSupport.halt_callback_chains_on_return_false` from everywhere
70767472d3 remove link to edgeapi [ci skip]
851a9f1838 Merge pull request #27232 from robin850/guides-linking
322fc9673a Automatically link to Ruby files referenced in notes [ci skip]
e47761d1da Automatically inject the current Rails version in API links [ci skip]
cf950c160d Add information on `:formats` option in action_view_overview.md
87f8d2d6bb Fix typo in guide: _articles should be _article
401d5109f3 Added warning for reserved YAML keywords.
ed84890d6b Fix judgement spelling [ci skip]
d7bf2855fe Bump bug report template versions to 5.0.1
6798612957 Action Mailer Basics clean up [ci skip]
442cb724d3 Clean up wording in Action Mailer Basics [ci skip]
e2344505e9 Mention ActiveRecord's config.example.yml
e938069f7f Various style + grammar fixes for #27719
059592dafb update links of pluralization in i18n guide
38ce55242a Update ActionCable guide to better describe SubscriptionAdapter configuration.
563307b3c7 allow to pass describe option to rake
37462ea15a Revert "Merge pull request #27686 from koic/friendly_bigdecimal_inspect"
7797445c84 Several representation of BigDecimal has changed in Ruby 2.4.0+ [ci skip]
15dc4fa693 Add duration constructors for use in Numeric extensions
57463e2e22 Merge pull request #27610 from Envek/fix_and_speed_up_duration_parsing
649e52d67f Fix inconsistent results when parsing large durations and constructing durations from code
f53d2d1d1b Add missing release notes entry for https://github.com/rails/rails/commit/f02a35b86efea24f1e2ab684bc8081ced5eb3b1a [ci skip]
983452d3e7 Merge pull request #25427 from eugeneius/update_increment_documentation
f589899792 Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail-body
8d726aa969 Fix typo in asset_pipeline.md [ci skip]
ebe8ef715c Merge pull request #27446 from zachahn/asset-hash-md5-to-sha256
30b37e2e2b Merge pull request #27552 from jarijokinen/fix-default-locale-code-example
b010751c30 Add instructions for available_locales [skip ci]
20735f94d0 Clarify Bi-directional Associations docs
025f7d80af Update schema cache doc in guides/command_line
8289ad0ca7 Remove deprecated support to passing a column to #quote
55dbc541c4 [ci skip] Rejigger the dublicable? wording a bit.
9564e28fc9 Merge pull request #27346 from utilum/core_ext_guide_duplicable
f7f94cdf4b Use proper output format [ci skip] (#27498)
2453b4e2b3 Revert "Revert "Merge pull request #17943 from jeremywadsack/doc_cache_importability""
f0cf44192c Fix Rubocop violations and fix documentation visibility
03da25606f public methods can be placed after private ones if you want to
046b33a205 Abuse of protected in guides
db9ba938cd Update asset fingerprinting information
ff6b50ced3 Update list of `duplicable?` objects in AS core_ext guide [ci skip]
93189b174b fix typo in getting_started [ci skip] (#27423)
6f410636d9 [ci skip] Update initialization guide samples.
c2f8222a7d Merge pull request #27365 from baweaver/patch-1
579cad0e06 Fix rake guides:generate:kindle error
f66592a583 How to disable scaffolds.scss in generators.md (#27383)
c5c645570e [ci skip] add a section explaining command line arguments for generators
353868d6a0 Merge branch 'master' of github.com:rails/docrails
e866dbba72 Add note on defaults block option
cf669c146a Mention JS Runtime dependency in dev dependencies guide [ci skip].
6ea243dd2c remove deprecated `assert_send` from assertion list [ci skip]
a01e980db3 stop using removed `render :text`
748b69b48b Add changelog for custom content type
1e5e7f216a Fixes #27202, [ci skip]
04449baf2f Fix typo in Rails 5.0 release notes – “when when”
8f70f85451 Add note about step needed to get tests to pass if you implemented basic auth [ci skip]
c1e16fdd2a fix: solves issue#27189
8b609e1cfe Followup of UUID default extension in the docs [ci skip]
cdf11f4fa2 Add link to API documentation
5e57761835 Merge pull request #27143 from sachin21/fix-permission
83c291eae1 Fix a wrong permission
e32c09cebe Change html-scanner to rails-html-sanitizer
2ee0a1a923 Remove mention of SafeErb gem [ci skip]
c1f2cd8894 Updated Sprockets Documentation
28fc6b4a22 Remove mention of deprecated SafeERB gem from security docs for now, prior section already speaks about sanitization as a safety measure. [ci skip] (#27086)
6a8de46480 remove `alias_method_chain` from guide [ci skip]
7e30ea016b Fix small typo in Layouts and Rendering guide. [ci skip]
73437c582c Merge pull request #26905 from bogdanvlviv/docs
12a557ad4e adds support for arbitrary hashes in strong parameters
a49d18301e Update guides/source/active_record_querying.md
10f1bfa42b [ci skip] Expand context on `:cache_hits`.
e5ab8fea1a [ci skip] Add `render_collection.action_view` entry to AS instrumentation
c0ffde2e24 Merge pull request #26982 from bogdanvlviv/started_guide
91e46067b9 Add missing spaces [ci skip]
a04c91666d Fix 'Getting Started with Rails' [ci skip]
1ab0728a15 Use local variable instead of instance variable [ci skip]
c04e541f1b fix typo in Rails Test Runner section
d5d352c70d Remove `Rack::Runtime from console log [ci skip]
aa32e32477 Add missing space in Migrations guide [ci skip]
890770aff1 Merge pull request #26932 from y-yagi/update_doc_about_assets_digest
e961c2f648 update doc about assets digest class [ci skip]
1b817e778e Add more rubocop rules about whitespaces
5d48fe1717 Add documentation for `config.assets.version` [skip ci]
8597d3eca2 fix initializer name [ci skip]
e8737973a2 Add missing `+` around a some literals.
f85062bea5 Update HABTM documentation in guides
bcbd478f82 Merge pull request #26851 from Gaurav2728/update-kindlerb
4abaf95e93 Fix HTML escaping in the guides
cb0dee657d Fix indentation
31967bff3e Generate HTML not plain text
925487f858 Fix plain option in the rails_guides generator
ec521dee61 Fix typo in Upgrading Ruby on Rails Guide [ci skip]
e266a83dc1 update description of Etag [ci skip]
a9d380ed8c Merge release note entry for Date/Time/DateTime extensions
e6f0fbcb08 update kindlerb gem
6238c003ec guides, include note about modifiers when using the CLI.
0330655203 remove trailing whitespace [ci skip]
01b7d55b52 [ci skip] Fix return values of Hash Extensions examples
753fa495fe [ci skip] Fix typo in Guides: Contributing
f6cb611e9c Pull request for ticket 26769 (#26770)
34f450faa3 Introduce a benchmark template [ci skip]
35d693294d Suggested edits
8a271ef984 Improve Action Cable Overview guide
df8128ec07 Deprecated ActionDispatch::ParamsParser::ParamsParser
67608e3f69 Change page:change to turbolinks:load in README.md [ci skip]
24651bb670 Allow the use of listen's 3.1.x branch.
376415d860 add `cached` key to `sql.active_record` event [ci skip]
e04ce334f3 Remove dup distinct from AR query list [ci skip]
43641528d5 Fix typo in 5_0_release_notes.md doc [ci skip]
415adbf74f Merge pull request #26648 from y-yagi/update_description_of_queue_adapter
b96f4a0e46 Removes broken performance testing link from the 2.2 release notes
083b06eb84 update description of queue adapter in test [ci skip]
e71fd04b63 Add info about a502703 to Rails 5 release notes
3a06f01eea Fix docs for allowed params to `get` in controller tests [ci skip]
81a28ee6f8 Merge branch 'master' of github.com:rails/docrails
366e275a07 [ci skip] Fixed commas according to Oxford comma in rdoc and guides
4994188185 Fix small grammar issue introduced in #26382
7b19f33f61 bug report template for migrations (#26488)
0620370944 fixed guide to add correct documentation for partial render 'as' option
2fa5d0d27c [ci skip] Update Levenshtein code with better attribution.
cc8b8d6c61 Merge pull request #26431 from wytesk133/master
8eb2d65e12 Fix table name typos [ci skip]
5a7fbb1c52 update doc about default `cache_store` [ci skip]
768e7a1ab1 :nail_care: [ci skip]
ea40309d6f Merge pull request #26390 from Neodelf/format_mds
0649bed642 [ci skip] Simply formatting documents
974de25006 Document that redirect* don't halt exucution. We explain more on this behavior in 2.3.2, but dont specify that is not halting. Its better to not let developers be caught by surprise. [ci skip]
414cc4f40b Merge pull request #24612 from vipulnsward/fix-li-ol-width
e0f770e7e7 Remove the word "mongrel" from documents
212e80408c Minor grammar fix in engines.md
3d66695813 Update docs for change in transaction callback exceptions
b4a89459ff add Active Job bug report templates to guide [ci skip]
13f225714b Merge pull request #26364 from y-yagi/fix_class_name_typo_in_bug_report_templates
762e938054 Improve Getting Started [ci skip]
31842d4454 fix class name typo
3b0780dfc1 Merge pull request #26362 from prathamesh-sonpatki/add-aj-bug-report-templates
c934f2349f Added bug report templates for Active Job
ad48c7a82a Grammar fix [ci skip]
2e4a614c14 RuboCop is 100% green :tada:
ab21fd1536 Update Jason Zimdars twitter
63a9649ab7 Merge pull request #26226 from schneems/schneems/explicit-public-urls
f3e2d90b5e Merge pull request #26331 from kjellberg/broken-links
0b2b2b29de [ci skip] Broken links in documentation fix
f93451a8f5 Update typo & Make explanation more clear
6ef6ab3d66 Explicitly mention defaults.
ed582d2a89 Address doc style comments from @robin850
af74ece4e5 Fix asset_pipeline.md miss-merge
596bd901f9 Specify version of Sprockets-rails this will be in
d9e1e2d1dc Move default to different initializer
9c9bb1454b [ci skip] configuring.md assets.unknown_asset_fallback
aff30f9187 [ci skip] asset_pipeline.md assets.unknown_asset_fallback
634b1f08c0 [ci skip] Upgrading assets.unknown_asset_fallback
c6f5a3a501 [ci skip] Update branch version in Contributing Guide
25748e2534 Added gitignore to "files & purpose" list [ci skip]
e44258e748 Merge pull request #26288 from maclover7/jm-revert-21995
1aefb61d83 Clarify two ways to set Rails configuration options
a594fc1e30 Add back in `config_for` example
685e32e146 Revert "Merge pull request #21995 from tak1n/master"
82da6dc99c Move `assert_nothing_raised` method to Rails Specific Assertions section [ci skip]
c76bf98d0e Rename the title of comand_line.md in index Remove 'rake tasks' from index
fb2d3d3423 update `is renamed` to `tasks are renamed`
7450e093d5 Remove Duplicated information & fix typo...
7e7d63c934 Merge pull request #26249 from rafamanzo/add_redis_to_development_dependencies
b3389eb868 Remove the SchemaDumper options and change the default behavior
93b4957c8c [ci skip] Update docs with Action Cable Redis dependency
5247c4b73e Remove `:action` and `:controller` segments from routing guide
2a873ed476 Merge pull request #25750 from go2null/go2null-test-directories
e27d1db002 Clearly state purpose of test directories
3b3f536863 Change form of table name to plural in query example
bf852092be Merge pull request #26241 from scottyantipa/query-interface-docs
565fe74ec1 Merge pull request #26234 from y-yagi/remove_unnessary_session_store_setting
55fee082fc Update docs for query interface to not declare that all methods return instance of ActiveRecord::Relation
80b6cd7477 Merge branch 'master' of github.com:rails/docrails
1bd5e01f34 Merge pull request #26227 from alexcameron89/syntax_highlighter_fix
e05bab15f9 Increase margin-bottom for doc's code syntax highlighter
d090c6ad65 remove unnessary `session_store` setting
0caab70bf0 Merge pull request #26224 from jonatack/consistent-asset-precompile-examples
855ce599aa Consistent examples and template for assets#precompile
6ecfe752a0 When referring to Rails, be consistent in usage of capitalized form, unless it is used in context of a command like bin/rails or the rails directory [ci skip]
bf8edfca6d Grammar changes on getting started guide, specify where exactly the example is that we are referring to. [ci skip]
c7c77d2d14 Merge pull request #25675 from TimPetricola/schema-no-standardized-column-widths
fd01d7fe56 [ci skip] Updates ActiveJob guide on default runner.
dacee5004f Merge branch 'master' into schema-no-standardized-column-widths
7cede3d322 i18n documentation for required belongs_to message
5243914cd4 Fix #26187
88bae25ad1 Fix diffrent naming in getting_started.md
2a2301ad7d Option not to line up column types and attributes in schema.rb
646dca6f35 Fix link in Rails 5.0 Release Note [ci skip]
5b96434a26 Merge pull request #26061 from malclocke/specify_ar_message_interpolation_names_in_i18n_guide
a81523a822 Merge pull request #26175 from stomar/upgrade-guide-fix
79f2b4eb1c Add three new rubocop rules
8e15dd44ff Clarify use of update task on 4.2 and earlier [ci skip]
3c8ff6bd69 Clarify migration to ApplicationRecord in upgrade guides [ci skip]
c4aef6686b fix usage of pluralized word
f8d3d77ac2 Update increment! documentation [ci skip]
d52a90eb37 Revert "Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]"
55f4cd2251 Merge pull request #26163 from olivierlacan/clarify-autoloading-disabled
bff4de9828 Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]
1fad2ff8d9 Fix the documentation for configuring `enable_fragment_cache_logging` [ci skip]
66e88edd91 Fix remaining broadcasting_name example from Action Cable guide [ci skip]
0cce0a4198 [ci skip] Fix documentation wrong for ActionCable
bcc4901b3a [ci skip] Fix documentation for ActionCable::Channel#broadcast_to
1922e27c60 Merge pull request #26110 from aditya-kapoor/minor-doc-fix
8b3f9e026f Minor doc fix related to ActiveModel::SecurePassword [ci skip]
cbeb79abde Add documentation for `http_cache_forever`. [ci skip]
51ad3cb8bc Fix broken alignments caused by auto-correct commit 411ccbd
c540d2ba4e Merge pull request #24476 from vipulnsward/24314-eagerloading-doc-update
e63964bd82 Document know limitation about using `references` in conjunction with eager loading causing it to ignore custom select clauses.
29bdd809a1 Merge pull request #26042 from bogdanvlviv/debugging_guide
b114b74bc3 update list of rescue_responses default [ci skip]
23cdba4cd7 Add link to 'Pry' in debugging guide [ci skip]
1171edfc46 Modify LogSubscriber for single partial's cache message.
c3460d706f applies remaining conventions across the project
b47a2afbc9 normalizes indentation and whitespace across the project
3f711e38b2 remove redundant curlies from hash arguments
c5045214af modernizes hash syntax in guides
e97fa11ea8 applies new string literal convention in guides
794199f373 Merge pull request #26023 from tekin/correct-acceptance-guidelines
b01b38394d [ci skip] Fix broken URL in guides
b44aeaf856 Add note about limitations of Windows Subsystem for Linux
6c6248ec93 List names of error interpolation variables.
dd76b90d32 Add 4.2.Z back to the maintenance list
829bd948c2 Merge branch 'master' of github.com:rails/docrails
abbbc7f2f4 Correct usage for acceptance validator in guide
677f956eb0 remove old links from debugging guide [ci skip]
8c289ecc98 Merge pull request #25948 from chetna1726/docs
1b037e0eb3 Updated getting_started guide to reflect the change in error message for ActionController::UnknownFromat in ArticlesController#new
3fde16288e [ci skip] Add documentation for error using select with order
e3cdb04e0c Merge pull request #25928 from mechanicles/info-for-cache-fetch-block
a6c385cf4f Proper description for `Rails.cache.fetch` [ci skip]
e88332e10f Merge pull request #25908 from mechanicles/derives-from
3055c4ba58 Explain meaning of the code very well and Remove confusion. [ci skip]
85f0ca21e6 define Range#match? if Ruby < 2.4
c8521afddc Removed reference to callback_terminator.rb in docs
8c736ee9c1 Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializer
224432c872 Merge pull request #25780 from Ropeney/patch-1
210ba7d901 Fix documentation of `error_on_ignored_order` option
b3b5e6660d Setup default session store internally, no longer through an application initializer
edda338d8c Update references generation docs to exclude index
45aaa945f9 add missing braces [ci skip]
a0b0b62572 Fix broken link
4bba204d88 Fix display of unsorted list in release notes of 5.0 [ci skip]
0a28016a43 fixes a link in the release notes of 5.0 [ci skip]
acfae4c7e3 finders guide: updates the section about batch processing [ci skip]
4ee9cb314f Merge pull request #25748 from CodingItWrong/generator-field-types-link
351ceae94e Correct link for model generator field types
71fbf7b537 [ci skip] Update redirecting links in guides
9d454b80a8 rails -> Rails [ci skip]
4faa50db80 Update ActionCable Rebroadcasting a Message documentation
8a1a7db9ff The `to_query` method on Array objects uses `key[] as the prefix, not `_key_[]` [ci skip]
343f727ee2 Add `config.assets.quiet` to configuration guide [ci skip]
5d87e23f7d Add note about `config.annotations.register_directories` option in the guides [ci skip]
daa7d9ab3b Merge branch 'master' of github.com:rails/docrails
69619c30f5 Fix typo: caches_pages to caches_page.
1f31575e49 update doc for prefer require_relative over require + File.expand_path [ci skip]
d50567e148 [ci skip] Remove reference to Rails 4 in the initialization guide.
56d0585938 Merge pull request #25708 from maclover7/jm-master-bugreports
8cda5bec79 remove `-t` option from default sendmail arguments [ci skip]
8b22218e48 Fix documentation for number_with_precision helper in AV guide [ci skip]
7fdb843256 Bump version for master bug report templates
c7944ef27a Add header demarcation to Action Cable guide
a5f9347ab4 Merge pull request #25663 from vipulnsward/updated-syntax-highlighter
f5e6ea86f1 - Update Syntax Highlighter to version 4. - Build Syntax Highlighter based on https://github.com/syntaxhighlighter/syntaxhighlighter/wiki/Building and use theme generated by fxn. - This also bundles these brushes in the file itself- ruby,css,xml,sql,javascript,plain. Generation command used: gulp build --compat --brushes=javascript,ruby,xml,sql,plain --theme=/Path/To/RailsSource/rails/guides/assets/stylesheets/syntaxhighlighter/shThemeRailsGuides.css - rm all old js and css files - Moved over how JS configuration is created for Syntax Highlighter - Fixed layout for all imports - Fixes bug with old copy paste, generating wrong space character on webkit https://github.com/syntaxhighlighter/syntaxhighlighter/blob/7caa9632e7fe470d944fc06b4db7d35352ebaa36/src/dom.js#L227
864dca76ab Expand on Instance variables section with an example and specify when the instance variables are set.[ci skip]
b4071492eb Update Rails 5 release notes with syntax fixes.
735e10e66b Correct guide generation command [ci skip]
f4afaec3fd Fix number_with_precision documentation for precision [ci skip]
f61d36ef0e Deprecation passing of `start` value was removed [ci skip]
30b6fe5f56 Mark Testing Guide as pubished and reword the title[ci skip]
f4bb0d1376 [ci skip] Fix Typos and Punctuation in Guides - Upgrading
23539d48ba Add a Rails 5 release note for ActionController::Live becoming a Concern
90c76b4eed Add an upgrade note related to ActionController::Live becoming a Concern
f284af0dcb Fix styles of headings to follow guide rules
10d5286fe2 Change wording & punctuation in Guides - Upgrading
831f5d8ba2 fixes config value [ci skip]
b2f3e063fa expands a bit a section of the upgrade guide [ci skip]
189e327710 Merge pull request #25587 from vipulnsward/publish-release-notes
69ef8c780f Merge pull request #25596 from prathamesh-sonpatki/testing-guide-50
5ecfa85512 Merge pull request #25598 from prathamesh-sonpatki/release-notes--1
aeab03ee2c Add a note about autoloading being disabled in production env in upgrade guide [ci skip]
7993111ec5 Update upgrade guides
af6e70dd1d Update release notes for 5.0 [ci skip]
bb1454f1f4 Update testing guide for Rails 5 release [ci skip]
aee05b5395 Update getting started guide for Rails 5 [ci skip]
f1eeb3dbfb Merge branch 'add-test-runner-to-release-notes'
5a068a2a37 Add test runner features to release notes [ci skip]
a07f63901f add missing things to release notes [ci skip]
940c2cd648 Expand on #24071 for specifying custom locale fallbacks. [ci skip]
a2be7e9710 Publish Rails 5 release notes[ci skip]
2f682dd3c8 Merge pull request #25583 from vipulnsward/add-api-apps-to-release-notes
c1d4b2677f Add API Apps to release notes[ci skip]
daee2562c8 Fix release notes link
cbaf8a949f Merge pull request #25584 from vipulnsward/upgrading-guide
76be7a05d3 Pass over Upgrading guide [ci skip]
b5fe4e70d5 Add note about release notes in upgrade guide
7d694aa702 Update release notes about legacy `mysql` adapter
572e36f859 Update Rails 5 upgrade guides
5370022788 update description of `test_order` [ci skip]
8d31305a73 Clearify CHANGELOG for #23011 [ci skip]
9403fc9168 Add #16917 to 5.0.0 release notes
75477201c7 Merge branch 'master' of github.com:rails/docrails
4a44f1b3de remove unecessary comments [ci skip]
985c87a289 Tiny documentation fixes [ci skip]
cf18972d3d Update grammar for `config.enable_dependency_loading` docs
70658fd9c3 Add option to enable dependency loading in production
8862a60ba5 update_url is not `get` most of the times [ci skip]
f4f3aaf116 Merge pull request #25450 from prathamesh-sonpatki/fix-testing-guide
10b6a103a8 Fix the docs for supported keyword args for Rails 5 style integration controller tests [ci skip]
ef54dd15a9 [ci skip] correction in command for generating api documentation
55acea4e7e Make log tags example for ACa more generic and not BC specific [ci skip]
24d5d6a676 [ci skip] When instance_reader is false, attribute can still be assigned by the instance objects
17cf66330b Example had results the wrong way round [ci skip]
7bbb0fa7b9 Add Rack doc link for request and response object [ci skip]
e598ae0def [skip ci] Fix typo and simplify after_commit example
213e729b9e Changed ActiveJob::Base to ApplicationJob in the Active Job guide [ci skip]
44b9f00f38 Add missing things to Rails 5.0 release notes [ci skip]
df9faefe1d Action Cable routes are enabled by default now [ci skip]
39fd7daaca Merge pull request #25321 from prathamesh-sonpatki/update-release-notes-1
23f1bbe318 Merge pull request #25315 from schneems/schneems/inclusion-doc
61f8dc05ee [ci skip] Expand information on message options
eea0ea0102 Merge pull request #25327 from prathamesh-sonpatki/add-5-0-notes-to-the-index
0c652b38d5 Add Rails 5.0 release notes to the index page of guides [ci skip]
bc8a4262e0 Merge pull request #25323 from vipulnsward/ac-release-notes
5abf2ebf3d Expand on AC introduction list [ci skip]
bb6ec6763e Add Action Cable introduction to release notes [ci skip]
6e7afd0b50 Add missing things to release notes [ci skip]
6511698b8a Do not suggest nonsensical OpenSSL verify modes [ci skip]
da2c112df1 Merge pull request #25279 from maclover7/jm-add-backticks-1
8cccf83a9a [ci skip] Update redirecting links in guides
5e603627c2 Merge pull request #24071 from meinac/configuring_md_docs
7bfe2be6d0 Add backticks to `ActiveRecord::Base.where`
2ea9981b06 Merge pull request #25278 from mechanicles/fix-link
9400abf161 [ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community.
38c370c83e Merge pull request #25277 from mechanicles/remove-pratik-from-core
cd81966bc9 [ci skip] Remove Pratik Naik from Rails core team info.
6928f0dd11 Merge branch 'master' of github.com:rails/docrails
ae6074f052 [skip ci] Make header bullets consistent in engines.md
350d77e187 add missing "as"
9674b500f6 Grammar fixes for Contributing guide
13d5fe9c14 `will be` --> `is`
6013b0bbd5 [ci skip]Fix wrong require path raising LoadError
92ac027b9c rename enum_prefix and enum_suffix options to _prefix and _suffix [ci skip]
4d81db68ca Light edits to Action Cable Overview guide
5730e2e387 fix incorrect class name [ci skip]
73ae56bbc3 Use `add_index` instead of `execute` in guides [ci skip]
7818ab0001 cometic updates to security guide - fixes #25058 [ci skip]
f01b47a7f5 [ci skip] Fix ActionCable Guides
6c03ab3bca Docs: Clarify when assoc. methods persist
598aebd691 autoloading guide: specify autoload paths are set when the app boots [ci skip]
12c558d1ae - :scissors: space in code to match previous defaults. - Grammar edits.
cec9c266b2 remove deprecated `Module#qualified_const_` from guide [ci skip]
b4f2cba147 Update i18n guide about how to change locale and translations paths [ci skip]
8cb3b6aed2 Small grammar fixes for Action Controller Overview
3d0d5657b5 Use #distinct instead of #uniq in the guides [ci skip] (#25098)
c97e9a116d Merge pull request #25092 from y-yagi/add_23980_to_release_notes
8676b3764f add #23980 to release notes [ci skip]
33efd91f06 fix module name [ci skip]
8e4585b9ec Support for unified Integer class in Ruby 2.4+
c33ee883dc Light grammar edits to beginning of Routing guide
19a470c8b6 Add tick marks + small grammar change
96b761ad32 Merge pull request #25052 from matkoniecz/2008_is_not_recent
080dbe0107 Safari 4 supports http only cookie (#25053)
f83a4bc244 Merge pull request #25039 from maclover7/jm-capitalization-2
1a14ebc579 update to make it less obvious that this guide is from 2008/2009
8e7bcd1435 Add Attributes API to release notes [ci skip]
df92b48483 Fix security guide capitalization errors
de8194e089 PerRequestDigestCacheExpiry middlware was been removed. Removed traces, for the same. https://github.com/rails/rails/commit/23b6a9c0fcb8992e18450d6fe0680bf09685b7db
af411579b8 Merge pull request #25036 from maclover7/jm-capitalization
495d79bde2 `md5` --> `MD5`
a26c52ba6b Update the Rails security guide
d74cb12718 Pass over API Apps guide grammar. [ci skip]
e9a9da7fb3 The `ActiveRecord::ConnectionAdapters::ConnectionManagement` and `ActiveRecord::QueryCache` middlewares were removed with `Executor` addition on d3c9d808e3e242155a44fd2a89ef272cfade8fe8 Removes traces and reference of these from all places. [ci skip]
14fae9644a Change output genereated for middlewares on a new application. This has changed quite a bit after Executor middleware addition. [ci skip]
2c5a0b6893 Add `ActiveRecord::Migration::CheckPending` to default middlewares for API Apps [ci skip]
919b592f25 Merge pull request #25002 from maclover7/jm-add-actioncable-guide
d7af3e6198 edit pass over the cable guide [ci skip]
93d0a434b3 Merge branch 'master' of github.com:rails/docrails
214eff2ef8 Add output snippet from `ActionController::API.ancestors - ActionController::Metal.ancestors` command for api apps. [ci skip]
58fe5c7d43 Add Action Cable guide to list
733b7221a5 Getting Started Guide: Add invoke test_unit to files table [ci skip]
e376c0dd7d Getting Started Guide: Add channels and jobs to app purpose table [ci skip]
deb7180999 Getting Started Guide: Update Ruby version to 2.3.1p112 [ci skip]
ba237809d4 Remove ambiquity in what we are referring to in the documentation of config vs configuring the server itself
9abb9cfbdc Document config.action_dispatch.ignore_accept_header and config.action_dispatch.x_sendfile_header in configuring guide
b951cd31c1 More missing true literal quotings
801f2c76cf Lets be consistent in the usage of true/false across this guide. It should be quoted as how other config options are. They are already quoted at many places. This change, makes this usage consistent. Note that, this is quoting literal values true and false, not truthy values
0fe4954b05 Document missing smtp config over at configuring guide. [ci skip]
2c74749646 This config still applies for Rails 4 Apps and we need to mention it, what was needed before. [ci skip]
91a095fdba Minor syntax change
38ddaea387 Update Ruby report templates
cd9766db4e Start Rails 5.1 development :tada:
4cba13d6ab Grammar corrections to Getting Started Guide [ci skip]
844bf43d81 Asset Pipeline: Remove outdated comment about `config.assets.digest` [ci skip]
66f7ab56a0 Asset pipeline: Remove documentation about outdated `config.assets.compress` option
237820ac86 Merge pull request #24911 from meinac/change_http_to_https
056c026870 Use consistent term [skip ci]
fa27ed381d Change http github links to https [ci skip]
b827c86652 change cable.coffee to cable.js [ci skip]
a28dcc09ef Merge commit 'fbdcf5221ad7ea3d40ad09651962fc85d101dd67'
e985a0e673 http --> https
b3aefe3046 Preparing for 5.0.0.rc1 release
d5b7459b5b Release notes: Add a note about `use_transactional_tests` in the deprecated section of Active Record notes [ci skip]
0bc6b57b20 Fix broken links in 'Ruby on Rails 2.3 Release Notes' [ci skip]
052af04ad9 Fix link in 'Configuring Rails Applications' [ci skip]
92286f4418 Fix link in 'Ruby on Rails 3.0 Release Notes' [ci skip]
2dab102c05 Fix markdown syntax in 'Ruby on Rails 2.2 Release Notes' [ci skip]
ab8c454af7 Release notes: Add PR #24866 to release notes
0a02eb9320 Merge pull request #24799 from prathamesh-sonpatki/18439-followup
af8d63ba41 Active Model: Improve CHANGELOG and documentation for `validates_acceptance_of` [ci skip]
c250aaca79 Remove extra space [ci skip]
29305c41e6 s/words_connnector/words_connector/ [ci skip]
b9602b26c9 Release notes: Remove duplicate entries [ci skip]
7dd3e268cc Replace ActionDispatch::LoadInterlock with ActionDispatch::Executor in guides [ci skip]
c002b1f92c fix incorrect module name [ci skip]
b3d838f382 add #24385 to 5.0 release notes [ci skip]
05e136e7a2 Update configuring.md with colons and periods
bb13c76710 Consistent spelling of "gzipped" [ci skip]
d4d88b42c2 Fix typos in asset_pipeline.md [ci skip]
b9c48b72a1 Merge pull request #24786 from vipulnsward/document-gzip-assets
f303c083c0 Document config.assets.gzip flag. Follow up of https://github.com/rails/sprockets-rails/pull/342.
9f605e1522 Merge branch 'master' of github.com:rails/docrails
628598e9fb Merge pull request #24776 from prathamesh-sonpatki/aj-release-notes
6311c66bcd Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes.
554d063f82 Merge pull request #24770 from vipulnsward/guieds-type
2fcd3ef0b3 Fix broken links to ryandaigle.com [ci skip]
b5fb292ff6 Pass over debugging guide [ci skip]
33d874a962 Review the `byebug` debugging guide
8fab314ddb Fix inconsistent usage of capital letter in rails generate command examples
cb9361e6e9 Prep Rails 5 beta 4
8528f3adb8 Fix typo in Configuration Guide [ci skip]
57a08e0820 Fix typo in Rails Guides [ci skip]
6baa1480e9 Add #23461 to release notes
8ccfe9013d be specific when the debug_exception_response_format to :api
9b135f3d1a Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip]
0c94cb3062 Mention default values for `debug_exception_response_format` in configuring guide [ci skip]
cced243c29 `debug_exception_format` is set to :api by default for API apps only, not for normal apps.
af804d9eed Add SQL examples for equality and NOT [ci skip]
bbef280a34 Merge pull request #24657 from maclover7/fix-23643-1
09b90ee3a6 Fix small typos [ci skip]
5b9edf00da Add #18323 to 5.0 release notes
70f2f51b01 - Added documentation for ActiveJob queue adapter for a specific job.
ca67be0b6c s/determins/determines/
5776021ab7 Remove reference to unknown method `dirty?` to docs [ci skip]
dbbcf28c0e Add #16917 to release notes [ci skip]
051e19402a Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl needed for Chapters column, instead of leaking to other lists.
9e5c983b49 Merge pull request #24603 from prathamesh-sonpatki/fix-wording-about-adapters-supporting-db-comments
4636f1b4fd Fix wording related to adapters supporting database comments [ci skip]
62ed955a21 Add note about ability to add database comments to release notes [ci skip]
3cb73c739f Merge pull request #22911 from Envek/database_comments
377574f362 documentation for add_references index option [ci skip]
3d4f82b7f2 [ci skip] docs for add_references index option
b9aa9ae61d Add support for specifying comments for tables, columns, and indexes.
f456145c15 Add a note about how to execute 'rails app:update' on 4.2 and earlier [ci skip]
c7aff0aa0e Fix broken link in 'Ruby on Rails 4.0 Release Notes' [ci skip]
01fe741a0c Merge pull request #24557 from y-yagi/update_example_to_specify_ac_mount_path
7345702543 update example to specify the Action Cable mount path [ci skip]
cd7220ad53 Add Attributes API to release notes
d67b7a1eff Merge pull request #24454 from iangilfillan/master
d883959ed0 MariaDB Documentation
fde5cbb9d2 Merge pull request #24536 from vipulnsward/ruby-2-upgrading
2f2342279c Add ruby 2.2.2+ version requirement for Rails 5 apps [ci skip]
e5e4f15996 - Make sure we end sentences - Change from "The Task" to "The Update Task" as referred elsewhere
8a0c2974a9 [ci skip] Add some missing commas
f3f849c0d6 [ci skip] Typo fix. `loggs` -> `logs`
ca09881b73 - Fix typo in config guide, from config.logger section - Make bulleted lists, end properly
850aa7cc03 s/Thoughtbot/thoughtbot/
2532ba2ea3 - Add changelog for new guide: AC overview from https://github.com/rails/rails/pull/23176
376d59d522 - Fixed changelog related to i18 key changes. Added author - Made all sentences to end properly [ci skip]
4738dbfcc9 fix typo in file path [ci skip]
be56ca9f50 Remove reference to non existing link in the welcome page.
bbd194ae81 Clarify fixtures examples [ci skip]
766a7a199e Clarify description of `include_all_helpers` config setting's default behavior [ci skip]
0e6cd07bb6 Fix broken link in 'Ruby on Rails 3.1 Release Notes' [ci skip]
6e4c87e442 Merge pull request #24465 from y-yagi/remove_needless_entry
d5212d08cb remove needless entry [ci skip]
cf7895bdaa Fixes for the strong & weak ETags guide [ci skip]
0f2ae82f97 Merge pull request #24444 from prathamesh-sonpatki/update-message-proc-documentation
5c4a79e858 Update example of passing a proc to `:message` option for validating records [ci skip]
80b7f0baab Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
e7e70fa6bf [ci skip] Fix formatting of code snippet in Action Cable guide
fde72cc323 Merge pull request #24419 from rgm/master
c2d25ef8c9 Merge pull request #24410 from mechanicles/strong-weak-etags-info
ff9448705f Update documentation based on the new changes for strong & weak ETags [ci skip]
739694e0a7 Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
059fd4bfe5 [ci skip] Update code used for filtering passwords in the configuring guide
5310bdd6e0 Guides changes, follow up of #24401
c243cde3b0 it's => its typo
e353e7af04 [ci skip] Fix variable name
bce51d968d Merge pull request #24406 from prathamesh-sonpatki/update-release-notes
c85700e196 Merge branch 'master' of github.com:rails/docrails
016ffc2fe9 Update Rails 5 release notes [ci skip]
f9da2d8397 remove deprecated `datetime_field` from guide [ci skip]
6ebe033c35 Fixes broken link in 'Ruby on Rails 2.2 Release Notes' [ci skip]
0e55d19477 [ci skip] Parameter filter performs regular expression partial matching
36d60327c9 s/documention/documentation/
68b5b1ccbf Update how to clear the association cache
7671f15cfc [skip ci] Update `numericality` validation docs
99a278518e remove old-dead link
e834ef8e87 Correct typos in "Active Record Query Interface" guide
bef06ce084 [ci skip] Added missing custom context validation
1362d44d8b Remove reference to unmaintained plugin/gem
93ea344f58 s/responsibilty/responsibility/ s/symantically/semantically/
face4f7856 - Fixed abrupt start of sentence in changelog
d1c5806a39 guides, sync 5.0 release notes with changelogs
f8744470a3 guides, sync railties and AP changelogs with 5.0 release notes.
dc57d83d7f update Active Job default adapter [ci skip]
8f1c8968e7 remove Rails 4 text from asset pipeline guide
a8d20379a4 use rails 5 favicon.ico for rails guides
f016337896 Document and Match the Rails logger interface
e3e6750a12 Update action_controller_overview.md
ea1dec4d0e Remove log-related stuff from ActiveSupport::Dependencies
4842ab3930 Correct command for generating secret_key_base [ci skip]
5eb2b7cd09 add `queue_classic` to list of provide `provider_job_id` [ci skip]
ecaec8ae31 add headers to payload list [ci skip]
dbe79200ac Clarify has_many :dependent option docs [ci skip]
9ae689127d remove obsolete i18n links from guides [ci skip]
da9fcb33f9 Remove needless `break;` [ci skip]
4943f7793b Remove extra 'the' and unwanted comma [ci skip]
1e9dcc3055 Remove incorrect Rack documentation example
4340d2ec4b Merge branch 'master' of github.com:rails/docrails
e73011bb1c remove entry for reverted commit [ci skip]
fc2da230db Update the rendering guide to match the current behavior
64cf9ee01d Added some useful configuration options into configuring.md [ci skip]
3f7ad062b9 remove config that are no longer needed in sprockets-rails 3
06d3afb7b3 Match Puma 3 startup messages [ci skip]
0a58489597 Fix author callback in engines guide [ci skip]
4f6c0d4ac0 Merge pull request #24021 from y-yagi/add_scaffold_stylesheet_to_guide
d019853c77 add `scaffold_stylesheet` method to guide [ci skip]
69c9953faf [ci skip] Make collection caching explicit in guides.
402520619b Change 'a HTTP' to 'an HTTP' [ci skip]
61cbe7b091 [ci skip] Update all guides with `null: false` change in migrations
17b4b0653f [ci skip] Update getting started guide for chanages in migrations API
9ff2a09860 Changed behaviour of timestamps helper by create_table migration generator [ci skip]
f78fbc9300 Merge pull request #23936 from yui-knk/local_constants_to_be_public
ed8a279273 Merge pull request #23417 from sgringwe/master
5254624244 Deprecate `Module.local_constants`
37da018d92 Merge pull request #23957 from delftswa2016/fix-documentation-stylesheet
c83799c487 Fix typos in Action View Overview guide
6896354dc2 Fix value of CSS background-color property in Rails guide
9dcc09c932 Fix formatting in Action Cable guide [ci skip]
fb27aacea6 Fix merge conflict in Action Cable guide [ci skip]
b4cd1f7cfe Further cleanup of the cable guide
fa1262407e Merge pull request #23943 from y-yagi/remove_rake_word
db6df478c7 Fix typos in Action Cable guide [ci skip]
dbd358f7a5 Merge pull request #23176 from davidkuhta/patch-1
5985919f01 remove "rake" word [ci skip]
bc85259bf1 use `app:update` instead of deprecated `rails:update` [ci skip]
66cccbba22 Merge pull request #23933 from HayleyCAnderson/ha-action-cable-docs-fixes
0c66774edd Add small Action Cable documentation fixes
af555cf905 Update docs to point to new update task.
e0dae25a1c Merge pull request #23439 from ryohashimoto/160203_rake_rails
70be58e92a [ci skip]Add info for specifying logger in different envrionments.
2495af21de [ci skip] fix json output
89b66e6969 The tasks in the rails task namespace is deprecated in favor of app namespace. (e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
c342fd0f74 [ci skip] Remove reference to Rails 4 in the initialization guide.
aa3dbb6c2d Merge pull request #23902 from prajakta-tambe/update-debuggings-rails-app-doc
d4db0ca025 - Changed Debugging Rails Applications doc's logger introduction section. Changed location for specifying logger. [Prajakta, thiagoaugusto]
3e53ef2597 Doc: update AC::Parameters guides for Rails 5
f864277e2b Doc: update routes guides for Rails 5
1ff557d00c Merge pull request #23874 from st0012/update-documents
cca8b13786 Additional review of 6b31761.
d24c4da535 Lock down new `ImplicitRender` behavior for 5.0 RC
f8ff258f3a Add config.debug_exception_response_format into configuration guide
ff55b7dd62 Update config.force_ssl's documentation
afd5b4ca90 Enable Action Cable routes by default
52244fbd9c [ci skip] Need to mention debug_exception_response_format in the api_app documentation.
f1c846eac3 Updated file documentation [ci skip]
7012fc4bae Merge pull request #23860 from zerothabhishek/weak-etag-guide
3d21641349 changes caching guide to add note on weak etags
d79b7d631c Merge pull request #23857 from st0012/update-documents
0c9cda0367 Fix wording and wrong reference
26bc06363b Fix ActionView's cache section reference
0dbfe644b6 Add caching guide in ActionMailer basics
73851ce2ec Add ActionMailer configuration options
0d7dd991fe Preparing for 5.0.0.beta3 release
94b9b5cf81 Update 5.0 release notes
470c3cb761 Merge pull request #23795 from claudiob/replace-rack-with-rails-command
dd5e49d699 Header Typo
e550084930 `stream_for` example
6e9b41cf7d Merge pull request #23836 from sstephenson/turbolinks-5
f5344ed147 Explicitly denote that channel.rb is a default file.
d59fcb17cf Change ActionCable.server.broadcast to XChannel.broadcast_to
66ae3d96df [ci skip] No hyphen in 'side effects'
255928206e [ci skip] Fix typo in Form Helpers Guide
c21ed852c5 Update JavaScript guide for Turbolinks 5
50500f5fed Switch to `data-turbolinks-track="reload"`
3c60f96191 update assert_nothing_raised in testing.md
2b4c84ece3 Add a note about downcasing submit tag
cd95ce7eab AppGenerator: Replace 'rake' with 'rails_command'
48d21733d5 remove needless `debug_exception_response_format` config [ci skip]
f41750e005 partial pass over the API guide [ci skip]
65360d348c Remove github gems from the master bug report templates
f009f3cdcb [ci skip] fix suggested change-replace 'an' with 'the in Rails engine guide'
4aa5ebeba3 Fix the language in engines guide
da0c20daf4 Add Action Cable CHANGELOG in release notes [ci skip]
2d0534b3bc [ci skip] Updating edge rails guides to include `on_weekday?` on Date, Time and DateTime
d2e4a395af reset `ActionMailer::Base.deliveries` in `ActionDispatch::IntegrationTest`.
275f4e46ec Merge pull request #23688 from meinac/guide_typo_fix
708c95a181 Fix small typo in Rails guides [ci skip]
65f741c840 Merge pull request #23687 from vipulnsward/add-on-weekday
e1729646dc Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`.
e3cfe73b22 Create action_cable_overview.md resolves #23176 [ci skip]
86a5a95237 [ci skip] fix typos
7adc7133b2 [ci skip] Update 'Testing Active Record'
42c8828db0 restores the guides layout header [ci skip]
b50f4f8dcc Merge pull request #23660 from meinac/change_x_gzip_to_gzip
175528f56f Change x-gzip to gzip in docs [ci skip]
37d35c3cab Merge pull request #23654 from kamipo/fix_grammar_a_to_an
757f3bbacb add missing name option to flash test example [ci skip]
573ddadf2a Fix grammar `a` to `an` [ci skip]
470d038451 Use correct path in documentation.
a7d9932676 Merge pull request #23612 from vipulnsward/23561-fix-routes-args
b5d4cc9fc8 - Fixed and removed long arguments to rake routes - Fixed related documentation and usage all around
a740900b5a Fix numbers of steps to upgrade Rails [ci skip]
51ee3845b9 Improve wording in documentation change
6d972542ff Document the upgrade process
7c01b140d7 Update active_record_querying.md
068115680b Merge pull request #23583 from brchristian/penultimate
034dfb8f84 rename to 'second_to_last' and 'third_to_last'
cd8b83c79f Fix typo
4967562889 Fixed grammatical errors in rails docs [ci skip]
c6e0dc6730 allow Array.penultimate and Array.antepenultiate access methods
311da81ac4 Update documentation regarding initializers [ci skip]
e73e6f8deb remove description of `render :nothing` from guide [ci skip]
b7f51e6ee0 [ci skip] Fix grammar
8596df17c8 Fix a typo
c575016634 Remove references to Rails 4 from assets guide [ci skip]
a912a086bf update turbolinks url [ci skip]
245e2d01c4 doc changes
e06e01d64a Publish guide on "Using Rails for API-only Applications" Fixes #23322 [ci skip]
6da169d8df Separate for new and existing applications clearly
e9d411d4d3 Merge branch 'master' of github.com:rails/docrails
7a05f517fc Change the default adapter from inline to async
52d8eb54ce Check off some todos for the Testing guide with @senny [ci skip]
698678fec2 docs, remove trailing whitespace from testing guide. [ci skip]
fc2ef642b3 docs, link Rails specific assertions to the API. [ci skip]
a01160d9af add missing include to engine test example [ci skip]
eea3629877 SQLite 2 support has been dropped [ci skip]
fa450a4907 Merge pull request #23442 from prathamesh-sonpatki/improve-pg-version-old-error-message
547754606e Merge pull request #23447 from y-yagi/update_pg_supported_version_in_docs
44eb518c22 update supported version of PostgreSQL in docs [ci skip]
94051a614a Merge pull request #23436 from y-yagi/use_bin_command_in_routes_task
0f9229747f Mention PostgreSQL version support in release notes [ci skip]
2aa13170da use rails secret in rails guides
bab266fab6 use rails command in routes task
4a4325769a Add initial support for allowing an error on order or limit of queries being ignored in batches
21cc2eacc2 Fix typo.
8b969f2c26 Change command_task.rb to commands_task.rb in docs
34a5a1deb9 Preparing for Rails 5.0.0.beta2
9e2b1572a9 Merge pull request #23225 from vipulnsward/20420-rake-routes-options
fe82c27dc3 Merge pull request #23406 from hackerkid/master
114ecbefdd .git added to https repo urls
d739126913 Merge pull request #23151 from maclover7/fix-23148
8138e8f999 Add options for rake routes task
e66fb7793b git protocol replaced with https
672f2f15ed Add documentation for #17573
03e70140b2 Merge pull request #23375 from prathamesh-sonpatki/fix-19835
3dadcb8301 Fix documentation related to `config.assets.cache_store` [ci skip]
afabeeb3dc Revert "Merge pull request #23366 from maclover7/add-configuation-ar-docs"
4b0a78ebc6 Merge pull request #22857 from bdewater/interlock-doc
212d9d2cd4 Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
ad640360d3 Merge pull request #23368 from y-yagi/remove_backward_compatibility_code_for_minitest_4
280fff23ae Remove odd ` [ci skip]
6ed8a7b24a Add configuration section to "Active Record Basics" guide
24f203bfd7 Small cleanup to Testing Guide
5494a57b20 Merge pull request #23358 from vipulnsward/testing-guide-pass-3
827704debc Pass 3 over testing guide - Various grammar fixes - Added assertions for update controller action tests - Added user helper tests - Fix typos
8c6f25cfa3 typo fix [ci skip]
b788307f20 [ci skip] fix typo
4703275aee remove backward compatibility code for Minitest 4
5f0999802f Merge pull request #23317 from rfmanuel/after-bundle-in-rails-plugin-template
e56604e898 Implemented pull request changes.
1b6c0f8eec Getting Started Guide: Update Ruby version to 2.3.0p0
5f6bcfe148 Docs review of api_app.md
3ea65c68da Remove Rack::Lock from the API guides
2786734007 Middleware have no plural
cfea1d96a1 Mark API guide as work in progress
94e43b4718 Put "Using Rails for API-only Applications" in table of contents
cdc253a35f Update doc with appropriate issue and pull request versions
be7a1532fa Add an after_bundle callback in Rails plugin templates
44fed8404c Merge pull request #23237 from gsamokovarov/new-welcome-page
740717dabe English explanation to multi-level nested join
b5290d99eb Fix typos in asset_pipeline.md
27c1316a6a remove duplication section [ci skip]
48feb3757d Introduce new welcome page for new projects
95a44c2c59 Merge pull request #23208 from vipulnsward/testing-pass-2
8bcb9988c2 Merge pull request #23210 from sachin21/change_permission
28c72f0198 Update the exception of format constraint in routes
3528a585ca Pass 2 over testing guide - Grammar fixes - Wordsmitting - Fixed wrong statement about association usage in fixtures - Changed association name from 'one' to 'first' instead - More consistent usage of we/our - Mentions assert_select is below, not already covered in Integration test.
c3b21ad9a2 Change permission to readonly
05e271fa36 Merge branch 'master' of github.com:rails/docrails
07b00f7c74 Rails 5.0+ rake commands implemented in Rails Framework itself. We prefer to use bin/rails instead of rake [ci skip]
851195d671 Merge pull request #23177 from vipulnsward/testing-pass-1
74c8045c56 First pass over parts of Testing guide - Grammar improvements - Consistent usage of you or we in sentences - Tests can have zero or more assertions. Its not mandatory to have one. - Example for assert_send
9ae192956a [ci skip] fix #23157
1471a43d91 insert newlines into code samples
00419c2481 Merge pull request #23125 from Gaurav2728/update_puma_as_webserver
03652d8b59 [ci skip] update guide for Puma web server instead of Webrick
9f02f59455 - Changed from bin/rake to bin/rails at more application places. - Only ones left are from the upgrading guide, and command line guide explicit section about rake
977670a47b use bin/rails default instead of rake commands [ci skip]
098f157825 - Remove dead links and take users to just the home page instead - Add new logo for guides header [ci skip]
2d6cda07fc Merge pull request #23117 from vipulnsward/22297-ar-exception-raise
705266138e Mention that halting chain does not re-raise `ActiveRecord::RecordInvalid` exception as well, similar to `ActiveRecord::Rollback`
f3a3a1b167 Make text about render :html option clearer to state, text will get escaped if not marked as safe by using html_safe
3b0cac4f7a Fix discrepancies in associations guide [ci skip]
7ccbab9637 `ApplicationRecord` instead of `ActiveRecord::Base` in Association Guides [ci skip]
4aa3d9552c Merge pull request #23099 from vipulnsward/change_start_at_end_at
bca9639f9b Association Guide replaces Order as example with Author-Book Example [ci skip]
c64992b486 Merge pull request #22705 from RochesterinNYC/add-order-explanation-to-first-last-guides
4046d1c51b Merge pull request #22394 from j-dexx/update_association_basics_guide
8644760f4e Updated the guides for having a distinct has_many through at the database level
3c22811299 Explain how HStore columns can be queried [ci skip]
53fbcccfe3 Changed options for find_each and variants to have options start/finish instead of start_at/end_at based on comments at https://github.com/rails/rails/pull/12257#issuecomment-74688344
df0e5bf8e1 [ci skip] fix typo in docs
76224212a8 Add a note on ActionController guide about 404
26bf26d0f3 Merge pull request #22983 from bronson/update-mysql-in-guides
2c24e1affc Merge pull request #21995 from tak1n/master
d1fc42eb79 remove legacy mysql from guides to match #22715
83fb03a163 rake log:clear task updated refs[#22544]
b9754f0b11 Merge pull request #22275 from mastahyeti/per-form-csrf
84cfce2f42 Merge pull request #22922 from vhf/add_fpb_back
e92b120718 Add job suffix to sample's job file name
8bfdd30d79 [ci skip] Update doc/resource link removed by #21211
e19b65e3a8 add option for per-form CSRF tokens
70e01db90f Update the maintenance policy for the next release.
faa3fcf6a3 Remove duplicate entry for ActiveRecord::Relation#cache_key from Rails 5 release notes [ci skip]
8f80374230 Fix typo: test -> text
b4200a0aef [ci skip] Update rails/all.rb reference.
9e598e72c1 Merge pull request #22844 from prathamesh-sonpatki/issue_22836
11d864d1af Fix documentation for configuring default_charset [ci skip]
d80b7093de [ci skip] Put all removals in its section
b792faf9de Merge pull request #22053 from Empact/first-loaded
b7c1805d1b Merge pull request #22759 from akshay-vishnoi/human-size-helper
c132e042bd fix link to pr [ci skip]
5416ece9f1 Improve RDoc documentation of ActionDispatch::SSL
3a19ef9ba2 Improve documentation of config.force_ssl in guides
4e7424039b Improve readability of CacheHelper section
06cd2a64b3 release notes, use past tense. [ci skip]
00f7e487e2 release notes, Rails 5 won't support the protected_attribtues gem.
d9403bce5f release notes, extracted notable changes from Active Record CHANGELOG.
1b94a2f1d8 release notes, extract notable changes from Active Model CHANGELOG.
dae85d64b2 release notes, extract notable changes from Active Job CHANGELOG.
1d04b48116 release notes, extract notable changes from Active Support CHANGELOG.
cf36807636 Fix typos in Rails 5.0 release notes [ci skip]
d05b9623e7 [ci skip] An internal link is an relative path
9cd46430ed Fix letter case and grammar in Routing guide
3a688e931e Add support for Petabyte and Exabyte in number to human size
b9a5e6b586 fixes typo in 5.0 release notes
59d61c3fbf release notes, extract notable changes from Action Mailer CHANGELOG.
1402d4caf6 release notes, extract notable changes from Action View CHANGELOG.
806f420678 release notes, use past tense. [ci skip]
3bc17a3eef release notes, extract notable changes from Action Pack CHANGELOG.
9cdcc7fced release notes, extract notable changes from Railties CHANGELOG.
d2c95206b2 guides, restructure Rails 5.0 release notes. [ci skip]
895b18bada Merge pull request #22701 from maclover7/rails-5-release-notes
c424e76765 Merge pull request #22483 from y-yagi/use_bin_test_in_plugins_guide
f1689c8f84 remove content_tag_for example
19eac77f04 corrects a typo
1bbe1fd40a Merge pull request #22709 from jonatack/clarify-explanation-for-new-config-halt-callback-chains
d3e52eceb4 use `bin/test` in plugins guide [ci skip]
a1c6cb2981 Add Rails 5.0 Release Notes
278c85c3bc [ci skip] Fix typo
42751c9e20 [ci skip] No more no changes entries in the CHANGELOGs (cases left in #22718)
a4469e58ed Clarify config settings for AS::halt_callback_chains_on_return_false
77827bee9e [ci skip] `rails new project` generates README.md now
3a12f90bd0 Update README extension in Getting Started guide
0a4c6e7f87 Remove legacy mysql adapter
1b838fd59b Upgrade Guide: Add missing period, :scissors: whitespace [skip ci]
e14d25099a mysql2 adapter instead of mysql [ci skip]
db6df596ca Add clarification about `first` and `last` behavior when using `order` [ci skip]
c6daab8d9d Add CHANGELOG headers for Rails 5.0.0.beta1
82f7952e50 Merge pull request #22462 from lxsameer/i18n_html_wrap
21ff540930 debug_missing_translation configuration added to action_view
ef9aefa7d6 Refer to rails command instead of rake in a bunch of places
09c408a8c5 Fix section about ApplicationRecord in upgrading guide [ci skip]
ebdb4f5fce ApplicationRecord release notes entry
d16329c7e9 ApplicationRecord documentation pass
115acbdeeb Fix documentation about ApplicationRecord
0b6253a06d Merge pull request #22506 from derekprior/dp-redirect_to_back_or_default
af782fb1b4 Deprecate `redirect_to :back`
8764638f3e Add `redirect_back` for safer referrer redirects
f50dbbb0e2 Merge pull request #22567 from gsamokovarov/introduce-application-record
e7d6804ad0 Merge pull request #22611 from existent-co-uk/patch-1
4e6487f7ec Mention the correct way to halt callback chains
d1cff3992a Fix a couple of grammatical errors in security.md
f35c68d6f0 Introduce ApplicationRecord, an Active Record layer supertype
4c1ce263a4 Use a real migration version number in docs
ffca88e3c3 Use a deliberately-invalid migration version in all doc examples
42d3524eb2 Merge branch 'rails-rake-proxy'
e441339beb Implement Rake proxy for Rails' command line interface.
14a8c9dd5f Merge pull request #22572 from prathamesh-sonpatki/fix-paintit-method-in-guides
98dd27c4f6 let config.file_watcher be the way to enable the evented file watcher
f166c2270f [ci skip] Fix articles spelling.
f4967774a7 Fix paintIt method in JavaScript guides [ci skip]
e46cd9bc37 Remove ActionController::TestCase from documentation
af0f38321e Merge pull request #22554 from y-yagi/fix_link_to_coc
9504ffe8dc fix links to code of conduct [ci skip]
55a5f8ab66 Merge pull request #22367 from andreynering/docs-ar-enums
593cedc2fe Mention the debug_exception_response_format config in guides
ae2db3ccbc Adding Enums section to Active Record Querying Guide. [ci skip]
1e5256f7c9 Introduce after_{create,update,delete}_commit callbacks
d8e7b01569 fix doc for rails custom configuration through config_for [skip ci]
bc3cdd78a7 Update autoloading_and_reloading_constants.md
5c8a4cdda2 Merge pull request #22343 from jeffminnear/patch-1
76f00ca798 Modify unscoped usage guide to include chaining
3c5ebe5684 Merge pull request #22427 from eliotsykes/validation-message-proc-doc
396fbafe37 Merge pull request #22283 from the-undefined/routes-error-singular-resource
d2a68e21dd Merge pull request #22315 from takatoshiono/fix-configuring-doc
216ae2f280 Document message validation option accepts Proc
3f957ab18f Merge pull request #22263 from mastahyeti/csrf-origin-check
d5c4c5ab5e Add option to verify Origin header in CSRF checks
98f818a177 Remove valgrind note about linux only support
0cd4ddab52 Merge pull request #22374 from DNNX/patch-1
bf8eb35edb [ci skip] Add `Translating Rails Guides` to contributing_to_ruby_on_rails
7f3dd4eec6 Simplify `RailsGuides::Generator#select_only` a bit
1a157a5acb Merge pull request #22340 from rbr/change-configuration-example
6eb7b331bb Fix a typo
604f694d62 Change configuration-guide example
81813d0ced guides, scaffold no longer used in getting started guide. Closes #22337.
ec56855370 [ci skip] Indentation in cache examples
82a1b…
siman-man
added a commit
to yasslab/railsguides.jp
that referenced
this pull request
May 17, 2017
72372c739d Merge pull request #29056 from juliusdelta/29055-missing-links-in-activesupport-railsguide
4032a796d4 explain why guide translations need a fork [ci skip]
7f1180dac4 Clarify documentation for system test arguments
e716e3645a Use a more realistic use-case for system test generator
a3bc5987ed Old expression caught to many chars resulting in 404. Added minor change to resolve
4a663b36a3 [ci skip] Mailer fixtures in Testing guide.
06349a3467 Fix a typo in guide [ci skip]
0b881fce8e Merge pull request #28240 from kreintjes/fix/autoloading-sti-guide
b5ea769cb1 Fix link to `assert_nothing_raised` doc [ci skip]
526fa1e63d Should escape meta characters in regexp
d1106d8307 Merge pull request #28337 from riseshia/patch-1
2ceb8643d0 Use target language's document.yaml [ci skip]
f999328309 Rails secrets is not built on but inspired by Sekrets
a21ebc6161 Update the Gem Bug Report Templates to 5.1.0
8324fe0ecf Fix note about `secrets.yml` [ci skip]
7007ff1d34 Remove entries included in 5.0 [ci skip]
c362be8a47 5.1 Release Notes are complete [ci skip]
8f0d62f3c5 Small grammar fix
7c2ebbc352 Small grammar fix
55c2e4b6fd Small grammar fixes
222e49b317 Fix indentation [ci skip]
f931d5b3d8 Added some more release notes for Active Record [ci skip]
959c51e5fe Merge pull request #28904 from robin850/update-working-with-javascript
4ad6eede7d Add documentation of data attributes for UJS [ci skip]
348475b475 Nest Action View remote helpers one level deeper [ci skip]
f2a01da5ef Add a section with the different Ajax events [ci skip]
f961ae5357 Update the JavaScript guide to use `form_with`
2987e0f224 Pluralize methods
caec4d320d More release notes for Rails 5.1 [ci skip]
e6cec91e57 Add some items to the release notes [ci skip]
da547043bc Some improvements in the 5.1 release notes [ci skip]
71822f593f s/broadcasing/broadcasting/
2241c26462 Describe the changes in transactional tests
3c5c5310ef Add missing `action_view` section of config flag
9c4525285e Merge pull request #28861 from koic/unify_names_of_github
6ceda62ab0 Unify the name of GitHub [ci skip]
ad7dfbb3d0 Merge pull request #28860 from y-yagi/add_form_with_generates_remote_forms_to_configuring_guide
99311e0377 Add `form_with_generates_remote_forms` to configuring guide [ci skip]
d598df79da secrets.yml --> config/secrets.yml
3464409aa7 Add Action View info to 5.1 release notes
5c9d285399 Use parameters, not params
3b1d0e403d Small grammar fixes
bfa9661b2d Remove unused heading
3a85acc090 Add more Railties notable changes
19ee2bb4e4 Add Railties info to 5.1 release notes
3fb2d2c118 Add Active Model info to 5.1 release notes
26368b1951 Remove unused headings
8a91aef302 Finish Action Cable section in release notes
1b1259aa3f Finish Action Mailer section in release notes
b95e67ff75 Add Active Job info to 5.1 release notes
07f52d3225 [ci_skip] Fix typo in Rails 5.1 upgrade notes
2c0f3e0dbb Add note about #26929 in the upgrade guide
19d9350af2 Merge pull request #28432 from marksiemers/master
13d016023b Fix all style guides violations
b0989efe6d Reword sentence
ee9c7b585a Merge branch 'master' of github.com:rails/docrails
59c39412cf [ci skip] Changed plain text to NOTE.
135a20754c Remove datetime fields from helper list [ci skip]
c85c41f17f Small docs fix
56e0d94479 Add missing word 'to' [ci skip]
9dac80cd9d Small grammar fix
f8147bee6d Small grammar fixes
77ce79e4d8 Revert parts of cad58fb
407d3ac227 Merge pull request #28709 from prathamesh-sonpatki/release-notes-1
8bb291091b :scissors:
ed30db5df9 Merge pull request #28402 from jules2689/action-controller-api-base-hooks
40baa9361d Update routing doc on the `get` `to:` option [ci skip]
2be19e031c Add Documentation for Active Support On Load Hooks
42c52cb8a0 Remove link to rack.github.io
0d53b3c1d9 Small grammar fixes
f7d84b4a09 Pluralize callback
5eea36918b Merge pull request #28680 from vishalzambre/callback_doc_update
1e090522b1 [ci skip] documented issue related before_destroy
6da10a1f37 Started adding release notes for Rails 5.1 [ci skip]
a8294ed590 Add text to "Upgrading to Rails 5.1"
cc2267eb5e Add scaffolding for different sections in 5.1 release notes
4fdc18cb77 Drop the "Sanity Check" contributing step
23f36a4317 Remove mentions and instructions for docrails
02d9dd640c [ci skip] Change ++ by markdown quotes
e0f2e7c56a Fix Guides to include #23138 [ci skip]
7a1452a49e Correct Autoloading and STI guide (issue #26994)
bed0aab7a6 Fix edge guides for Active Record callbacks
472785880c Don't highlight code in anchorlink [ci skip]
725a9d3d03 Downplay links in Guides headers
cc12f7955d Merge pull request #28641 from diazruy/anchors
9fa76afa57 Add anchor links to all headers
a9781f5b2c Add default_scope note to AR guide [ci skip]
e1f8a91536 Small grammar fix
de4f73d648 Small grammar fix
3b57045939 Merge pull request #28595 from 3wille/fw-after-action-hint
99c6e7d1a2 Fix link to rails-ujs
b98fa16753 add hint on after_action filters
14e19e8124 Small grammar fix
57a097d3d2 Small grammar fix
80027c521d Update middleware list
30b0ccb99e Upgrade various Rails 5.0 references to 5.1
197224788b Add WIP Rails 5.1 release notes to documents.yaml
37a1aa8fd6 Rename local variable name `current_user` to `verified_user` [ci skip]
83b6aae2c8 Merge branch 'master' of github.com:rails/docrails
334c36902c Doc cleanup for caching guide [ci skip] (#28556)
cb1726c4d4 Merge pull request #28550 from rachel-carvalho/update_browser_compatibility_for_http_verbs
b809a533c7 update guide to reflect browser compatibility for HTTP verbs [ci skip]
230d0afc1b Additional explanation about cache implementations
be783efdf8 Update bug report templates
2a0dfae0ae Start Rails 5.2 development
0716a9e87a Update Configuring Rails Component guide example
fed48e15bf Fix typo in Caching with Rails Guide [skip ci]
158be02121 Update the maintenance policy [ci skip]
234c185f0b Merge pull request #28477 from spdawson/patch-3
029a22cdd3 Remove stray back-end from ActiveJob Basics guide
71ef9e78be Minor grammar fixes for Rails 5.1 release notes
c78f2dcd27 Update some jquery-ujs references to rails-ujs
577607b46a Add link to rails-ujs/dropping jQuery PR
71d4a52d05 Add link to Webpack/Webpacker PR
38608458d8 Second pass on 5.1 release notes
3b1df5881d First pass on 5.1 release notes
05d7c21bc8 Improve Caching with Rails Guides [ci skip]
4217054d2a Fix resolve usage in the release notes
24b6c36a30 Merge pull request #28096 from prathamesh-sonpatki/5-1-release-notes-first-draft
ceb3316644 Merge pull request #28318 from bogdanvlviv/remove-ability-update-locking_column-value
03027d4824 Merge pull request #28421 from tangposmarvin/docs-assest-pipeline
fe1b9d31c2 Fix asset_pipeline docs incorrect image dir info
d9b9f8df91 Remove ability update locking_column value
bed7abd997 Update 'Building Complex Forms' with `inverse_of`
996feb2138 Remove unused `@txn` variable
18e45ba172 Remove obsolete warning about regular expression
36b1b1a5a5 Add blurbs about each new feature [ci skip]
4343ce533e Fix weird documentation line
94847e6c89 Second editing pass on "Active Model Basics" guide
c809da3fac First editing pass on "Active Model Basics" guide
eb6e4cbb20 Add link to mentioned API [ci skip] (#28392)
2aecaffee8 Merge pull request #27152 from tjai89/patch-5
78c18d22db Fix typo in the security guide
4db846cb95 Improve readability of testing guide [ci skip]
3b468772dc Edits to Systems testing section [ci skip]
524331a48c force UTF-8 as external encoding in guides generation [ci skip]
95f69e4022 Fix to use correct path with language on guide
42328a667e Merge pull request #28289 from maicher/master
0975431538 Remove `:on` option that does ot exist [ci skip]
dbd3f0d8a6 Improve foreign key description in guides [ci skip]
476f60c567 Merge pull request #28286 from robin850/skip-system-tests-by-default
495bd2de50 Avoid running system tests by default
6d37361a37 Merge branch 'master' of github.com:rails/docrails
e501d77434 Merge pull request #28284 from y-yagi/fix_system_test_example
2b25a3de2f Fx system test example [ci skip]
c65a855dfb Escapes and edits to configuring guide [ci skip] (#28280)
3ebd6ed5c3 Fix generated query in Retrieving specific data from multiple tables section [ci skip]
a6e7273520 Merge pull request #28265 from 0oneo/association_guide
8ff4127261 Fix spelling
c8a11c6e69 passing unique parameter to belongs_to wrongly
895df77712 Fix typo in Upgrading Ruby on Rails Guide [skip ci]
e6e859fbfe Add PR links for major features [ci skip]
46821f42b0 Add first draft of release notes for Rails 5.1 :tada:
436036deba fixed suspected typo in sample sql query
0929a3719f Improve documentation for Testing Your Mailers [ci skip]
c32b151e6a Update i18n guide to cover :zero key support in pluralization [ci skip]
549b3842d3 Use released arel
f0b772d941 Soft-deprecate the top-level HashWithIndifferentAccess class
6e1026c53b Fix w3c_validator.rb validation script
bf1ceeedbd Preparing for 5.1.0.beta1 release
c9d024cd54 remove needless extension from system test example [ci skip]
afa8cd2a8b [doc] Fix wrong class name in testing.md
b2f8146bba Use released arel
ca5e2a999b Tiny documentation edits [ci skip]
06b4626b14 Fix some grammar in docs [ci skip]
865fd1723e Clean up documentation
426ae56adf Rename system_test_helper -> application_system_test_case
0f5d276185 Move and rename system tests
97864d49e8 Update documentation and guides
3b2bdffc26 Add guides for system testing
edf81dc78c [ci skip] Update Guides to use macOS instead of Mac OS X
c25d6a280f Merge pull request #28058 from y-yagi/follow_up_to_27608
0f8249e2a0 Remove deprecate passing string to `:if` and `:unless` conditional options [ci skip]
a3ea2a18e5 Change engines guide to demonstrate maintained forum
f26e13574f Fix typo in I18n Guide [ci skip]
ce531e1216 document link processing in guides generation [ci skip]
a3281a3287 refactors and fixes in guides generation [ci skip]
9401f58e44 [ci skip] Fully qualify missing template error.
7b1b1c0362 Merge pull request #27870 from kenta-s/get-todo-done-in-render_test
b296419170 Fix rubocop violations
cc4fb170eb Update configuration guide about ActiveRecord's config option.
58dffd3c11 Merge pull request #27954 from maclover7/jm-fix-26404
47ac2b6dae Add note about breakage in file uploads in controller tests to upgrading guide
d5496c1f06 Fix wording
c509953e2e remove `ActiveSupport.halt_callback_chains_on_return_false` from everywhere
70767472d3 remove link to edgeapi [ci skip]
851a9f1838 Merge pull request #27232 from robin850/guides-linking
322fc9673a Automatically link to Ruby files referenced in notes [ci skip]
e47761d1da Automatically inject the current Rails version in API links [ci skip]
cf950c160d Add information on `:formats` option in action_view_overview.md
87f8d2d6bb Fix typo in guide: _articles should be _article
401d5109f3 Added warning for reserved YAML keywords.
ed84890d6b Fix judgement spelling [ci skip]
d7bf2855fe Bump bug report template versions to 5.0.1
6798612957 Action Mailer Basics clean up [ci skip]
442cb724d3 Clean up wording in Action Mailer Basics [ci skip]
e2344505e9 Mention ActiveRecord's config.example.yml
e938069f7f Various style + grammar fixes for #27719
059592dafb update links of pluralization in i18n guide
38ce55242a Update ActionCable guide to better describe SubscriptionAdapter configuration.
563307b3c7 allow to pass describe option to rake
37462ea15a Revert "Merge pull request #27686 from koic/friendly_bigdecimal_inspect"
7797445c84 Several representation of BigDecimal has changed in Ruby 2.4.0+ [ci skip]
15dc4fa693 Add duration constructors for use in Numeric extensions
57463e2e22 Merge pull request #27610 from Envek/fix_and_speed_up_duration_parsing
649e52d67f Fix inconsistent results when parsing large durations and constructing durations from code
f53d2d1d1b Add missing release notes entry for https://github.com/rails/rails/commit/f02a35b86efea24f1e2ab684bc8081ced5eb3b1a [ci skip]
983452d3e7 Merge pull request #25427 from eugeneius/update_increment_documentation
f589899792 Merge pull request #27227 from MQuy/allow-custom-content-type-in-mail-body
8d726aa969 Fix typo in asset_pipeline.md [ci skip]
ebe8ef715c Merge pull request #27446 from zachahn/asset-hash-md5-to-sha256
30b37e2e2b Merge pull request #27552 from jarijokinen/fix-default-locale-code-example
b010751c30 Add instructions for available_locales [skip ci]
20735f94d0 Clarify Bi-directional Associations docs
025f7d80af Update schema cache doc in guides/command_line
8289ad0ca7 Remove deprecated support to passing a column to #quote
55dbc541c4 [ci skip] Rejigger the dublicable? wording a bit.
9564e28fc9 Merge pull request #27346 from utilum/core_ext_guide_duplicable
f7f94cdf4b Use proper output format [ci skip] (#27498)
2453b4e2b3 Revert "Revert "Merge pull request #17943 from jeremywadsack/doc_cache_importability""
f0cf44192c Fix Rubocop violations and fix documentation visibility
03da25606f public methods can be placed after private ones if you want to
046b33a205 Abuse of protected in guides
db9ba938cd Update asset fingerprinting information
ff6b50ced3 Update list of `duplicable?` objects in AS core_ext guide [ci skip]
93189b174b fix typo in getting_started [ci skip] (#27423)
6f410636d9 [ci skip] Update initialization guide samples.
c2f8222a7d Merge pull request #27365 from baweaver/patch-1
579cad0e06 Fix rake guides:generate:kindle error
f66592a583 How to disable scaffolds.scss in generators.md (#27383)
c5c645570e [ci skip] add a section explaining command line arguments for generators
353868d6a0 Merge branch 'master' of github.com:rails/docrails
e866dbba72 Add note on defaults block option
cf669c146a Mention JS Runtime dependency in dev dependencies guide [ci skip].
6ea243dd2c remove deprecated `assert_send` from assertion list [ci skip]
a01e980db3 stop using removed `render :text`
748b69b48b Add changelog for custom content type
1e5e7f216a Fixes #27202, [ci skip]
04449baf2f Fix typo in Rails 5.0 release notes – “when when”
8f70f85451 Add note about step needed to get tests to pass if you implemented basic auth [ci skip]
c1e16fdd2a fix: solves issue#27189
8b609e1cfe Followup of UUID default extension in the docs [ci skip]
cdf11f4fa2 Add link to API documentation
5e57761835 Merge pull request #27143 from sachin21/fix-permission
83c291eae1 Fix a wrong permission
e32c09cebe Change html-scanner to rails-html-sanitizer
2ee0a1a923 Remove mention of SafeErb gem [ci skip]
c1f2cd8894 Updated Sprockets Documentation
28fc6b4a22 Remove mention of deprecated SafeERB gem from security docs for now, prior section already speaks about sanitization as a safety measure. [ci skip] (#27086)
6a8de46480 remove `alias_method_chain` from guide [ci skip]
7e30ea016b Fix small typo in Layouts and Rendering guide. [ci skip]
73437c582c Merge pull request #26905 from bogdanvlviv/docs
12a557ad4e adds support for arbitrary hashes in strong parameters
a49d18301e Update guides/source/active_record_querying.md
10f1bfa42b [ci skip] Expand context on `:cache_hits`.
e5ab8fea1a [ci skip] Add `render_collection.action_view` entry to AS instrumentation
c0ffde2e24 Merge pull request #26982 from bogdanvlviv/started_guide
91e46067b9 Add missing spaces [ci skip]
a04c91666d Fix 'Getting Started with Rails' [ci skip]
1ab0728a15 Use local variable instead of instance variable [ci skip]
c04e541f1b fix typo in Rails Test Runner section
d5d352c70d Remove `Rack::Runtime from console log [ci skip]
aa32e32477 Add missing space in Migrations guide [ci skip]
890770aff1 Merge pull request #26932 from y-yagi/update_doc_about_assets_digest
e961c2f648 update doc about assets digest class [ci skip]
1b817e778e Add more rubocop rules about whitespaces
5d48fe1717 Add documentation for `config.assets.version` [skip ci]
8597d3eca2 fix initializer name [ci skip]
e8737973a2 Add missing `+` around a some literals.
f85062bea5 Update HABTM documentation in guides
bcbd478f82 Merge pull request #26851 from Gaurav2728/update-kindlerb
4abaf95e93 Fix HTML escaping in the guides
cb0dee657d Fix indentation
31967bff3e Generate HTML not plain text
925487f858 Fix plain option in the rails_guides generator
ec521dee61 Fix typo in Upgrading Ruby on Rails Guide [ci skip]
e266a83dc1 update description of Etag [ci skip]
a9d380ed8c Merge release note entry for Date/Time/DateTime extensions
e6f0fbcb08 update kindlerb gem
6238c003ec guides, include note about modifiers when using the CLI.
0330655203 remove trailing whitespace [ci skip]
01b7d55b52 [ci skip] Fix return values of Hash Extensions examples
753fa495fe [ci skip] Fix typo in Guides: Contributing
f6cb611e9c Pull request for ticket 26769 (#26770)
34f450faa3 Introduce a benchmark template [ci skip]
35d693294d Suggested edits
8a271ef984 Improve Action Cable Overview guide
df8128ec07 Deprecated ActionDispatch::ParamsParser::ParamsParser
67608e3f69 Change page:change to turbolinks:load in README.md [ci skip]
24651bb670 Allow the use of listen's 3.1.x branch.
376415d860 add `cached` key to `sql.active_record` event [ci skip]
e04ce334f3 Remove dup distinct from AR query list [ci skip]
43641528d5 Fix typo in 5_0_release_notes.md doc [ci skip]
415adbf74f Merge pull request #26648 from y-yagi/update_description_of_queue_adapter
b96f4a0e46 Removes broken performance testing link from the 2.2 release notes
083b06eb84 update description of queue adapter in test [ci skip]
e71fd04b63 Add info about a502703 to Rails 5 release notes
3a06f01eea Fix docs for allowed params to `get` in controller tests [ci skip]
81a28ee6f8 Merge branch 'master' of github.com:rails/docrails
366e275a07 [ci skip] Fixed commas according to Oxford comma in rdoc and guides
4994188185 Fix small grammar issue introduced in #26382
7b19f33f61 bug report template for migrations (#26488)
0620370944 fixed guide to add correct documentation for partial render 'as' option
2fa5d0d27c [ci skip] Update Levenshtein code with better attribution.
cc8b8d6c61 Merge pull request #26431 from wytesk133/master
8eb2d65e12 Fix table name typos [ci skip]
5a7fbb1c52 update doc about default `cache_store` [ci skip]
768e7a1ab1 :nail_care: [ci skip]
ea40309d6f Merge pull request #26390 from Neodelf/format_mds
0649bed642 [ci skip] Simply formatting documents
974de25006 Document that redirect* don't halt exucution. We explain more on this behavior in 2.3.2, but dont specify that is not halting. Its better to not let developers be caught by surprise. [ci skip]
414cc4f40b Merge pull request #24612 from vipulnsward/fix-li-ol-width
e0f770e7e7 Remove the word "mongrel" from documents
212e80408c Minor grammar fix in engines.md
3d66695813 Update docs for change in transaction callback exceptions
b4a89459ff add Active Job bug report templates to guide [ci skip]
13f225714b Merge pull request #26364 from y-yagi/fix_class_name_typo_in_bug_report_templates
762e938054 Improve Getting Started [ci skip]
31842d4454 fix class name typo
3b0780dfc1 Merge pull request #26362 from prathamesh-sonpatki/add-aj-bug-report-templates
c934f2349f Added bug report templates for Active Job
ad48c7a82a Grammar fix [ci skip]
2e4a614c14 RuboCop is 100% green :tada:
ab21fd1536 Update Jason Zimdars twitter
63a9649ab7 Merge pull request #26226 from schneems/schneems/explicit-public-urls
f3e2d90b5e Merge pull request #26331 from kjellberg/broken-links
0b2b2b29de [ci skip] Broken links in documentation fix
f93451a8f5 Update typo & Make explanation more clear
6ef6ab3d66 Explicitly mention defaults.
ed582d2a89 Address doc style comments from @robin850
af74ece4e5 Fix asset_pipeline.md miss-merge
596bd901f9 Specify version of Sprockets-rails this will be in
d9e1e2d1dc Move default to different initializer
9c9bb1454b [ci skip] configuring.md assets.unknown_asset_fallback
aff30f9187 [ci skip] asset_pipeline.md assets.unknown_asset_fallback
634b1f08c0 [ci skip] Upgrading assets.unknown_asset_fallback
c6f5a3a501 [ci skip] Update branch version in Contributing Guide
25748e2534 Added gitignore to "files & purpose" list [ci skip]
e44258e748 Merge pull request #26288 from maclover7/jm-revert-21995
1aefb61d83 Clarify two ways to set Rails configuration options
a594fc1e30 Add back in `config_for` example
685e32e146 Revert "Merge pull request #21995 from tak1n/master"
82da6dc99c Move `assert_nothing_raised` method to Rails Specific Assertions section [ci skip]
c76bf98d0e Rename the title of comand_line.md in index Remove 'rake tasks' from index
fb2d3d3423 update `is renamed` to `tasks are renamed`
7450e093d5 Remove Duplicated information & fix typo...
7e7d63c934 Merge pull request #26249 from rafamanzo/add_redis_to_development_dependencies
b3389eb868 Remove the SchemaDumper options and change the default behavior
93b4957c8c [ci skip] Update docs with Action Cable Redis dependency
5247c4b73e Remove `:action` and `:controller` segments from routing guide
2a873ed476 Merge pull request #25750 from go2null/go2null-test-directories
e27d1db002 Clearly state purpose of test directories
3b3f536863 Change form of table name to plural in query example
bf852092be Merge pull request #26241 from scottyantipa/query-interface-docs
565fe74ec1 Merge pull request #26234 from y-yagi/remove_unnessary_session_store_setting
55fee082fc Update docs for query interface to not declare that all methods return instance of ActiveRecord::Relation
80b6cd7477 Merge branch 'master' of github.com:rails/docrails
1bd5e01f34 Merge pull request #26227 from alexcameron89/syntax_highlighter_fix
e05bab15f9 Increase margin-bottom for doc's code syntax highlighter
d090c6ad65 remove unnessary `session_store` setting
0caab70bf0 Merge pull request #26224 from jonatack/consistent-asset-precompile-examples
855ce599aa Consistent examples and template for assets#precompile
6ecfe752a0 When referring to Rails, be consistent in usage of capitalized form, unless it is used in context of a command like bin/rails or the rails directory [ci skip]
bf8edfca6d Grammar changes on getting started guide, specify where exactly the example is that we are referring to. [ci skip]
c7c77d2d14 Merge pull request #25675 from TimPetricola/schema-no-standardized-column-widths
fd01d7fe56 [ci skip] Updates ActiveJob guide on default runner.
dacee5004f Merge branch 'master' into schema-no-standardized-column-widths
7cede3d322 i18n documentation for required belongs_to message
5243914cd4 Fix #26187
88bae25ad1 Fix diffrent naming in getting_started.md
2a2301ad7d Option not to line up column types and attributes in schema.rb
646dca6f35 Fix link in Rails 5.0 Release Note [ci skip]
5b96434a26 Merge pull request #26061 from malclocke/specify_ar_message_interpolation_names_in_i18n_guide
a81523a822 Merge pull request #26175 from stomar/upgrade-guide-fix
79f2b4eb1c Add three new rubocop rules
8e15dd44ff Clarify use of update task on 4.2 and earlier [ci skip]
3c8ff6bd69 Clarify migration to ApplicationRecord in upgrade guides [ci skip]
c4aef6686b fix usage of pluralized word
f8d3d77ac2 Update increment! documentation [ci skip]
d52a90eb37 Revert "Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]"
55f4cd2251 Merge pull request #26163 from olivierlacan/clarify-autoloading-disabled
bff4de9828 Clarify and fix typos in Autoloading Disabled upgrade guide [ci skip]
1fad2ff8d9 Fix the documentation for configuring `enable_fragment_cache_logging` [ci skip]
66e88edd91 Fix remaining broadcasting_name example from Action Cable guide [ci skip]
0cce0a4198 [ci skip] Fix documentation wrong for ActionCable
bcc4901b3a [ci skip] Fix documentation for ActionCable::Channel#broadcast_to
1922e27c60 Merge pull request #26110 from aditya-kapoor/minor-doc-fix
8b3f9e026f Minor doc fix related to ActiveModel::SecurePassword [ci skip]
cbeb79abde Add documentation for `http_cache_forever`. [ci skip]
51ad3cb8bc Fix broken alignments caused by auto-correct commit 411ccbd
c540d2ba4e Merge pull request #24476 from vipulnsward/24314-eagerloading-doc-update
e63964bd82 Document know limitation about using `references` in conjunction with eager loading causing it to ignore custom select clauses.
29bdd809a1 Merge pull request #26042 from bogdanvlviv/debugging_guide
b114b74bc3 update list of rescue_responses default [ci skip]
23cdba4cd7 Add link to 'Pry' in debugging guide [ci skip]
1171edfc46 Modify LogSubscriber for single partial's cache message.
c3460d706f applies remaining conventions across the project
b47a2afbc9 normalizes indentation and whitespace across the project
3f711e38b2 remove redundant curlies from hash arguments
c5045214af modernizes hash syntax in guides
e97fa11ea8 applies new string literal convention in guides
794199f373 Merge pull request #26023 from tekin/correct-acceptance-guidelines
b01b38394d [ci skip] Fix broken URL in guides
b44aeaf856 Add note about limitations of Windows Subsystem for Linux
6c6248ec93 List names of error interpolation variables.
dd76b90d32 Add 4.2.Z back to the maintenance list
829bd948c2 Merge branch 'master' of github.com:rails/docrails
abbbc7f2f4 Correct usage for acceptance validator in guide
677f956eb0 remove old links from debugging guide [ci skip]
8c289ecc98 Merge pull request #25948 from chetna1726/docs
1b037e0eb3 Updated getting_started guide to reflect the change in error message for ActionController::UnknownFromat in ArticlesController#new
3fde16288e [ci skip] Add documentation for error using select with order
e3cdb04e0c Merge pull request #25928 from mechanicles/info-for-cache-fetch-block
a6c385cf4f Proper description for `Rails.cache.fetch` [ci skip]
e88332e10f Merge pull request #25908 from mechanicles/derives-from
3055c4ba58 Explain meaning of the code very well and Remove confusion. [ci skip]
85f0ca21e6 define Range#match? if Ruby < 2.4
c8521afddc Removed reference to callback_terminator.rb in docs
8c736ee9c1 Merge pull request #25438 from prathamesh-sonpatki/rm-session-store-initializer
224432c872 Merge pull request #25780 from Ropeney/patch-1
210ba7d901 Fix documentation of `error_on_ignored_order` option
b3b5e6660d Setup default session store internally, no longer through an application initializer
edda338d8c Update references generation docs to exclude index
45aaa945f9 add missing braces [ci skip]
a0b0b62572 Fix broken link
4bba204d88 Fix display of unsorted list in release notes of 5.0 [ci skip]
0a28016a43 fixes a link in the release notes of 5.0 [ci skip]
acfae4c7e3 finders guide: updates the section about batch processing [ci skip]
4ee9cb314f Merge pull request #25748 from CodingItWrong/generator-field-types-link
351ceae94e Correct link for model generator field types
71fbf7b537 [ci skip] Update redirecting links in guides
9d454b80a8 rails -> Rails [ci skip]
4faa50db80 Update ActionCable Rebroadcasting a Message documentation
8a1a7db9ff The `to_query` method on Array objects uses `key[] as the prefix, not `_key_[]` [ci skip]
343f727ee2 Add `config.assets.quiet` to configuration guide [ci skip]
5d87e23f7d Add note about `config.annotations.register_directories` option in the guides [ci skip]
daa7d9ab3b Merge branch 'master' of github.com:rails/docrails
69619c30f5 Fix typo: caches_pages to caches_page.
1f31575e49 update doc for prefer require_relative over require + File.expand_path [ci skip]
d50567e148 [ci skip] Remove reference to Rails 4 in the initialization guide.
56d0585938 Merge pull request #25708 from maclover7/jm-master-bugreports
8cda5bec79 remove `-t` option from default sendmail arguments [ci skip]
8b22218e48 Fix documentation for number_with_precision helper in AV guide [ci skip]
7fdb843256 Bump version for master bug report templates
c7944ef27a Add header demarcation to Action Cable guide
a5f9347ab4 Merge pull request #25663 from vipulnsward/updated-syntax-highlighter
f5e6ea86f1 - Update Syntax Highlighter to version 4. - Build Syntax Highlighter based on https://github.com/syntaxhighlighter/syntaxhighlighter/wiki/Building and use theme generated by fxn. - This also bundles these brushes in the file itself- ruby,css,xml,sql,javascript,plain. Generation command used: gulp build --compat --brushes=javascript,ruby,xml,sql,plain --theme=/Path/To/RailsSource/rails/guides/assets/stylesheets/syntaxhighlighter/shThemeRailsGuides.css - rm all old js and css files - Moved over how JS configuration is created for Syntax Highlighter - Fixed layout for all imports - Fixes bug with old copy paste, generating wrong space character on webkit https://github.com/syntaxhighlighter/syntaxhighlighter/blob/7caa9632e7fe470d944fc06b4db7d35352ebaa36/src/dom.js#L227
864dca76ab Expand on Instance variables section with an example and specify when the instance variables are set.[ci skip]
b4071492eb Update Rails 5 release notes with syntax fixes.
735e10e66b Correct guide generation command [ci skip]
f4afaec3fd Fix number_with_precision documentation for precision [ci skip]
f61d36ef0e Deprecation passing of `start` value was removed [ci skip]
30b6fe5f56 Mark Testing Guide as pubished and reword the title[ci skip]
f4bb0d1376 [ci skip] Fix Typos and Punctuation in Guides - Upgrading
23539d48ba Add a Rails 5 release note for ActionController::Live becoming a Concern
90c76b4eed Add an upgrade note related to ActionController::Live becoming a Concern
f284af0dcb Fix styles of headings to follow guide rules
10d5286fe2 Change wording & punctuation in Guides - Upgrading
831f5d8ba2 fixes config value [ci skip]
b2f3e063fa expands a bit a section of the upgrade guide [ci skip]
189e327710 Merge pull request #25587 from vipulnsward/publish-release-notes
69ef8c780f Merge pull request #25596 from prathamesh-sonpatki/testing-guide-50
5ecfa85512 Merge pull request #25598 from prathamesh-sonpatki/release-notes--1
aeab03ee2c Add a note about autoloading being disabled in production env in upgrade guide [ci skip]
7993111ec5 Update upgrade guides
af6e70dd1d Update release notes for 5.0 [ci skip]
bb1454f1f4 Update testing guide for Rails 5 release [ci skip]
aee05b5395 Update getting started guide for Rails 5 [ci skip]
f1eeb3dbfb Merge branch 'add-test-runner-to-release-notes'
5a068a2a37 Add test runner features to release notes [ci skip]
a07f63901f add missing things to release notes [ci skip]
940c2cd648 Expand on #24071 for specifying custom locale fallbacks. [ci skip]
a2be7e9710 Publish Rails 5 release notes[ci skip]
2f682dd3c8 Merge pull request #25583 from vipulnsward/add-api-apps-to-release-notes
c1d4b2677f Add API Apps to release notes[ci skip]
daee2562c8 Fix release notes link
cbaf8a949f Merge pull request #25584 from vipulnsward/upgrading-guide
76be7a05d3 Pass over Upgrading guide [ci skip]
b5fe4e70d5 Add note about release notes in upgrade guide
7d694aa702 Update release notes about legacy `mysql` adapter
572e36f859 Update Rails 5 upgrade guides
5370022788 update description of `test_order` [ci skip]
8d31305a73 Clearify CHANGELOG for #23011 [ci skip]
9403fc9168 Add #16917 to 5.0.0 release notes
75477201c7 Merge branch 'master' of github.com:rails/docrails
4a44f1b3de remove unecessary comments [ci skip]
985c87a289 Tiny documentation fixes [ci skip]
cf18972d3d Update grammar for `config.enable_dependency_loading` docs
70658fd9c3 Add option to enable dependency loading in production
8862a60ba5 update_url is not `get` most of the times [ci skip]
f4f3aaf116 Merge pull request #25450 from prathamesh-sonpatki/fix-testing-guide
10b6a103a8 Fix the docs for supported keyword args for Rails 5 style integration controller tests [ci skip]
ef54dd15a9 [ci skip] correction in command for generating api documentation
55acea4e7e Make log tags example for ACa more generic and not BC specific [ci skip]
24d5d6a676 [ci skip] When instance_reader is false, attribute can still be assigned by the instance objects
17cf66330b Example had results the wrong way round [ci skip]
7bbb0fa7b9 Add Rack doc link for request and response object [ci skip]
e598ae0def [skip ci] Fix typo and simplify after_commit example
213e729b9e Changed ActiveJob::Base to ApplicationJob in the Active Job guide [ci skip]
44b9f00f38 Add missing things to Rails 5.0 release notes [ci skip]
df9faefe1d Action Cable routes are enabled by default now [ci skip]
39fd7daaca Merge pull request #25321 from prathamesh-sonpatki/update-release-notes-1
23f1bbe318 Merge pull request #25315 from schneems/schneems/inclusion-doc
61f8dc05ee [ci skip] Expand information on message options
eea0ea0102 Merge pull request #25327 from prathamesh-sonpatki/add-5-0-notes-to-the-index
0c652b38d5 Add Rails 5.0 release notes to the index page of guides [ci skip]
bc8a4262e0 Merge pull request #25323 from vipulnsward/ac-release-notes
5abf2ebf3d Expand on AC introduction list [ci skip]
bb6ec6763e Add Action Cable introduction to release notes [ci skip]
6e7afd0b50 Add missing things to release notes [ci skip]
6511698b8a Do not suggest nonsensical OpenSSL verify modes [ci skip]
da2c112df1 Merge pull request #25279 from maclover7/jm-add-backticks-1
8cccf83a9a [ci skip] Update redirecting links in guides
5e603627c2 Merge pull request #24071 from meinac/configuring_md_docs
7bfe2be6d0 Add backticks to `ActiveRecord::Base.where`
2ea9981b06 Merge pull request #25278 from mechanicles/fix-link
9400abf161 [ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community.
38c370c83e Merge pull request #25277 from mechanicles/remove-pratik-from-core
cd81966bc9 [ci skip] Remove Pratik Naik from Rails core team info.
6928f0dd11 Merge branch 'master' of github.com:rails/docrails
ae6074f052 [skip ci] Make header bullets consistent in engines.md
350d77e187 add missing "as"
9674b500f6 Grammar fixes for Contributing guide
13d5fe9c14 `will be` --> `is`
6013b0bbd5 [ci skip]Fix wrong require path raising LoadError
92ac027b9c rename enum_prefix and enum_suffix options to _prefix and _suffix [ci skip]
4d81db68ca Light edits to Action Cable Overview guide
5730e2e387 fix incorrect class name [ci skip]
73ae56bbc3 Use `add_index` instead of `execute` in guides [ci skip]
7818ab0001 cometic updates to security guide - fixes #25058 [ci skip]
f01b47a7f5 [ci skip] Fix ActionCable Guides
6c03ab3bca Docs: Clarify when assoc. methods persist
598aebd691 autoloading guide: specify autoload paths are set when the app boots [ci skip]
12c558d1ae - :scissors: space in code to match previous defaults. - Grammar edits.
cec9c266b2 remove deprecated `Module#qualified_const_` from guide [ci skip]
b4f2cba147 Update i18n guide about how to change locale and translations paths [ci skip]
8cb3b6aed2 Small grammar fixes for Action Controller Overview
3d0d5657b5 Use #distinct instead of #uniq in the guides [ci skip] (#25098)
c97e9a116d Merge pull request #25092 from y-yagi/add_23980_to_release_notes
8676b3764f add #23980 to release notes [ci skip]
33efd91f06 fix module name [ci skip]
8e4585b9ec Support for unified Integer class in Ruby 2.4+
c33ee883dc Light grammar edits to beginning of Routing guide
19a470c8b6 Add tick marks + small grammar change
96b761ad32 Merge pull request #25052 from matkoniecz/2008_is_not_recent
080dbe0107 Safari 4 supports http only cookie (#25053)
f83a4bc244 Merge pull request #25039 from maclover7/jm-capitalization-2
1a14ebc579 update to make it less obvious that this guide is from 2008/2009
8e7bcd1435 Add Attributes API to release notes [ci skip]
df92b48483 Fix security guide capitalization errors
de8194e089 PerRequestDigestCacheExpiry middlware was been removed. Removed traces, for the same. https://github.com/rails/rails/commit/23b6a9c0fcb8992e18450d6fe0680bf09685b7db
af411579b8 Merge pull request #25036 from maclover7/jm-capitalization
495d79bde2 `md5` --> `MD5`
a26c52ba6b Update the Rails security guide
d74cb12718 Pass over API Apps guide grammar. [ci skip]
e9a9da7fb3 The `ActiveRecord::ConnectionAdapters::ConnectionManagement` and `ActiveRecord::QueryCache` middlewares were removed with `Executor` addition on d3c9d808e3e242155a44fd2a89ef272cfade8fe8 Removes traces and reference of these from all places. [ci skip]
14fae9644a Change output genereated for middlewares on a new application. This has changed quite a bit after Executor middleware addition. [ci skip]
2c5a0b6893 Add `ActiveRecord::Migration::CheckPending` to default middlewares for API Apps [ci skip]
919b592f25 Merge pull request #25002 from maclover7/jm-add-actioncable-guide
d7af3e6198 edit pass over the cable guide [ci skip]
93d0a434b3 Merge branch 'master' of github.com:rails/docrails
214eff2ef8 Add output snippet from `ActionController::API.ancestors - ActionController::Metal.ancestors` command for api apps. [ci skip]
58fe5c7d43 Add Action Cable guide to list
733b7221a5 Getting Started Guide: Add invoke test_unit to files table [ci skip]
e376c0dd7d Getting Started Guide: Add channels and jobs to app purpose table [ci skip]
deb7180999 Getting Started Guide: Update Ruby version to 2.3.1p112 [ci skip]
ba237809d4 Remove ambiquity in what we are referring to in the documentation of config vs configuring the server itself
9abb9cfbdc Document config.action_dispatch.ignore_accept_header and config.action_dispatch.x_sendfile_header in configuring guide
b951cd31c1 More missing true literal quotings
801f2c76cf Lets be consistent in the usage of true/false across this guide. It should be quoted as how other config options are. They are already quoted at many places. This change, makes this usage consistent. Note that, this is quoting literal values true and false, not truthy values
0fe4954b05 Document missing smtp config over at configuring guide. [ci skip]
2c74749646 This config still applies for Rails 4 Apps and we need to mention it, what was needed before. [ci skip]
91a095fdba Minor syntax change
38ddaea387 Update Ruby report templates
cd9766db4e Start Rails 5.1 development :tada:
4cba13d6ab Grammar corrections to Getting Started Guide [ci skip]
844bf43d81 Asset Pipeline: Remove outdated comment about `config.assets.digest` [ci skip]
66f7ab56a0 Asset pipeline: Remove documentation about outdated `config.assets.compress` option
237820ac86 Merge pull request #24911 from meinac/change_http_to_https
056c026870 Use consistent term [skip ci]
fa27ed381d Change http github links to https [ci skip]
b827c86652 change cable.coffee to cable.js [ci skip]
a28dcc09ef Merge commit 'fbdcf5221ad7ea3d40ad09651962fc85d101dd67'
e985a0e673 http --> https
b3aefe3046 Preparing for 5.0.0.rc1 release
d5b7459b5b Release notes: Add a note about `use_transactional_tests` in the deprecated section of Active Record notes [ci skip]
0bc6b57b20 Fix broken links in 'Ruby on Rails 2.3 Release Notes' [ci skip]
052af04ad9 Fix link in 'Configuring Rails Applications' [ci skip]
92286f4418 Fix link in 'Ruby on Rails 3.0 Release Notes' [ci skip]
2dab102c05 Fix markdown syntax in 'Ruby on Rails 2.2 Release Notes' [ci skip]
ab8c454af7 Release notes: Add PR #24866 to release notes
0a02eb9320 Merge pull request #24799 from prathamesh-sonpatki/18439-followup
af8d63ba41 Active Model: Improve CHANGELOG and documentation for `validates_acceptance_of` [ci skip]
c250aaca79 Remove extra space [ci skip]
29305c41e6 s/words_connnector/words_connector/ [ci skip]
b9602b26c9 Release notes: Remove duplicate entries [ci skip]
7dd3e268cc Replace ActionDispatch::LoadInterlock with ActionDispatch::Executor in guides [ci skip]
c002b1f92c fix incorrect module name [ci skip]
b3d838f382 add #24385 to 5.0 release notes [ci skip]
05e136e7a2 Update configuring.md with colons and periods
bb13c76710 Consistent spelling of "gzipped" [ci skip]
d4d88b42c2 Fix typos in asset_pipeline.md [ci skip]
b9c48b72a1 Merge pull request #24786 from vipulnsward/document-gzip-assets
f303c083c0 Document config.assets.gzip flag. Follow up of https://github.com/rails/sprockets-rails/pull/342.
9f605e1522 Merge branch 'master' of github.com:rails/docrails
628598e9fb Merge pull request #24776 from prathamesh-sonpatki/aj-release-notes
6311c66bcd Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes.
554d063f82 Merge pull request #24770 from vipulnsward/guieds-type
2fcd3ef0b3 Fix broken links to ryandaigle.com [ci skip]
b5fb292ff6 Pass over debugging guide [ci skip]
33d874a962 Review the `byebug` debugging guide
8fab314ddb Fix inconsistent usage of capital letter in rails generate command examples
cb9361e6e9 Prep Rails 5 beta 4
8528f3adb8 Fix typo in Configuration Guide [ci skip]
57a08e0820 Fix typo in Rails Guides [ci skip]
6baa1480e9 Add #23461 to release notes
8ccfe9013d be specific when the debug_exception_response_format to :api
9b135f3d1a Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip]
0c94cb3062 Mention default values for `debug_exception_response_format` in configuring guide [ci skip]
cced243c29 `debug_exception_format` is set to :api by default for API apps only, not for normal apps.
af804d9eed Add SQL examples for equality and NOT [ci skip]
bbef280a34 Merge pull request #24657 from maclover7/fix-23643-1
09b90ee3a6 Fix small typos [ci skip]
5b9edf00da Add #18323 to 5.0 release notes
70f2f51b01 - Added documentation for ActiveJob queue adapter for a specific job.
ca67be0b6c s/determins/determines/
5776021ab7 Remove reference to unknown method `dirty?` to docs [ci skip]
dbbcf28c0e Add #16917 to release notes [ci skip]
051e19402a Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl needed for Chapters column, instead of leaking to other lists.
9e5c983b49 Merge pull request #24603 from prathamesh-sonpatki/fix-wording-about-adapters-supporting-db-comments
4636f1b4fd Fix wording related to adapters supporting database comments [ci skip]
62ed955a21 Add note about ability to add database comments to release notes [ci skip]
3cb73c739f Merge pull request #22911 from Envek/database_comments
377574f362 documentation for add_references index option [ci skip]
3d4f82b7f2 [ci skip] docs for add_references index option
b9aa9ae61d Add support for specifying comments for tables, columns, and indexes.
f456145c15 Add a note about how to execute 'rails app:update' on 4.2 and earlier [ci skip]
c7aff0aa0e Fix broken link in 'Ruby on Rails 4.0 Release Notes' [ci skip]
01fe741a0c Merge pull request #24557 from y-yagi/update_example_to_specify_ac_mount_path
7345702543 update example to specify the Action Cable mount path [ci skip]
cd7220ad53 Add Attributes API to release notes
d67b7a1eff Merge pull request #24454 from iangilfillan/master
d883959ed0 MariaDB Documentation
fde5cbb9d2 Merge pull request #24536 from vipulnsward/ruby-2-upgrading
2f2342279c Add ruby 2.2.2+ version requirement for Rails 5 apps [ci skip]
e5e4f15996 - Make sure we end sentences - Change from "The Task" to "The Update Task" as referred elsewhere
8a0c2974a9 [ci skip] Add some missing commas
f3f849c0d6 [ci skip] Typo fix. `loggs` -> `logs`
ca09881b73 - Fix typo in config guide, from config.logger section - Make bulleted lists, end properly
850aa7cc03 s/Thoughtbot/thoughtbot/
2532ba2ea3 - Add changelog for new guide: AC overview from https://github.com/rails/rails/pull/23176
376d59d522 - Fixed changelog related to i18 key changes. Added author - Made all sentences to end properly [ci skip]
4738dbfcc9 fix typo in file path [ci skip]
be56ca9f50 Remove reference to non existing link in the welcome page.
bbd194ae81 Clarify fixtures examples [ci skip]
766a7a199e Clarify description of `include_all_helpers` config setting's default behavior [ci skip]
0e6cd07bb6 Fix broken link in 'Ruby on Rails 3.1 Release Notes' [ci skip]
6e4c87e442 Merge pull request #24465 from y-yagi/remove_needless_entry
d5212d08cb remove needless entry [ci skip]
cf7895bdaa Fixes for the strong & weak ETags guide [ci skip]
0f2ae82f97 Merge pull request #24444 from prathamesh-sonpatki/update-message-proc-documentation
5c4a79e858 Update example of passing a proc to `:message` option for validating records [ci skip]
80b7f0baab Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
e7e70fa6bf [ci skip] Fix formatting of code snippet in Action Cable guide
fde72cc323 Merge pull request #24419 from rgm/master
c2d25ef8c9 Merge pull request #24410 from mechanicles/strong-weak-etags-info
ff9448705f Update documentation based on the new changes for strong & weak ETags [ci skip]
739694e0a7 Fix Active Model basics introduction to indicate it only introduces us to integration and not complete i18n framework.
059fd4bfe5 [ci skip] Update code used for filtering passwords in the configuring guide
5310bdd6e0 Guides changes, follow up of #24401
c243cde3b0 it's => its typo
e353e7af04 [ci skip] Fix variable name
bce51d968d Merge pull request #24406 from prathamesh-sonpatki/update-release-notes
c85700e196 Merge branch 'master' of github.com:rails/docrails
016ffc2fe9 Update Rails 5 release notes [ci skip]
f9da2d8397 remove deprecated `datetime_field` from guide [ci skip]
6ebe033c35 Fixes broken link in 'Ruby on Rails 2.2 Release Notes' [ci skip]
0e55d19477 [ci skip] Parameter filter performs regular expression partial matching
36d60327c9 s/documention/documentation/
68b5b1ccbf Update how to clear the association cache
7671f15cfc [skip ci] Update `numericality` validation docs
99a278518e remove old-dead link
e834ef8e87 Correct typos in "Active Record Query Interface" guide
bef06ce084 [ci skip] Added missing custom context validation
1362d44d8b Remove reference to unmaintained plugin/gem
93ea344f58 s/responsibilty/responsibility/ s/symantically/semantically/
face4f7856 - Fixed abrupt start of sentence in changelog
d1c5806a39 guides, sync 5.0 release notes with changelogs
f8744470a3 guides, sync railties and AP changelogs with 5.0 release notes.
dc57d83d7f update Active Job default adapter [ci skip]
8f1c8968e7 remove Rails 4 text from asset pipeline guide
a8d20379a4 use rails 5 favicon.ico for rails guides
f016337896 Document and Match the Rails logger interface
e3e6750a12 Update action_controller_overview.md
ea1dec4d0e Remove log-related stuff from ActiveSupport::Dependencies
4842ab3930 Correct command for generating secret_key_base [ci skip]
5eb2b7cd09 add `queue_classic` to list of provide `provider_job_id` [ci skip]
ecaec8ae31 add headers to payload list [ci skip]
dbe79200ac Clarify has_many :dependent option docs [ci skip]
9ae689127d remove obsolete i18n links from guides [ci skip]
da9fcb33f9 Remove needless `break;` [ci skip]
4943f7793b Remove extra 'the' and unwanted comma [ci skip]
1e9dcc3055 Remove incorrect Rack documentation example
4340d2ec4b Merge branch 'master' of github.com:rails/docrails
e73011bb1c remove entry for reverted commit [ci skip]
fc2da230db Update the rendering guide to match the current behavior
64cf9ee01d Added some useful configuration options into configuring.md [ci skip]
3f7ad062b9 remove config that are no longer needed in sprockets-rails 3
06d3afb7b3 Match Puma 3 startup messages [ci skip]
0a58489597 Fix author callback in engines guide [ci skip]
4f6c0d4ac0 Merge pull request #24021 from y-yagi/add_scaffold_stylesheet_to_guide
d019853c77 add `scaffold_stylesheet` method to guide [ci skip]
69c9953faf [ci skip] Make collection caching explicit in guides.
402520619b Change 'a HTTP' to 'an HTTP' [ci skip]
61cbe7b091 [ci skip] Update all guides with `null: false` change in migrations
17b4b0653f [ci skip] Update getting started guide for chanages in migrations API
9ff2a09860 Changed behaviour of timestamps helper by create_table migration generator [ci skip]
f78fbc9300 Merge pull request #23936 from yui-knk/local_constants_to_be_public
ed8a279273 Merge pull request #23417 from sgringwe/master
5254624244 Deprecate `Module.local_constants`
37da018d92 Merge pull request #23957 from delftswa2016/fix-documentation-stylesheet
c83799c487 Fix typos in Action View Overview guide
6896354dc2 Fix value of CSS background-color property in Rails guide
9dcc09c932 Fix formatting in Action Cable guide [ci skip]
fb27aacea6 Fix merge conflict in Action Cable guide [ci skip]
b4cd1f7cfe Further cleanup of the cable guide
fa1262407e Merge pull request #23943 from y-yagi/remove_rake_word
db6df478c7 Fix typos in Action Cable guide [ci skip]
dbd358f7a5 Merge pull request #23176 from davidkuhta/patch-1
5985919f01 remove "rake" word [ci skip]
bc85259bf1 use `app:update` instead of deprecated `rails:update` [ci skip]
66cccbba22 Merge pull request #23933 from HayleyCAnderson/ha-action-cable-docs-fixes
0c66774edd Add small Action Cable documentation fixes
af555cf905 Update docs to point to new update task.
e0dae25a1c Merge pull request #23439 from ryohashimoto/160203_rake_rails
70be58e92a [ci skip]Add info for specifying logger in different envrionments.
2495af21de [ci skip] fix json output
89b66e6969 The tasks in the rails task namespace is deprecated in favor of app namespace. (e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
c342fd0f74 [ci skip] Remove reference to Rails 4 in the initialization guide.
aa3dbb6c2d Merge pull request #23902 from prajakta-tambe/update-debuggings-rails-app-doc
d4db0ca025 - Changed Debugging Rails Applications doc's logger introduction section. Changed location for specifying logger. [Prajakta, thiagoaugusto]
3e53ef2597 Doc: update AC::Parameters guides for Rails 5
f864277e2b Doc: update routes guides for Rails 5
1ff557d00c Merge pull request #23874 from st0012/update-documents
cca8b13786 Additional review of 6b31761.
d24c4da535 Lock down new `ImplicitRender` behavior for 5.0 RC
f8ff258f3a Add config.debug_exception_response_format into configuration guide
ff55b7dd62 Update config.force_ssl's documentation
afd5b4ca90 Enable Action Cable routes by default
52244fbd9c [ci skip] Need to mention debug_exception_response_format in the api_app documentation.
f1c846eac3 Updated file documentation [ci skip]
7012fc4bae Merge pull request #23860 from zerothabhishek/weak-etag-guide
3d21641349 changes caching guide to add note on weak etags
d79b7d631c Merge pull request #23857 from st0012/update-documents
0c9cda0367 Fix wording and wrong reference
26bc06363b Fix ActionView's cache section reference
0dbfe644b6 Add caching guide in ActionMailer basics
73851ce2ec Add ActionMailer configuration options
0d7dd991fe Preparing for 5.0.0.beta3 release
94b9b5cf81 Update 5.0 release notes
470c3cb761 Merge pull request #23795 from claudiob/replace-rack-with-rails-command
dd5e49d699 Header Typo
e550084930 `stream_for` example
6e9b41cf7d Merge pull request #23836 from sstephenson/turbolinks-5
f5344ed147 Explicitly denote that channel.rb is a default file.
d59fcb17cf Change ActionCable.server.broadcast to XChannel.broadcast_to
66ae3d96df [ci skip] No hyphen in 'side effects'
255928206e [ci skip] Fix typo in Form Helpers Guide
c21ed852c5 Update JavaScript guide for Turbolinks 5
50500f5fed Switch to `data-turbolinks-track="reload"`
3c60f96191 update assert_nothing_raised in testing.md
2b4c84ece3 Add a note about downcasing submit tag
cd95ce7eab AppGenerator: Replace 'rake' with 'rails_command'
48d21733d5 remove needless `debug_exception_response_format` config [ci skip]
f41750e005 partial pass over the API guide [ci skip]
65360d348c Remove github gems from the master bug report templates
f009f3cdcb [ci skip] fix suggested change-replace 'an' with 'the in Rails engine guide'
4aa5ebeba3 Fix the language in engines guide
da0c20daf4 Add Action Cable CHANGELOG in release notes [ci skip]
2d0534b3bc [ci skip] Updating edge rails guides to include `on_weekday?` on Date, Time and DateTime
d2e4a395af reset `ActionMailer::Base.deliveries` in `ActionDispatch::IntegrationTest`.
275f4e46ec Merge pull request #23688 from meinac/guide_typo_fix
708c95a181 Fix small typo in Rails guides [ci skip]
65f741c840 Merge pull request #23687 from vipulnsward/add-on-weekday
e1729646dc Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`.
e3cfe73b22 Create action_cable_overview.md resolves #23176 [ci skip]
86a5a95237 [ci skip] fix typos
7adc7133b2 [ci skip] Update 'Testing Active Record'
42c8828db0 restores the guides layout header [ci skip]
b50f4f8dcc Merge pull request #23660 from meinac/change_x_gzip_to_gzip
175528f56f Change x-gzip to gzip in docs [ci skip]
37d35c3cab Merge pull request #23654 from kamipo/fix_grammar_a_to_an
757f3bbacb add missing name option to flash test example [ci skip]
573ddadf2a Fix grammar `a` to `an` [ci skip]
470d038451 Use correct path in documentation.
a7d9932676 Merge pull request #23612 from vipulnsward/23561-fix-routes-args
b5d4cc9fc8 - Fixed and removed long arguments to rake routes - Fixed related documentation and usage all around
a740900b5a Fix numbers of steps to upgrade Rails [ci skip]
51ee3845b9 Improve wording in documentation change
6d972542ff Document the upgrade process
7c01b140d7 Update active_record_querying.md
068115680b Merge pull request #23583 from brchristian/penultimate
034dfb8f84 rename to 'second_to_last' and 'third_to_last'
cd8b83c79f Fix typo
4967562889 Fixed grammatical errors in rails docs [ci skip]
c6e0dc6730 allow Array.penultimate and Array.antepenultiate access methods
311da81ac4 Update documentation regarding initializers [ci skip]
e73e6f8deb remove description of `render :nothing` from guide [ci skip]
b7f51e6ee0 [ci skip] Fix grammar
8596df17c8 Fix a typo
c575016634 Remove references to Rails 4 from assets guide [ci skip]
a912a086bf update turbolinks url [ci skip]
245e2d01c4 doc changes
e06e01d64a Publish guide on "Using Rails for API-only Applications" Fixes #23322 [ci skip]
6da169d8df Separate for new and existing applications clearly
e9d411d4d3 Merge branch 'master' of github.com:rails/docrails
7a05f517fc Change the default adapter from inline to async
52d8eb54ce Check off some todos for the Testing guide with @senny [ci skip]
698678fec2 docs, remove trailing whitespace from testing guide. [ci skip]
fc2ef642b3 docs, link Rails specific assertions to the API. [ci skip]
a01160d9af add missing include to engine test example [ci skip]
eea3629877 SQLite 2 support has been dropped [ci skip]
fa450a4907 Merge pull request #23442 from prathamesh-sonpatki/improve-pg-version-old-error-message
547754606e Merge pull request #23447 from y-yagi/update_pg_supported_version_in_docs
44eb518c22 update supported version of PostgreSQL in docs [ci skip]
94051a614a Merge pull request #23436 from y-yagi/use_bin_command_in_routes_task
0f9229747f Mention PostgreSQL version support in release notes [ci skip]
2aa13170da use rails secret in rails guides
bab266fab6 use rails command in routes task
4a4325769a Add initial support for allowing an error on order or limit of queries being ignored in batches
21cc2eacc2 Fix typo.
8b969f2c26 Change command_task.rb to commands_task.rb in docs
34a5a1deb9 Preparing for Rails 5.0.0.beta2
9e2b1572a9 Merge pull request #23225 from vipulnsward/20420-rake-routes-options
fe82c27dc3 Merge pull request #23406 from hackerkid/master
114ecbefdd .git added to https repo urls
d739126913 Merge pull request #23151 from maclover7/fix-23148
8138e8f999 Add options for rake routes task
e66fb7793b git protocol replaced with https
672f2f15ed Add documentation for #17573
03e70140b2 Merge pull request #23375 from prathamesh-sonpatki/fix-19835
3dadcb8301 Fix documentation related to `config.assets.cache_store` [ci skip]
afabeeb3dc Revert "Merge pull request #23366 from maclover7/add-configuation-ar-docs"
4b0a78ebc6 Merge pull request #22857 from bdewater/interlock-doc
212d9d2cd4 Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
ad640360d3 Merge pull request #23368 from y-yagi/remove_backward_compatibility_code_for_minitest_4
280fff23ae Remove odd ` [ci skip]
6ed8a7b24a Add configuration section to "Active Record Basics" guide
24f203bfd7 Small cleanup to Testing Guide
5494a57b20 Merge pull request #23358 from vipulnsward/testing-guide-pass-3
827704debc Pass 3 over testing guide - Various grammar fixes - Added assertions for update controller action tests - Added user helper tests - Fix typos
8c6f25cfa3 typo fix [ci skip]
b788307f20 [ci skip] fix typo
4703275aee remove backward compatibility code for Minitest 4
5f0999802f Merge pull request #23317 from rfmanuel/after-bundle-in-rails-plugin-template
e56604e898 Implemented pull request changes.
1b6c0f8eec Getting Started Guide: Update Ruby version to 2.3.0p0
5f6bcfe148 Docs review of api_app.md
3ea65c68da Remove Rack::Lock from the API guides
2786734007 Middleware have no plural
cfea1d96a1 Mark API guide as work in progress
94e43b4718 Put "Using Rails for API-only Applications" in table of contents
cdc253a35f Update doc with appropriate issue and pull request versions
be7a1532fa Add an after_bundle callback in Rails plugin templates
44fed8404c Merge pull request #23237 from gsamokovarov/new-welcome-page
740717dabe English explanation to multi-level nested join
b5290d99eb Fix typos in asset_pipeline.md
27c1316a6a remove duplication section [ci skip]
48feb3757d Introduce new welcome page for new projects
95a44c2c59 Merge pull request #23208 from vipulnsward/testing-pass-2
8bcb9988c2 Merge pull request #23210 from sachin21/change_permission
28c72f0198 Update the exception of format constraint in routes
3528a585ca Pass 2 over testing guide - Grammar fixes - Wordsmitting - Fixed wrong statement about association usage in fixtures - Changed association name from 'one' to 'first' instead - More consistent usage of we/our - Mentions assert_select is below, not already covered in Integration test.
c3b21ad9a2 Change permission to readonly
05e271fa36 Merge branch 'master' of github.com:rails/docrails
07b00f7c74 Rails 5.0+ rake commands implemented in Rails Framework itself. We prefer to use bin/rails instead of rake [ci skip]
851195d671 Merge pull request #23177 from vipulnsward/testing-pass-1
74c8045c56 First pass over parts of Testing guide - Grammar improvements - Consistent usage of you or we in sentences - Tests can have zero or more assertions. Its not mandatory to have one. - Example for assert_send
9ae192956a [ci skip] fix #23157
1471a43d91 insert newlines into code samples
00419c2481 Merge pull request #23125 from Gaurav2728/update_puma_as_webserver
03652d8b59 [ci skip] update guide for Puma web server instead of Webrick
9f02f59455 - Changed from bin/rake to bin/rails at more application places. - Only ones left are from the upgrading guide, and command line guide explicit section about rake
977670a47b use bin/rails default instead of rake commands [ci skip]
098f157825 - Remove dead links and take users to just the home page instead - Add new logo for guides header [ci skip]
2d6cda07fc Merge pull request #23117 from vipulnsward/22297-ar-exception-raise
705266138e Mention that halting chain does not re-raise `ActiveRecord::RecordInvalid` exception as well, similar to `ActiveRecord::Rollback`
f3a3a1b167 Make text about render :html option clearer to state, text will get escaped if not marked as safe by using html_safe
3b0cac4f7a Fix discrepancies in associations guide [ci skip]
7ccbab9637 `ApplicationRecord` instead of `ActiveRecord::Base` in Association Guides [ci skip]
4aa3d9552c Merge pull request #23099 from vipulnsward/change_start_at_end_at
bca9639f9b Association Guide replaces Order as example with Author-Book Example [ci skip]
c64992b486 Merge pull request #22705 from RochesterinNYC/add-order-explanation-to-first-last-guides
4046d1c51b Merge pull request #22394 from j-dexx/update_association_basics_guide
8644760f4e Updated the guides for having a distinct has_many through at the database level
3c22811299 Explain how HStore columns can be queried [ci skip]
53fbcccfe3 Changed options for find_each and variants to have options start/finish instead of start_at/end_at based on comments at https://github.com/rails/rails/pull/12257#issuecomment-74688344
df0e5bf8e1 [ci skip] fix typo in docs
76224212a8 Add a note on ActionController guide about 404
26bf26d0f3 Merge pull request #22983 from bronson/update-mysql-in-guides
2c24e1affc Merge pull request #21995 from tak1n/master
d1fc42eb79 remove legacy mysql from guides to match #22715
83fb03a163 rake log:clear task updated refs[#22544]
b9754f0b11 Merge pull request #22275 from mastahyeti/per-form-csrf
84cfce2f42 Merge pull request #22922 from vhf/add_fpb_back
e92b120718 Add job suffix to sample's job file name
8bfdd30d79 [ci skip] Update doc/resource link removed by #21211
e19b65e3a8 add option for per-form CSRF tokens
70e01db90f Update the maintenance policy for the next release.
faa3fcf6a3 Remove duplicate entry for ActiveRecord::Relation#cache_key from Rails 5 release notes [ci skip]
8f80374230 Fix typo: test -> text
b4200a0aef [ci skip] Update rails/all.rb reference.
9e598e72c1 Merge pull request #22844 from prathamesh-sonpatki/issue_22836
11d864d1af Fix documentation for configuring default_charset [ci skip]
d80b7093de [ci skip] Put all removals in its section
b792faf9de Merge pull request #22053 from Empact/first-loaded
b7c1805d1b Merge pull request #22759 from akshay-vishnoi/human-size-helper
c132e042bd fix link to pr [ci skip]
5416ece9f1 Improve RDoc documentation of ActionDispatch::SSL
3a19ef9ba2 Improve documentation of config.force_ssl in guides
4e7424039b Improve readability of CacheHelper section
06cd2a64b3 release notes, use past tense. [ci skip]
00f7e487e2 release notes, Rails 5 won't support the protected_attribtues gem.
d9403bce5f release notes, extracted notable changes from Active Record CHANGELOG.
1b94a2f1d8 release notes, extract notable changes from Active Model CHANGELOG.
dae85d64b2 release notes, extract notable changes from Active Job CHANGELOG.
1d04b48116 release notes, extract notable changes from Active Support CHANGELOG.
cf36807636 Fix typos in Rails 5.0 release notes [ci skip]
d05b9623e7 [ci skip] An internal link is an relative path
9cd46430ed Fix letter case and grammar in Routing guide
3a688e931e Add support for Petabyte and Exabyte in number to human size
b9a5e6b586 fixes typo in 5.0 release notes
59d61c3fbf release notes, extract notable changes from Action Mailer CHANGELOG.
1402d4caf6 release notes, extract notable changes from Action View CHANGELOG.
806f420678 release notes, use past tense. [ci skip]
3bc17a3eef release notes, extract notable changes from Action Pack CHANGELOG.
9cdcc7fced release notes, extract notable changes from Railties CHANGELOG.
d2c95206b2 guides, restructure Rails 5.0 release notes. [ci skip]
895b18bada Merge pull request #22701 from maclover7/rails-5-release-notes
c424e76765 Merge pull request #22483 from y-yagi/use_bin_test_in_plugins_guide
f1689c8f84 remove content_tag_for example
19eac77f04 corrects a typo
1bbe1fd40a Merge pull request #22709 from jonatack/clarify-explanation-for-new-config-halt-callback-chains
d3e52eceb4 use `bin/test` in plugins guide [ci skip]
a1c6cb2981 Add Rails 5.0 Release Notes
278c85c3bc [ci skip] Fix typo
42751c9e20 [ci skip] No more no changes entries in the CHANGELOGs (cases left in #22718)
a4469e58ed Clarify config settings for AS::halt_callback_chains_on_return_false
77827bee9e [ci skip] `rails new project` generates README.md now
3a12f90bd0 Update README extension in Getting Started guide
0a4c6e7f87 Remove legacy mysql adapter
1b838fd59b Upgrade Guide: Add missing period, :scissors: whitespace [skip ci]
e14d25099a mysql2 adapter instead of mysql [ci skip]
db6df596ca Add clarification about `first` and `last` behavior when using `order` [ci skip]
c6daab8d9d Add CHANGELOG headers for Rails 5.0.0.beta1
82f7952e50 Merge pull request #22462 from lxsameer/i18n_html_wrap
21ff540930 debug_missing_translation configuration added to action_view
ef9aefa7d6 Refer to rails command instead of rake in a bunch of places
09c408a8c5 Fix section about ApplicationRecord in upgrading guide [ci skip]
ebdb4f5fce ApplicationRecord release notes entry
d16329c7e9 ApplicationRecord documentation pass
115acbdeeb Fix documentation about ApplicationRecord
0b6253a06d Merge pull request #22506 from derekprior/dp-redirect_to_back_or_default
af782fb1b4 Deprecate `redirect_to :back`
8764638f3e Add `redirect_back` for safer referrer redirects
f50dbbb0e2 Merge pull request #22567 from gsamokovarov/introduce-application-record
e7d6804ad0 Merge pull request #22611 from existent-co-uk/patch-1
4e6487f7ec Mention the correct way to halt callback chains
d1cff3992a Fix a couple of grammatical errors in security.md
f35c68d6f0 Introduce ApplicationRecord, an Active Record layer supertype
4c1ce263a4 Use a real migration version number in docs
ffca88e3c3 Use a deliberately-invalid migration version in all doc examples
42d3524eb2 Merge branch 'rails-rake-proxy'
e441339beb Implement Rake proxy for Rails' command line interface.
14a8c9dd5f Merge pull request #22572 from prathamesh-sonpatki/fix-paintit-method-in-guides
98dd27c4f6 let config.file_watcher be the way to enable the evented file watcher
f166c2270f [ci skip] Fix articles spelling.
f4967774a7 Fix paintIt method in JavaScript guides [ci skip]
e46cd9bc37 Remove ActionController::TestCase from documentation
af0f38321e Merge pull request #22554 from y-yagi/fix_link_to_coc
9504ffe8dc fix links to code of conduct [ci skip]
55a5f8ab66 Merge pull request #22367 from andreynering/docs-ar-enums
593cedc2fe Mention the debug_exception_response_format config in guides
ae2db3ccbc Adding Enums section to Active Record Querying Guide. [ci skip]
1e5256f7c9 Introduce after_{create,update,delete}_commit callbacks
d8e7b01569 fix doc for rails custom configuration through config_for [skip ci]
bc3cdd78a7 Update autoloading_and_reloading_constants.md
5c8a4cdda2 Merge pull request #22343 from jeffminnear/patch-1
76f00ca798 Modify unscoped usage guide to include chaining
3c5ebe5684 Merge pull request #22427 from eliotsykes/validation-message-proc-doc
396fbafe37 Merge pull request #22283 from the-undefined/routes-error-singular-resource
d2a68e21dd Merge pull request #22315 from takatoshiono/fix-configuring-doc
216ae2f280 Document message validation option accep…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option
endtofind_in_batchesthat complements the
startparameter to specify where to stop batch processing