[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some GPUs with known BENCHMARK results and higher tier are unrecognized, get FALLBACK and tier 1 in at least Windows + Chrome #121

Open
KellyWalker opened this issue Jul 9, 2024 · 1 comment
Open

Some GPUs with known BENCHMARK results and higher tier are unrecognized, get FALLBACK and tier 1 in at least Windows + Chrome #121

KellyWalker opened this issue Jul 9, 2024 · 1 comment

Comments

@KellyWalker
Copy link
Contributor
KellyWalker commented Jul 9, 2024 •
edited
Loading

We have seen the following GPU names detected on Windows using Chrome 126.0.0:

  • nvidia, nvidia quadro gv100 (0x00001dba) (ANGLE (NVIDIA, NVIDIA Quadro GV100 (0x00001DBA) Direct3D11 vs_5_0 ps_5_0, D3D11))
  • nvidia, nvidia geforce rtx 3060 laptop gpu (0x00002520) (ANGLE (NVIDIA, NVIDIA GeForce RTX 3060 Laptop GPU (0x00002520) Direct3D11 vs_5_0 ps_5_0, D3D11))

If I understand the benchmark data correctly, in both of these cases the base GPU (nvidia quadro gv100, nvidia geforce rtx 3060 laptop gpu) have entries that should allow them to be tier 3. I have also seen some code (e.g. src\internal\cleanRenderer.ts) that strips off some of the extraneous descriptors like "ANGLE", "Direct3D11", etc.

Perhaps there needs to be some additional handling to strip more off, or maybe the logic could be loosened to allow for inclusion of a substring rather than exact match (I have not looked into this).
@KellyWalker
Copy link
Contributor Author

I checked out the code and added the GPU name strings from original report above to test\data.ts as members of RENDERER_DESKTOP so that I could run tests for them. Those tests passed. Debugging into the tests seems to show that each is correctly identified as the expected base GPU, then mapped to tier 3 with a 'BENCHMARK' result. Can one of the maintainers let me know if this is a legitimate way to have tested the behavior?

Assuming they are accurate, the test results leave me confused, because I have actual captured end-user data that shows the GPU names from the original report being mapped to tier 1 with a 'FALLBACK' result. I am trying to theorize how that could be possible given my test results. Could it happen if some endpoint used to access benchmark data was inaccessible for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KellyWalker