[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stdout and stderr stream; IO() #68

Open
mehtamohit013 opened this issue Mar 18, 2023 · 4 comments
Open

Fix stdout and stderr stream; IO() #68

mehtamohit013 opened this issue Mar 18, 2023 · 4 comments
Labels
API change Breaks existing API bug Something isn't working

Comments

@mehtamohit013
Copy link
Contributor
mehtamohit013 commented Mar 18, 2023 •
edited
Loading

Currently, when running tqdm and printing inside it, breaks and messes up the output for the user. For now, there is a temporary fix, which adds \n to eliminate this but adds extra new lines. Fix the output and the IO() class in ipython.py

#66 #1080 Summary
@mehtamohit013 mehtamohit013 added bug Something isn't working API change Breaks existing API labels Mar 18, 2023
@idomic
Copy link
Contributor
idomic commented Mar 20, 2023

I believe ploomber itself doesn't use ploomber-engine and we'll probably need to change this to solve #1080

@edublancas
Copy link
Contributor

I believe ploomber itself doesn't use ploomber-engine and we'll probably need to change this to solve ploomber/ploomber#1080

it doesn't use it by default but it can be enabled

@idomic
Copy link
Contributor
idomic commented Mar 20, 2023

Yeah, I think if we want to solve 1080 we have to right?

@edublancas
Copy link
Contributor

Yeah, I think if we want to solve 1080 we have to right?

I quickly looked at the source code. It is possible to use ploomber-engine with ploomber but we need to document it more clearly:

https://github.com/ploomber/ploomber/blob/2a6287f1beea9f51ecbe59ddebac266cef6c77e8/src/ploomber/tasks/notebook.py#LL767C5-L767C5

Currently, if you set the engine_name to debug or debuglater, it'll use ploomber-engine because the original motivation for ploomber-engine was to enable debugging.

With the new features we've added, there are now more reasons for users to switch to ploomber-engine; so I think we should allow engine_name: ploomber-engine to also switch to ploomber engine for notebook execution and document what are the benefits of using it.

@mehtamohit013 mehtamohit013 mentioned this issue Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API change Breaks existing API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edublancas @idomic @mehtamohit013