fix: remove unused imports on EKF.py #413
Conversation
|
Second this MR as it is currently breaking the normal installation and usage of the toolbox 👍 |
|
@petercorke @jhavl Sorry to bother, but could you guys have a look at this? |
|
Can confirm that this is causing issues on conda-forge as well .. |
|
Hi @FelipeCybis, do you know if your pull request is in the latest release of the toolbox? I am experimenting the exact error you all describe in the issue. Best. |
Yep, it should be. You can see the last commit in main is on my fork directly before my fix. |
|
Thanks for fixing this, @FelipeCybis. @petercorke @jhavl should definitely merge this pull request, so the package can be used with the latest version of |
|
I have the same issue on up-to-date Ros2 humble. This is very simple and fixes everything. |
|
Please merge this. |
|
@petercorke @jhavl Bumping this again. This is a critical bug with an easy fix, please merge asap. EDIT: I can see this change has been made already in 2731430 , please disregard |
|
Thanks for flagging this, this has been fixed on future branch to be incorporated in the next release. |
Indeed, in the latest
scipyrelease (1.12.0), they removed the, already deprecated,scipy.randnfunction. (The deprecated warning said they would remove at 2.0.0, but well...).In
robotics-toolbox-pythonthere was one place wherefrom scipy import randnwas called: theroboticstoolbox/mobile/EKF.pybut it was not used. Instead of limitingscipy<1.12.0, I removed the unused dependency (and a few others in the same file).