[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Revision Counter is false by default? #3308

Closed
dbpolito opened this issue Nov 23, 2021 · 5 comments
Closed

[BUG] Revision Counter is false by default? #3308

dbpolito opened this issue Nov 23, 2021 · 5 comments
Assignees
Labels
area/ui UI related like UI or CLI backport/1.1.3 Require to backport to 1.1.3 release branch backport/1.2.3 kind/bug
Milestone

Comments

@dbpolito
Copy link

I installed longhorn using helm chart 1.2.2 (i originally installed 1.0 and keep upgrading).

I didn't change it on my helm chart, so it means it's ~, nor on ui:

image

But all my volumes has it disabled:

image

In docs it says it's enabled by default.

Just out of curiosity as i never used this, how much overhead does it add? 10%?

@derekbit
Copy link
Member
derekbit commented Nov 23, 2021

Revision Counter is enabled by default.
It is an UI typo.
https://github.com/longhorn/longhorn-ui/blob/master/src/routes/volume/detail/VolumeInfo.js#L326

@jenting
Copy link
Contributor
jenting commented Nov 23, 2021

Could you please check the revision counter setting inside the Setting CR?

kubectl get settings.longhorn.io disable-revision-counter -n longhorn-system

The value should be false for disable-revision-counter.
Therefore, the revision counter is enabled by default https://longhorn.io/docs/1.2.2/references/settings/#disable-revision-counter

@dbpolito
Copy link
Author

Yup, seems false:

❯ kubectl get settings.longhorn.io disable-revision-counter -n longhorn-system
NAME                       VALUE   AGE
disable-revision-counter   false   327d

Cool, so it's just a confusing UI that needs improving. Probably just upgrading the label or inverting the if.

@longhorn-io-github-bot
Copy link

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@khushboo-rancher
Copy link
Contributor

Validated on master-head, v1.2.x-head and v1.1.3-head - 12/08/2021

Validation - Pass

The label is changed to Revision Counter Disabled
Screen Shot 2021-12-08 at 12 38 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI related like UI or CLI backport/1.1.3 Require to backport to 1.1.3 release branch backport/1.2.3 kind/bug
Projects
Archived in project
Status: Closed
Development

No branches or pull requests

7 participants