[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method for Spring Boot to configure the new analytics feature #6501

Open
1 of 2 tasks
freddiN opened this issue Nov 8, 2024 · 9 comments
Open
1 of 2 tasks

Add a method for Spring Boot to configure the new analytics feature #6501

freddiN opened this issue Nov 8, 2024 · 9 comments

Comments

@freddiN
Copy link
freddiN commented Nov 8, 2024

Search first

  • I searched and no similar issues were found

Description

I would like to see an easily usable configuration to configure the new analytics feature through Spring Boot.
So far its configurable through the maven client, the config file (liquibase.properties) and via env, but its not configurable through Spring Boot (setting a global env aside).
This would enable the spring boot guys to introrudce e.g. a spring.liquibase.xyz flag.

Steps To Reproduce

Use 4.30.0 through Spring Boot

Expected/Desired Behavior

Having a flag you can set to true or false to switch it on or off

Liquibase Version

4.30.0

Database Vendor & Version

No response

Liquibase Integration

spring boot

Liquibase Extensions

No response

OS and/or Infrastructure Type/Provider

No response

Additional Context

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR (Thank you!)
@lalo-mx
Copy link
lalo-mx commented Nov 8, 2024

Workaround:
System.setProperty("liquibase.analytics.enabled", "false");

@rdhzl
Copy link
rdhzl commented Nov 8, 2024

It's generally disappointing that analytics was made opt-out by default for the OSS Liquibase community. I hope there will be reconsideration about this.

@lbadam
Copy link
lbadam commented Nov 8, 2024

@freddiN thanks for filing this issue. It is something we will take into consideration. With the various workarounds already available it is a lower priority for us right now. To get it in faster, we would accept a PR from the larger community.

@lbadam
Copy link
lbadam commented Nov 8, 2024

@rdhzl I wrote extensively in this PR about our reasoning and why these anonymous analytics are helpful to the project overall. We have provided many ways to opt-out, and plan to continue with the current direction.

@filipelautert
Copy link
Collaborator

@freddiN A flag would be really nice! But even if we open the request now it will be present only in the next springboot version, so meanwhile workarounds here are still required.

@freddiN
Copy link
Author
freddiN commented Nov 8, 2024

@filipelautert
I perfectly understand that. Spring Boot 3.4.0 will ship with 4.29 as mentioned here (spring-projects/spring-boot#43067), and people can always choose to not upgrade or use the env.
I still think its a good idea to have all relevant configuration at one place for Spring Boot/Liquibase users, so to me enabling them to introduce another spring.liquibase.xyz property for their users to use (even if its not now, but in the forseeable future) would be a benefit.

@filipelautert
Copy link
Collaborator

I still think its a good idea to have all relevant configuration at one place for Spring Boot/Liquibase users, so to me enabling them to introduce another spring.liquibase.xyz property for their users to use (even if its not now, but in the forseeable future) would be a benefit.

@freddiN sorry, I didn't mean that we should not add the flag. In fact it would be good to open the PR for springboot as soon as possible so it makes it to 3.5.0 , meanwhile we can coordinate in Liquibase side to support it in SpringLiquibase class for 4.30.x+ . But until there using the System property is the way to go and it's "documented" here ;)

@lbadam
Copy link
lbadam commented Nov 8, 2024

I also agree with @filipelautert. Adding a reminder that analytics are also only included in 4.30.x+ and are not present in any previous versions.

@lbadam lbadam moved this from New to Candidate in Liquibase Open Source Nov 8, 2024
@filipelautert filipelautert moved this from Candidate to Development in Liquibase Open Source Nov 11, 2024
@filipelautert filipelautert self-assigned this Nov 14, 2024
@filipelautert filipelautert moved this from Development to In Development PR Issues in Liquibase Open Source Nov 14, 2024
@filipelautert
Copy link
Collaborator
filipelautert commented Nov 14, 2024

Liquibase PR and next steps: #6516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Development PR Issues
Development

No branches or pull requests

5 participants