-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method for Spring Boot to configure the new analytics feature #6501
Comments
Workaround: |
It's generally disappointing that analytics was made opt-out by default for the OSS Liquibase community. I hope there will be reconsideration about this. |
@freddiN thanks for filing this issue. It is something we will take into consideration. With the various workarounds already available it is a lower priority for us right now. To get it in faster, we would accept a PR from the larger community. |
@rdhzl I wrote extensively in this PR about our reasoning and why these anonymous analytics are helpful to the project overall. We have provided many ways to opt-out, and plan to continue with the current direction. |
@freddiN A flag would be really nice! But even if we open the request now it will be present only in the next springboot version, so meanwhile workarounds here are still required. |
@filipelautert |
@freddiN sorry, I didn't mean that we should not add the flag. In fact it would be good to open the PR for springboot as soon as possible so it makes it to |
I also agree with @filipelautert. Adding a reminder that analytics are also only included in 4.30.x+ and are not present in any previous versions. |
Liquibase PR and next steps: #6516 |
Search first
Description
I would like to see an easily usable configuration to configure the new analytics feature through Spring Boot.
So far its configurable through the maven client, the config file (liquibase.properties) and via env, but its not configurable through Spring Boot (setting a global env aside).
This would enable the spring boot guys to introrudce e.g. a spring.liquibase.xyz flag.
Steps To Reproduce
Use 4.30.0 through Spring Boot
Expected/Desired Behavior
Having a flag you can set to true or false to switch it on or off
Liquibase Version
4.30.0
Database Vendor & Version
No response
Liquibase Integration
spring boot
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: