-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dataType in createSequence for more DBMS #6421
Comments
@Alienmario thanks for filing this issue. To clarify, are you suggesting that we need to update the |
No, I am asking to implement/allow specifying dataType for additional databases, similiar to mentioned PR. |
@Alienmario ok. If a DB has support for dataType it should automatically work unless it's in this list. That list does include HSQLDB and MSSQL so we can start by rechecking those and removing them from the list. Are you open to submitting a PR for those changes? |
@lbadam Sure, I can have a try at it. Browsing the CreateSequenceGenerator code, i'm noticing additional discrepancies between databases:
|
Search first
Description
It seems that a "data type" parameter for sequence creation is available more broadly than liquibase currently supports.
I have checked HSQLDB and MSSQL, both appear to support it.
Related to #3328, which added such support for DB2LUW.
Steps To Reproduce
Run on HSQLDB or MSSQL
<createSequence sequenceName="MY_SEQUENCE" dataType="BIGINT" startValue="1" incrementBy="1"/>
Expected/Desired Behavior
No validation failures
Liquibase Version
4.28.0
Database Vendor & Version
hsqldb 2.7.2
Liquibase Integration
maven
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: