[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming lagoon projects #8

Open
pirog opened this issue Jun 29, 2020 · 5 comments
Open

Naming lagoon projects #8

pirog opened this issue Jun 29, 2020 · 5 comments
Assignees

Comments

@pirog
Copy link
Member
pirog commented Jun 29, 2020

Currently Lando will use the project in the lagoon.yml regardless of whether you've specified a different name in the Landofile or with the --name flag on init. I think we'd like to change the flow here:

  1. On lando init allow usage of the --name flag and set its default to the project of the lagoon.yml if possible
  2. If there is already a Landofile in the initialized repo with a name, use that instead of overriding it with the lagoon.project.

Notes:

  • Changing this is likely going to break all our lagoon tests so we will need to refactor them.
@tobybellwood
Copy link
Collaborator

Probably instead of using the project from .lagoon.yml as a default, it might be better to use LAGOON_PROJECT from the docker-compose.yml - as project isn't actually required for Lagoon AFAIK?

https://github.com/amazeeio/drupal-example-simple/blob/8.x/docker-compose.yml#L16

@pirog
Copy link
Member Author
pirog commented Jul 6, 2020

Going to block this until we figure out lando/lando#2450

@thom8
Copy link
thom8 commented Jul 13, 2020

If the --name is supplied it should overwrite project defined in .lagoon.yml, this should be the same as the project name from the lagoon API.

I could update our drush alias scripts to check for the existence of a lando project name a use this by default, that way the project in .lagoon.yml would not need to be set at all if using lando.

lando/lando#2450 (comment)

@pirog
Copy link
Member Author
pirog commented Jul 14, 2020

I'm going to keep this open but Lando will now throw an error if lagoon.project is not set, otherwise it will ensure that lando.name always matches lagoon.project

@stale
Copy link
stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@rtfm-47 rtfm-47 transferred this issue from lando/lando Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants