incus-simplestreams: Add prune command #1381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
Nov 15, 2024
| cmd.Use = "prune" | ||
| cmd.Short = "Clean up obsolete files and data" | ||
| cmd.Long = cli.FormatSection("Description", | ||
| `Cleans up obsolote tarball files and removes outdated versions of a product |
stgraber
reviewed
Nov 15, 2024
Comment on lines
37
to
38
| The prune command identifies and deletes older versions of product data, | ||
| retaining only the most recent existing version.`) |
There was a problem hiding this comment.
That last paragraph and the fact that the prune command has prune-versions flag is pretty confusing.
I think I'd rephrase that last paragraph as:
Additionally this command will delete older images, keeping a configurable number of older images per product.
Then instead of prune-version we should probably just have a --retention flag which defaults to 2 as in we'll keep two older versions of the product by default (same as we do on the public image server).
There was a problem hiding this comment.
So running incus-simplestreams prune should:
- Find any orphaned files (no record in the index) and delete them
- Find any broken image and delete them from the index
- Find any product that has more than 1+flagRetention images and delete the older ones
There was a problem hiding this comment.
What do you mean by broken image?
There was a problem hiding this comment.
That would be an image that's in the index but for which some of the files are missing on disk.
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
a27236f
to
811e479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prune command to incus-simplestreams which:
Closes #1303