[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validations don't show up in Algolia search #1247

Open
wout opened this issue Sep 25, 2023 · 3 comments
Open

Validations don't show up in Algolia search #1247

wout opened this issue Sep 25, 2023 · 3 comments

Comments

@wout
Copy link
Contributor
wout commented Sep 25, 2023 •
edited
Loading

I ran into this a few times already; validations don't show up in the search results. So if you search for uniqueness, inclusion or even the full validate_uniqueness_of for example, there's no link to that page.

I'm not sure what needs to happen to include them, but I'm open to creating a PR if anyone can give me some pointers.
@matthewmcgarvey
Copy link
Member

Validations: https://luckyframework.org/guides/database/callbacks-and-validations#validations

I think the solution would be moving away from a table and to separate sections for each. I looked around for an existing pattern to follow in the guides and this looks to be the same basic structure that we could migrate to https://luckyframework.org/guides/frontend/html-forms#input-fields

It's just a matter of whether we want to or not.

@wout
Copy link
Contributor Author
wout commented Sep 25, 2023

Right, so that would be migrating to h3's for each validation? Maybe that could even be useful. It would allow more info which can be useful for validations with complicated or multiple options.

@jwoertink
Copy link
Member

I think we can tell it how to get the info from tables. We need to check that we're using v3, but there's this https://docsearch.algolia.com/docs/record-extractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwoertink @wout @matthewmcgarvey