[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-learn wrappers in keras #20399

Open
adrinjalali opened this issue Oct 23, 2024 · 5 comments
Open

scikit-learn wrappers in keras #20399

adrinjalali opened this issue Oct 23, 2024 · 5 comments
Assignees
Labels
type:feature The user is asking for a new feature.

Comments

@adrinjalali
Copy link

tf.keras.wrappers used to have scikit-learn wrappers, which were then deprecated and https://github.com/adriangb/scikeras was born at the same time.

However, scikeras doesn't seem to be maintained much at the moment (adriangb/scikeras#329), and keras has left TF namespace in the meantime. I was wondering if you'd consider adding those wrappers back. I'd be happy to help (as a scikit-learn maintainer) if y'all decide to add them again.

I couldn't find this discussion in the repo, sorry if I've missed it.

@fchollet
Copy link
Contributor

Thanks for the suggestion! I think these wrappers do provide value to the community.

I'd be happy to help (as a scikit-learn maintainer) if y'all decide to add them again.

Maybe you could take over the scikeras repo / package if the initial author is ok with that? I still think this functionality works better as a 3rd party package. But also open to have it in core Keras if there's a good reason for that.

@mehtamansi29 mehtamansi29 added the keras-team-review-pending Pending review by a Keras team member. label Oct 25, 2024
@adrinjalali
Copy link
Author

It seems a major part of the work on the scikeras part has been to keep it up-to-date with the latest keras versions, and seems challenging to support multiple versions of keras at the same time. One can of course lock the versions against keras versions, but it seems an easier thing to maintain if it were inside the keras repo and released together. This way whatever code in the wrapper, needs to support only a single version of keras since they're packaged together; so that's something to consider.

@fchollet
Copy link
Contributor

Ok, that's a good argument. If you'd like to open a PR, we'll review it.

@adrinjalali
Copy link
Author

Cool. Will work on a PR then. Thanks 🙏🏼

@adriangb
Copy link
Contributor
adriangb commented Nov 4, 2024

Thanks folks.

François I appreciate your help maintaining SciKeras over the years, it had a great impact on my career to be able to work with kind, knowledgable folks such as yourself.

Unfortunately I have not used Keras or SciKeras in at my day job in years (I'm more on the data engineering side now) so I agree someone else taking over the project or it being moved back into Keras would be best. I think the latter is the better move, if it can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants