This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
check for sigint before setting exit code to 1 - Fixes #180 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 65 68 +3
Branches 16 17 +1
=====================================
+ Hits 65 68 +3
Continue to review full report at Codecov.
|
kentcdodds
reviewed
May 22, 2018
kentcdodds
approved these changes
May 22, 2018
This was referenced May 28, 2018
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix #180. Change logic in child process exit listener to the following:
How:
See #180 for documentation of how fix was found/decided on.
Checklist:
I couldn't get the precommit hooks to work, but I ran validate, build, test, and manually used the all-contributors-cli to add myself to that section.
@kentcdodds I didn't feel like this needed any documentation outside of the code, feel free to point me where some could be used if there is a place.