[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching tabs in a library doesn't change the tab URL parameter #5868

Closed
Kladki opened this issue Aug 3, 2024 · 4 comments
Closed

Switching tabs in a library doesn't change the tab URL parameter #5868

Kladki opened this issue Aug 3, 2024 · 4 comments
Labels
enhancement Improve existing functionality or small fixes

Comments

@Kladki
Copy link
Kladki commented Aug 3, 2024 •
edited
Loading

Describe The Bug

When switching tabs in any library view, the tab URL parameter doesn't change, meaning that when you refresh or share the page, you end up on the page that you originally started on

Steps To Reproduce

  1. Click on any library from the home page
  2. Switch tabs (e.g. to "suggested", "genres", etc.)
  3. Reload the page
  4. End up on the tab you started on

Expected Behavior

The tab should not change when refreshed, by changing the tab parameter whenever the tab changes.

System (please complete the following information):

  • Platform: Linux
  • Browser: Firefox
  • Jellyfin Version: 10.9.8

Example

2024-08-03.15-27-50.mp4
@Kladki Kladki added the bug Something isn't working label Aug 3, 2024
@prsantos-com
Copy link
Contributor
prsantos-com commented Aug 21, 2024 •
edited
Loading

Confirmed that this bug exists today in master.

It mainly has to do with how navigation occurs. When selecting any of the link tabs, navigation occurs through the ControllerFactory.

If you select any of the links in the side bar, then navigation occurs through the appRouter, which will appropriately change the route and by default, set the tab parameter.

image

@viown
Copy link
Member
viown commented Aug 25, 2024

Note that this works as expected on the experimental layout.

@prsantos-com
Copy link
Contributor

With that being said, does it still make sense to fix this bug? I'm wondering, because if the experimental layout will no longer be experimental soon, then maybe it doesn't make sense to fix.

@thornbill
Copy link
Member

I don't think it is worth the effort to try to fix this in the legacy code. This is how the tabs have always behaved there so it isn't a regression.

@thornbill thornbill added enhancement Improve existing functionality or small fixes and removed bug Something isn't working labels Oct 16, 2024
@thornbill thornbill closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@prsantos-com @thornbill @viown @Kladki